fix: correct Google credential validation, inbound memory phone propagation, and call metadata status schema

elt7613 · elt7613 · commit 4be8df7ee7a6 · 2026-03-18T21:20:59.000+05:30
- Fix inverted credential guard in Google STT/TTS plugins so that
  GOOGLE_APPLICATION_CREDENTIALS env-var-based setups work correctly
  (require at least one of credentials_info or credentials_file).
- Add update_phone_number() to AgentSetup to propagate SIP caller number
  into memory key at runtime; remove incorrect agent_number fallback from
  inbound metadata phone assignment.
- Allow MemoryService.update_phone_number() to handle changed numbers
  (not just empty initial state).
- Normalize call metadata schema: keep status as a plain string and
  introduce termination_reason as a separate field for consistency.
- Correct TTS.from_config return type annotation from 'STT' to 'TTS'.
diff --git a/siphon/agent/core/entrypoint.py b/siphon/agent/core/entrypoint.py
@@ -251,7 +251,7 @@ async def _setup_memory_and_agent(
         # Try to get phone number from metadata
         if is_inbound_call:
             # For inbound, we'll get it from SIP participant later
-            phone_number = metadata.get("user_number") or metadata.get("agent_number")
+            phone_number = metadata.get("user_number")
         else:
             # For outbound, it's the number we called
             phone_number = metadata.get("number_to_call") or metadata.get("user_number")
diff --git a/siphon/agent/core/voice_agent.py b/siphon/agent/core/voice_agent.py
@@ -46,7 +46,7 @@ def __init__(self,
         system_instructions: str, 
         interruptions_allowed: bool,
         room: rtc.Room = None,
-        phone_number: str = None,
+        phone_number: Optional[str] = None,
         remember_call: bool = False,
         memory_service: Optional[MemoryService] = None,
     ) -> None:
@@ -166,6 +166,19 @@ async def _send_greeting_task(self):
         except Exception as e:
             logger.error(f"Greeting error: {e}", exc_info=True)
 
+    def update_phone_number(self, phone_number: Optional[str]) -> None:
+        """Update memory phone number when SIP participant data becomes available."""
+        if not phone_number:
+            return
+
+        if phone_number != self._call_memory_phone:
+            self._call_memory_phone = phone_number
+
+            if self._memory_service:
+                self._memory_service.update_phone_number(phone_number)
+
+            logger.info(f"Updated call memory phone number: {phone_number}")
+
     # Agent lifecycle
     async def on_enter(self):
         """Send an optional greeting when the agent joins the room."""
@@ -220,4 +233,4 @@ async def on_exit(self):
                     llm=actual_llm
                 )
             except Exception as e:
-                logger.error(f"Error saving call memory: {e}")
+                logger.error(f"Error saving call memory: {e}")
diff --git a/siphon/config/call_metadata.py b/siphon/config/call_metadata.py
@@ -124,7 +124,7 @@ def _set_timing_metadata(self, metadata: dict, start_time: float = None, end_tim
         metadata['duration'] = end_time - start_time
         metadata['timezone'] = get_timezone_name() or "local"
 
-    def _determine_call_status(self, response) -> tuple:
+    def _determine_call_status(self, response) -> tuple[str, str]:
         """Determine call status and termination reason"""
         if not response:
             has_conversation = hasattr(self, 'conversation_history') and len(self.conversation_history) > 0
@@ -138,8 +138,9 @@ def _determine_call_status(self, response) -> tuple:
             status = self.STATUS_MAPPING.get(response.status, 'completed')
         else:
             status = 'completed'
-        
-        return status
+
+        termination_reason = '' if status == 'completed' else status
+        return status, termination_reason
 
     def _get_recording_filename(self, response) -> str:
         """Extract recording filename from response"""
@@ -191,6 +192,7 @@ async def save_unanswered_call_metadata(self, reason: str = "not_answered") -> N
             
             # Set status and termination reason
             metadata['status'] = reason
+            metadata['termination_reason'] = reason
             # Explicit answered flag for downstream consumers
             metadata['answered'] = False
             metadata['recording_filename'] = ''
@@ -240,8 +242,9 @@ async def save_call_metadata(self, response) -> None:
                 self._set_timing_metadata(metadata, start_timestamp, end_timestamp)
                 
                 # Determine status and termination reason
-                status = self._determine_call_status(response)
+                status, termination_reason = self._determine_call_status(response)
                 metadata['status'] = status
+                metadata['termination_reason'] = termination_reason
                 # Call reached a state where recording response exists -> treat as answered
                 metadata['answered'] = True
                 
@@ -256,8 +259,9 @@ async def save_call_metadata(self, response) -> None:
                 self._set_timing_metadata(metadata, start_timestamp, current_time)
                 
                 # Determine status for no-response scenario using the actual duration
-                status = self._determine_call_status(response)
+                status, termination_reason = self._determine_call_status(response)
                 metadata['status'] = status
+                metadata['termination_reason'] = termination_reason
                 metadata['recording_filename'] = ''
 
                 # Heuristic answered flag when we have no recording response:
diff --git a/siphon/memory/service.py b/siphon/memory/service.py
@@ -52,7 +52,7 @@ def phone_number(self) -> Optional[str]:
 
     def update_phone_number(self, phone_number: str) -> None:
         """Update the phone number for this service instance."""
-        if phone_number and not self._phone_number:
+        if phone_number and phone_number != self._phone_number:
             self._phone_number = phone_number
             logger.info(f"Memory service phone number updated: {phone_number}")
 
diff --git a/siphon/plugins/google.py b/siphon/plugins/google.py
@@ -29,8 +29,10 @@ def __init__(
         self.credentials_info = credentials_info
         self.credentials_file = credentials_file
 
-        if not self.credentials_info or self.credentials_file: 
-            raise ValueError("GOOGLE_APPLICATION_CREDENTIALS location is required as environment variable or credentials_info (Array) is required")
+        if not self.credentials_info and not self.credentials_file:
+            raise ValueError(
+                "GOOGLE_APPLICATION_CREDENTIALS environment variable or credentials_info is required"
+            )
 
         self._client = self._build_client()
 
@@ -96,8 +98,10 @@ def __init__(
         self.credentials_info = credentials_info
         self.credentials_file = credentials_file
 
-        if not self.credentials_info or self.credentials_file: 
-            raise ValueError("GOOGLE_APPLICATION_CREDENTIALS location is required as environment variable or credentials_info (Array) is required")
+        if not self.credentials_info and not self.credentials_file:
+            raise ValueError(
+                "GOOGLE_APPLICATION_CREDENTIALS environment variable or credentials_info is required"
+            )
 
         self._client = self._build_client()
 
@@ -126,12 +130,12 @@ def to_config(self) -> dict:
 
     # Recreate STT from config dict
     @classmethod
-    def from_config(cls, cfg: dict) -> "STT":
+    def from_config(cls, cfg: dict) -> "TTS":
         return cls(
             language=cfg.get("language", "en-US"),
             gender=cfg.get("gender", "female"),
             voice_name=cfg.get("voice_name", "en-US-Standard-H"),
             voice_cloning_key=cfg.get("voice_cloning_key"),
             sample_rate=cfg.get("sample_rate", 24000),
             credentials_info=cfg.get("credentials_info")
-        )
+        )
