Apply suggestions from code review

patrickhulce · web-flow · commit 1f513309b39e · 2021-04-07T17:22:49.000-05:00
diff --git a/index.d.ts b/index.d.ts
@@ -2,7 +2,6 @@ export interface RawImageData<T> {
   width: number;
   height: number;
   data: T;
-  comments?: string[];
 }
 
 type BufferRet = RawImageData<Buffer>;
@@ -11,7 +10,7 @@ type UintArrRet = RawImageData<Uint8Array>;
 type ImageData = BufferRet | UintArrRet;
 type BufferLike = Buffer | Uint8Array | ArrayLike<number> | Iterable<number> | ArrayBuffer;
 
-export declare function encode(imgData: RawImageData<BufferLike>, quality?: number): BufferRet & {comments?: string[]};
+export declare function encode(imgData: RawImageData<BufferLike> & {comments?: string[]}, quality?: number): BufferRet
 
 export declare function decode(
   jpegData: BufferLike,
diff --git a/lib/encoder.js b/lib/encoder.js
@@ -798,7 +798,6 @@ function encode(imgData, qu) {
     data: data,
     width: imgData.width,
     height: imgData.height,
-	comments: imgData.comments
   };
 }
 
diff --git a/test/index.js b/test/index.js
@@ -202,6 +202,7 @@ it('should be able to create a JPEG from an array with comment', function () {
   expect(jpegImageData.height).toEqual(height);
   var expected = fixture('redbox_comment.jpg');
   expect(jpegImageData.data).toEqual(expected);
+  expect(jpeg.decode(jpegImageData.data).comments).toEqual(['First comment', 'second comment']);
 });
 
 it('should be able to decode a JPEG into a typed array', function () {
