fix: more descriptive error for exceeding maxLength buffer (jpeg-js#62)

donmahallem · patrickhulce · commit 275c852ceabf · 2020-01-15T11:18:38.000-06:00
diff --git a/lib/decoder.js b/lib/decoder.js
@@ -1016,13 +1016,23 @@ function decode(jpegData, opts) {
   decoder.colorTransform = opts.colorTransform;
 
   var channels = (opts.formatAsRGBA) ? 4 : 3;
-  var image = {
-    width: decoder.width,
-    height: decoder.height,
-    data: opts.useTArray ?
-      new Uint8Array(decoder.width * decoder.height * channels) :
-      new Buffer(decoder.width * decoder.height * channels)
-  };
+  var bytesNeeded = decoder.width * decoder.height * channels;
+  try {
+    var image = {
+      width: decoder.width,
+      height: decoder.height,
+      data: opts.useTArray ?
+        new Uint8Array(bytesNeeded) :
+        new Buffer(bytesNeeded)
+    };
+  } catch (err){
+    if (err instanceof RangeError){
+      throw new Error("Could not allocate enough memory for the image. " +
+                      "Required: " + bytesNeeded);
+    } else {
+      throw err;
+    }
+  }
 
   decoder.copyToImageData(image, opts.formatAsRGBA);
 
