Butterfly view #162
Draft
Butterfly view #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Java CI with Gradle failed: |
d8fab3b to
2974e55
Compare
Now the predecessors values have the following meaning: - cumulativeWeight represents the total work in the profile - weight represents the impact of the callee in the predecessor (the impact is the cumulative weight of the callee)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently work in progress to produce a butterfly (also called a sandwich view).
FlamegraphViewFix the predecessors (callers), currently theweightandcumulative Weightare at odd with the converter's expectation.Now the
weightandcumulativeWeighthave a different meaning for predecessors, respectively theweightis the impact on the callers in the current backtrace, andcumulativeWeigthis the total amount of the predecessor in this profile (in the selected events)FlamegraphVew)Fix #108