Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 6cd19e0

Browse files
charpenicharpeni
authored
build(dev-deps): upgrade dev dependencies (#443)
1 parent d6067ca commit 6cd19e0

File tree

12 files changed

+2223
-2923
lines changed

12 files changed

+2223
-2923
lines changed

‎.eslintrc.yaml‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
env:
2-
es6: true
3-
node: true
2+
es6: true
3+
node: true
44

55
extends:
6-
- airbnb-base/legacy
7-
- plugin:jest/recommended
8-
- plugin:prettier/recommended
6+
- airbnb-base/legacy
7+
- plugin:jest/recommended
8+
- plugin:prettier/recommended
99

10-
parser: babel-eslint
10+
parser: '@babel/eslint-parser'
1111
parserOptions:
12-
ecmaVersion: 8
13-
sourceType: module
12+
ecmaVersion: 8
13+
sourceType: module
1414

1515
rules:
16-
no-alert: error
17-
no-console: error
18-
no-constant-condition: error
19-
func-names: error
16+
no-alert: error
17+
no-console: error
18+
no-constant-condition: error
19+
func-names: error

‎.github/ISSUE_TEMPLATE.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!-- Please don't delete this template or we'll close your issue -->
22
<!-- Before creating an issue please make sure you are using the latest version of webpack. -->
33

4-
**Do you want to request a *feature* or report a *bug*?**
4+
**Do you want to request a _feature_ or report a _bug_?**
55

66
<!-- Please ask questions [on Slack](https://join.slack.com/t/bundlewatch-bundlewatch/shared_invite/enQtMzUwNjYxNTMwMzcyLWE5NGI4MzZjMjM4MTRlYzllOTMwYzIzZWNjM2MyMjBmMzNjNGM0ZGVhODc2YjFkNzIwMzNkYjk3NzE0MjZkOTc) -->
77

‎.github/workflows/auto-approve.yml‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ name: Auto approve
22
on: pull_request
33

44
jobs:
5-
build:
6-
runs-on: ubuntu-latest
7-
steps:
8-
- uses: hmarr/[email protected]
9-
if: github.actor == 'dependabot[bot]' || github.actor == 'dependabot-preview[bot]'
10-
with:
11-
github-token: "${{ secrets.GITHUB_TOKEN }}"
5+
build:
6+
runs-on: ubuntu-latest
7+
steps:
8+
- uses: hmarr/[email protected]
9+
if: github.actor == 'dependabot[bot]' || github.actor == 'dependabot-preview[bot]'
10+
with:
11+
github-token: '${{ secrets.GITHUB_TOKEN }}'

‎.husky/pre-commit‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
#!/bin/sh
2+
. "$(dirname "$0")/_/husky.sh"
3+
4+
./scripts/check-versions.sh && npx lint-staged

‎.prettierrc.yaml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,3 @@ tabWidth: 4
22
semi: false
33
singleQuote: true
44
trailingComma: all
5-

‎CONTRIBUTING.md‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,16 @@ Run `make help` for all the local development options.
55
Generally:
66
`make install`
77
and then
8+
89
```
910
make bundlewatch FLAGS="--help"
1011
```
11-
Will get you started.
1212

13+
Will get you started.
1314

1415
Anything related to https://service.bundlesize.io/ is over at https://github.com/bundlewatch/service
1516

16-
1717
Anything related to https://bundlesize.io/ is over at https://github.com/bundlewatch/bundlewatch.io
1818

19-
2019
If you need more information
2120
[hit us on Slack](https://join.slack.com/t/bundlewatch/shared_invite/enQtMzUwNjYxNTMwMzcyLWE5NGI4MzZjMjM4MTRlYzllOTMwYzIzZWNjM2MyMjBmMzNjNGM0ZGVhODc2YjFkNzIwMzNkYjk3NzE0MjZkOTc)

‎README.md‎

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ Inspired by [Siddharth Kshetrapal bundlesize][bundlesize]
3434

3535
Install the BundleWatch package:
3636

37-
- NPM: `npm install bundlewatch --save-dev`
38-
- Yarn: `yarn add bundlewatch --dev`
37+
- NPM: `npm install bundlewatch --save-dev`
38+
- Yarn: `yarn add bundlewatch --dev`
3939

4040
Add some basic configuration to your `package.json`
4141

@@ -56,8 +56,8 @@ Add some basic configuration to your `package.json`
5656

5757
Usage:
5858

59-
- NPM: `npm run bundlewatch`
60-
- Yarn: `yarn run bundlewatch`
59+
- NPM: `npm run bundlewatch`
60+
- Yarn: `yarn run bundlewatch`
6161

6262
This will give you command line output. If you want BundleWatch to report build status on your pull requests, see below.
6363

@@ -71,7 +71,7 @@ BundleWatch can report its status on your GitHub Pull Requests.
7171

7272
## CI Auth Variables Needed by BundleWatch
7373

74-
- `BUNDLEWATCH_GITHUB_TOKEN`
74+
- `BUNDLEWATCH_GITHUB_TOKEN`
7575

7676
You will need to give BundleWatch access to your GitHub Statuses, which can be done by heading to:
7777
[https://service.bundlewatch.io/setup-github][setup-github-url]
@@ -82,10 +82,10 @@ This will give you your `BUNDLEWATCH_GITHUB_TOKEN`. You will need to set this as
8282

8383
The most efficient way to get this running is to ensure that some environment variables are available for BundleWatch to find.
8484

85-
- `CI_REPO_OWNER` github.com/**facebook**/react
86-
- `CI_REPO_NAME` github.com/facebook/**react**
87-
- `CI_COMMIT_SHA`
88-
- `CI_BRANCH`
85+
- `CI_REPO_OWNER` github.com/**facebook**/react
86+
- `CI_REPO_NAME` github.com/facebook/**react**
87+
- `CI_COMMIT_SHA`
88+
- `CI_BRANCH`
8989

9090
If you're using, _Travis_, _CircleCI_, _Wrecker_, _Drone_ or _GitHub Actions_ these should all work out of the box.
9191

@@ -107,22 +107,22 @@ Full [documentation available on bundlewatch.io][bundlewatch-docs-url]
107107

108108
## I use bundlesize, why should I switch to BundleWatch
109109

110-
- Bundlesize has entered maintenance mode and pull requests are left hanging, so we wanted to reboot the community through creating BundleWatch
111-
- New [BundleWatch service][bundlewatch-service] with infrastructure as code
112-
- Launched [bundlewatch.io documentation website][bundlewatch-docs-url]
113-
- Enough test coverage to support CD
114-
- Node API Support
115-
- Lower barrier to contributing (automated testing and publishing), build a trusted community of contributors to have continuous improvement
110+
- Bundlesize has entered maintenance mode and pull requests are left hanging, so we wanted to reboot the community through creating BundleWatch
111+
- New [BundleWatch service][bundlewatch-service] with infrastructure as code
112+
- Launched [bundlewatch.io documentation website][bundlewatch-docs-url]
113+
- Enough test coverage to support CD
114+
- Node API Support
115+
- Lower barrier to contributing (automated testing and publishing), build a trusted community of contributors to have continuous improvement
116116

117117
## Additional Features
118118

119-
- [x] Config validation to stop users from guessing why BundleWatch won't work
120-
- [x] Support for config file path
121-
- [x] Better results breakdown page
122-
- [x] Better comparisons between branches, support branches other than master
123-
- [x] Support for your own server for storing data
124-
- [x] New and improved CI behaviour
125-
- [ ] Show history of BundleWatchs over time (coming soon)
119+
- [x] Config validation to stop users from guessing why BundleWatch won't work
120+
- [x] Support for config file path
121+
- [x] Better results breakdown page
122+
- [x] Better comparisons between branches, support branches other than master
123+
- [x] Support for your own server for storing data
124+
- [x] New and improved CI behaviour
125+
- [ ] Show history of BundleWatchs over time (coming soon)
126126

127127
## Contributors
128128

@@ -148,6 +148,7 @@ Thanks goes to these wonderful people ([emoji key][all-contrib-emoji-key]):
148148

149149
<!-- markdownlint-enable -->
150150
<!-- prettier-ignore-end -->
151+
151152
<!-- ALL-CONTRIBUTORS-LIST:END -->
152153

153154
This project follows the [all-contributors][all-contrib-url] specification.

‎package.json‎

Lines changed: 22 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@
1313
"files": [
1414
"lib"
1515
],
16-
"husky": {
17-
"hooks": {
18-
"pre-commit": "./scripts/check-versions.sh && lint-staged"
19-
}
20-
},
2116
"lint-staged": {
2217
"*.js": [
2318
"node_modules/.bin/eslint"
@@ -45,26 +40,25 @@
4540
"read-pkg-up": "^7.0.1"
4641
},
4742
"devDependencies": {
48-
"@babel/cli": "^7.8.4",
49-
"@babel/core": "^7.9.6",
50-
"@babel/plugin-proposal-object-rest-spread": "^7.9.6",
51-
"@babel/plugin-transform-modules-commonjs": "^7.9.6",
52-
"@babel/preset-env": "^7.9.6",
53-
"axios-mock-adapter": "^1.15.0",
54-
"babel-eslint": "^10.0.2",
55-
"coveralls": "^3.0.1",
56-
"eslint": "^7.2.0",
57-
"eslint-config-airbnb-base": "^14.0.0",
58-
"eslint-config-prettier": "^8.0.0",
59-
"eslint-plugin-import": "^2.18.0",
60-
"eslint-plugin-jest": "^23.8.2",
61-
"eslint-plugin-prettier": "^3.1.0",
62-
"husky": "^5.0.9",
63-
"jest": "^26.0.0",
64-
"jest-junit": "^12.0.0",
65-
"lint-staged": "^10.0.8",
66-
"prettier": "^2.0.5",
67-
"yarn-deduplicate": "^3.0.0"
43+
"@babel/cli": "^7.16.8",
44+
"@babel/core": "^7.16.7",
45+
"@babel/eslint-parser": "^7.16.5",
46+
"@babel/plugin-proposal-object-rest-spread": "^7.16.7",
47+
"@babel/plugin-transform-modules-commonjs": "^7.16.8",
48+
"@babel/preset-env": "^7.16.8",
49+
"axios-mock-adapter": "^1.20.0",
50+
"coveralls": "^3.1.1",
51+
"eslint": "^8.6.0",
52+
"eslint-config-airbnb-base": "^15.0.0",
53+
"eslint-config-prettier": "^8.3.0",
54+
"eslint-plugin-import": "^2.25.4",
55+
"eslint-plugin-jest": "^25.3.4",
56+
"eslint-plugin-prettier": "^4.0.0",
57+
"husky": "^7.0.0",
58+
"jest": "^27.4.7",
59+
"jest-junit": "^13.0.0",
60+
"lint-staged": "^12.1.7",
61+
"prettier": "2.5.1"
6862
},
6963
"jest": {
7064
"testEnvironment": "node",
@@ -90,5 +84,8 @@
9084
"maxSize": "15kB"
9185
}
9286
]
87+
},
88+
"scripts": {
89+
"prepare": "husky install"
9390
}
9491
}

‎src/app/analyze/analyze.test.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { mockFileResults } from './analyze.test.mockdata'
44
describe('getOverallDifference', () => {
55
describe('Results match snapshot for the same input', () => {
66
Object.keys(mockFileResults).forEach((mockFileResult) => {
7+
// eslint-disable-next-line jest/valid-title
78
it(mockFileResult, () => {
89
expect(
910
getOverallDifference(

‎src/app/analyze/index.js‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,10 @@ const getSummary = ({ overallStatus, fullResults, baseBranchName }) => {
6060

6161
let differenceSummary = ''
6262
if (baseBranchName) {
63-
const {
64-
totalAdded,
65-
totalRemoved,
66-
percentageChange,
67-
} = getOverallDifference(fullResults)
68-
const percentageChangeString = getPercentageChangeString(
69-
percentageChange,
70-
)
63+
const { totalAdded, totalRemoved, percentageChange } =
64+
getOverallDifference(fullResults)
65+
const percentageChangeString =
66+
getPercentageChangeString(percentageChange)
7167
const percentageChangeStringWithComma = percentageChangeString
7268
? `, ${percentageChangeString}`
7369
: ''

0 commit comments

Comments
 (0)