Modified mouse_timer_unref to account for errors

krikun98 · krikun98 · commit 728f42e27d15 · 2022-01-28T06:24:44.000+03:00
diff --git a/app/src/hid_listener.c b/app/src/hid_listener.c
@@ -115,7 +115,9 @@ void mouse_timer_ref() {
 }
 
 void mouse_timer_unref() {
-    mouse_timer_ref_count -= 1;
+    if (mouse_timer_ref_count > 0) {
+        mouse_timer_ref_count -= 1;
+    }
     if (mouse_timer_ref_count == 0) {
         k_timer_stop(&mouse_timer);
     }
@@ -139,6 +141,7 @@ static int hid_listener_mouse_released(const struct zmk_mouse_state_changed *ev)
     err = zmk_hid_mouse_movement_release(ev->x, ev->y);
     if (err) {
         LOG_ERR("Unable to release button");
+        mouse_timer_unref();
         return err;
     }
     mouse_timer_unref();

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,9 @@ void mouse_timer_ref() {`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`void mouse_timer_unref() {`
`118`		`- mouse_timer_ref_count -= 1;`
	`118`	`+ if (mouse_timer_ref_count > 0) {`
	`119`	`+ mouse_timer_ref_count -= 1;`
	`120`	`+ }`
`119`	`121`	`if (mouse_timer_ref_count == 0) {`
`120`	`122`	`k_timer_stop(&mouse_timer);`
`121`	`123`	`}`
`@@ -139,6 +141,7 @@ static int hid_listener_mouse_released(const struct zmk_mouse_state_changed *ev)`
`139`	`141`	`err = zmk_hid_mouse_movement_release(ev->x, ev->y);`
`140`	`142`	`if (err) {`
`141`	`143`	`LOG_ERR("Unable to release button");`
	`144`	`+ mouse_timer_unref();`
`142`	`145`	`return err;`
`143`	`146`	`}`
`144`	`147`	`mouse_timer_unref();`