You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Either the documentation should be fixed to say the provided timestamp should use the CANopen epoch or the line correcting the timestamp should be fixed to respect Python operator precedence:
delta = (timestamp or time.time()) - OFFSET
The text was updated successfully, but these errors were encountered:
Correct that OFFSET should be subtracted from either timestamp argument or time.time() for a time in CANopen epoch, but the current expression doesn't do that.
The documentation on
transmit
suggests the provided timestamp should be a UNIX timestamp, so have Epoch Jan 1 1970 UTC. However, the function does not correctly offset the provided timestamp as it does with the one produced internally if no timestamp is provided (https://canopen.readthedocs.io/en/latest/_modules/canopen/timestamp.html#TimeProducer.transmit).Either the documentation should be fixed to say the provided timestamp should use the CANopen epoch or the line correcting the timestamp should be fixed to respect Python operator precedence:
The text was updated successfully, but these errors were encountered: