QChem: parse the ALMO-CIS section for excitation quantities #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, time to turn that off. I'll just remove pre-commit.ci in favor of https://github.com/cclib/cclib-data/blob/13e62189b282166dcfaa706e55f0465dcf2021ea/.github/workflows/pre-commit.yml. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1631 +/- ##
==========================================
- Coverage 82.15% 82.06% -0.10%
==========================================
Files 74 74
Lines 15876 15895 +19
==========================================
+ Hits 13043 13044 +1
- Misses 2833 2851 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Done in #1632; I'll rewrite branch history when I fix the parsing issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1630
This first commit is almost 8 years old so I figured it's time to merge it. It used to work, but now the file doesn't parse.