-
Notifications
You must be signed in to change notification settings - Fork 311
Labels
bugIndicates an unexpected problem or unintended behaviorIndicates an unexpected problem or unintended behaviorcomponent: corehelp wantedIndicates that a maintainer wants help on an issue or pull requestIndicates that a maintainer wants help on an issue or pull request
Description
The recover_line_csv() function is joining data with \r\n, redgardless of the source file newlines:
Line 1042 in a2d20df
| tempdata = '\r\n'.join(self.tempdata) + '\r\n' if self.tempdata else '' |
This means that bot test are failing even though the parsing succeeded, because the raw values do not match: there is a new CR byte. As a workaround, bot tests are replacing newlines in their test files to account for that, which is not ideal solution.
| "raw": utils.base64_encode(SAMPLE_FILE.replace('\n', '\r\n')), |
Metadata
Metadata
Assignees
Labels
bugIndicates an unexpected problem or unintended behaviorIndicates an unexpected problem or unintended behaviorcomponent: corehelp wantedIndicates that a maintainer wants help on an issue or pull requestIndicates that a maintainer wants help on an issue or pull request