Merge pull request #12 from cfe-lab/FoldClinicalIn

rhliang · web-flow · commit 37d86c881344 · 2025-08-28T16:12:21.000-07:00
Fixed a mis-identified precondition that doesn't always hold relating to #11
diff --git a/src/hla_algorithm/models.py b/src/hla_algorithm/models.py
@@ -427,17 +427,14 @@ def _identify_longest_prefix(allele_prefixes: list[GeneCoord]) -> GeneCoord:
         """
         Identify the longest gene coordinate "prefix" in the given allele prefixes.
 
-        Precondition: that the input must all share at least the same first
-        coordinate.  The algorithm may not return cogent values if not.
-
-        Precondition: the specified allele prefixes do not all perfectly match,
-        so we lose nothing by trimming one coordinate off the end of all of
-        them.
+        Precondition: all allele prefixes in the input must all share at least
+        the same first coordinate.  The algorithm may not return cogent values
+        if not.
         """
         longest_prefix: GeneCoord = ()
         if len(allele_prefixes) > 0:
             max_length: int = max([len(allele) for allele in allele_prefixes])
-            for i in range(max_length - 1, 0, -1):
+            for i in range(max_length, 0, -1):
                 curr_prefixes: set[GeneCoord] = {allele[0:i] for allele in allele_prefixes}
                 if len(curr_prefixes) == 1:
                     longest_prefix = curr_prefixes.pop()
diff --git a/tests/models_test.py b/tests/models_test.py
@@ -1206,8 +1206,31 @@ def test_identify_clean_prefix_in_pairs(
                 (),
                 id="trivial_case",
             ),
-            # Note: we have no single allele tests because that contradicts one
-            # of our preconditions.
+            pytest.param(
+                [("C*01", "02", "03", "04G")],
+                ("C*01", "02", "03", "04G"),
+                id="single_input_length_4",
+            ),
+            pytest.param(
+                [("C*01", "02", "03")],
+                ("C*01", "02", "03"),
+                id="single_input_length_3",
+            ),
+            pytest.param(
+                [("C*01", "02")],
+                ("C*01", "02"),
+                id="single_input_length_2",
+            ),
+            pytest.param(
+                [("C*01",)],
+                ("C*01",),
+                id="single_input_length_1",
+            ),
+            pytest.param(
+                [("C*01", "02", "03", "04G"), ("C*01", "02", "03", "04G")],
+                ("C*01", "02", "03", "04G"),
+                id="best_match_length_4",
+            ),
             pytest.param(
                 [("C*01", "02", "03", "04G"), ("C*01", "02", "03", "110N")],
                 ("C*01", "02", "03"),
@@ -1248,6 +1271,11 @@ def test_identify_clean_prefix_in_pairs(
                 ("C*01",),
                 id="best_match_length_1_different_lengths_one_with_no_excess",
             ),
+            pytest.param(
+                [("C*01", "07", "88"), ("C*01", "07", "01"), ("C*01", "07", "01", "110N")],
+                ("C*01", "07"),
+                id="typical_case",
+            ),
         ],
     )
     def test_identify_longest_prefix(
