terms builder better support

eliranmoyal · eliranmoyal · commit 8f13ec9c44d9 · 2016-03-30T19:02:54.000+03:00
diff --git a/src/main/java/org/nlpcn/es4sql/query/AggregationQueryAction.java b/src/main/java/org/nlpcn/es4sql/query/AggregationQueryAction.java
@@ -56,7 +56,7 @@ public SqlElasticSearchRequestBuilder explain() throws SqlParseException {
 				Field field = groupBy.get(0);
 				lastAgg = aggMaker.makeGroupAgg(field);
 
-				if (lastAgg != null && lastAgg instanceof TermsBuilder) {
+				if (lastAgg != null && lastAgg instanceof TermsBuilder && !(field instanceof MethodField )) {
 					((TermsBuilder) lastAgg).size(select.getRowCount());
 				}
 
diff --git a/src/main/java/org/nlpcn/es4sql/query/maker/AggMaker.java b/src/main/java/org/nlpcn/es4sql/query/maker/AggMaker.java
@@ -229,6 +229,9 @@ private AggregationBuilder<?> termsAgg(MethodField field) throws SqlParseExcepti
                 case "shard_size":
                     terms.shardSize(Integer.parseInt(value));
                     break;
+                case "min_doc_count":
+                    terms.minDocCount(Integer.parseInt(value));
+                    break;
                 case "alias":
                 case "nested":
                 case "reverse_nested":
diff --git a/src/test/java/org/nlpcn/es4sql/AggregationTest.java b/src/test/java/org/nlpcn/es4sql/AggregationTest.java
@@ -255,6 +255,15 @@ public void multipleGroupBysWithSize() throws Exception {
     }
 
 
+    @Test
+    public void termsWithSize() throws Exception {
+
+
+        Aggregations result = query(String.format("SELECT COUNT(*) FROM %s/account GROUP BY terms('alias'='ageAgg','field'='age','size'=3)", TEST_INDEX));
+        Terms gender = result.get("ageAgg");
+        Assert.assertEquals(3,gender.getBuckets().size());
+
+    }
 
     @Test
 	public void orderByAscTest() throws IOException, SqlParseException, SQLFeatureNotSupportedException {

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public SqlElasticSearchRequestBuilder explain() throws SqlParseException {`
`56`	`56`	`Field field = groupBy.get(0);`
`57`	`57`	`lastAgg = aggMaker.makeGroupAgg(field);`
`58`	`58`
`59`		`- if (lastAgg != null && lastAgg instanceof TermsBuilder) {`
	`59`	`+ if (lastAgg != null && lastAgg instanceof TermsBuilder && !(field instanceof MethodField )) {`
`60`	`60`	`((TermsBuilder) lastAgg).size(select.getRowCount());`
`61`	`61`	`}`
`62`	`62`