TeamCity service: use config_boolean_true?; update doc

VladRassokhin · VladRassokhin · commit 39bec8ed55e1 · 2015-02-03T20:39:19.000+03:00
diff --git a/docs/teamcity b/docs/teamcity
@@ -1,5 +1,7 @@
 [TeamCity](https://www.jetbrains.com/teamcity/) is a continuous integration server that automates the building and testing of your software.
-The GitHub TeamCity service can be used to trigger builds after code has been pushed to your git repository.
+The GitHub TeamCity service can be used in two ways:
+* to trigger builds after code has been pushed to your git repository; (Default)
+* to enforce checking for changes after code has been pushed to your git repository. (see 7)
 
 Install Notes
 -------------
@@ -24,7 +26,10 @@ Install Notes
 6. "Full branch ref" if enabled full branch reference (e.g. 'refs/heads/master')
    will be send to TeamCity server. Otherwise 'refs/heads' will be omitted.
 
-7. Since TeamCity uses BASIC authentication, it is highly recommended that the
+7. "Check for pending changes" if enabled, service will force TeamCity server
+   to check for pending changes. Service will not trigger new build.
+
+8. Since TeamCity uses BASIC authentication, it is highly recommended that the
    TeamCity server use HTTPS/SSL to protect the password that is passed
    unencrypted over the internet.
 
diff --git a/lib/services/teamcity.rb b/lib/services/teamcity.rb
@@ -14,7 +14,7 @@ class Service::TeamCity < Service
   def receive_push
     return if payload['deleted']
 
-    check_for_changes_only = data['check_for_changes_only']
+    check_for_changes_only = config_boolean_true?('check_for_changes_only')
 
     branches = data['branches'].to_s.split(/\s+/)
     ref = payload["ref"].to_s
@@ -35,6 +35,7 @@ def receive_push
     build_type_ids.split(",").each do |build_type_id|
 
       if check_for_changes_only
+        # This is undocumented call. TODO: migrate to REST API (TC at least 8.0)
         res = http_get "httpAuth/action.html", :checkForChangesBuildType => build_type_id
       else
         res = http_get "httpAuth/action.html", :add2Queue => build_type_id, :branchName => branch
