Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Issue #11166: Remove usage of getFileContents() in UnusedImportsCheck #18057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Issue #11166: Remove usage of getFileContents() in UnusedImportsCheck #18057

wants to merge 1 commit into from
+36 −12

Conversation

@Hariom-kr
Copy link
Contributor

@Hariom-kr Hariom-kr commented Nov 5, 2025

@Hariom-kr
Copy link
Contributor Author

Hariom-kr commented Nov 5, 2025

Hii @romani, please help to resolve the failures

@Hariom-kr Hariom-kr marked this pull request as draft November 5, 2025 18:57
@Hariom-kr
Copy link
Contributor Author

Hariom-kr commented Nov 5, 2025 

-------------------------------------------------------------------------------
Test set: com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest
-------------------------------------------------------------------------------
Tests run: 26, Failures: 12, Errors: 0, Skipped: 0, Time elapsed: 1.132 s <<< FAILURE! -- in com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest
com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testUnusedImportsJavadocAboveComments -- Time elapsed: 0.050 s <<< FAILURE!
Violation lines for C:\Users\hario\checkstyle\src\test\resources\com\puppycrawl\tools\checkstyle\checks\imports\unusedimports\InputUnusedImportsJavadocAboveComments.java differ.
unexpected (1): 10
---
expected      : [11]
but was       : [10, 11]
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyViolations(AbstractModuleTestSupport.java:735)
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyWithInlineConfigParser(AbstractModuleTestSupport.java:275)
	at com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testUnusedImportsJavadocAboveComments(UnusedImportsCheckTest.java:389)

com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testStateIsClearedOnBeginTreeCollect -- Time elapsed: 0.051 s <<< FAILURE!
Violation lines for C:\Users\hario\checkstyle\src\test\resources\com\puppycrawl\tools\checkstyle\checks\imports\unusedimports\InputUnusedImportsRecordsAndCompactCtors.java differ.
unexpected (2): 13, 18
---
expected      : [19, 20]
but was       : [13, 18, 19, 20]
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyViolations(AbstractModuleTestSupport.java:708)
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyWithInlineConfigParser(AbstractModuleTestSupport.java:333)
	at com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testStateIsClearedOnBeginTreeCollect(UnusedImportsCheckTest.java:331)

com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testStaticMethodRefImportsInDocsOnly -- Time elapsed: 0.041 s <<< FAILURE!
Violation lines for C:\Users\hario\checkstyle\src\test\resources\com\puppycrawl\tools\checkstyle\checks\imports\unusedimports\InputUnusedImportsFromStaticMethodRefInDocsOnly.java differ.
unexpected (2): 9, 10
---
expected      : [11, 12, 13, 14]
but was       : [9, 10, 11, 12, 13, 14]
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyViolations(AbstractModuleTestSupport.java:735)
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyWithInlineConfigParser(AbstractModuleTestSupport.java:275)
	at com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testStaticMethodRefImportsInDocsOnly(UnusedImportsCheckTest.java:380)

com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testImportJavaLinkTagWithMethod -- Time elapsed: 0.039 s <<< FAILURE!
Violation lines for C:\Users\hario\checkstyle\src\test\resources\com\puppycrawl\tools\checkstyle\checks\imports\unusedimports\InputUnusedImportsWithLinkAndMethodTag.java differ.
unexpected (11): 11, 13, 15, 17, 18, 19, 21, 22, 23, 25, 26
---
expected       : [10, 12, 14, 16, 20, 24, 27]
but was        : [10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27]
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyViolations(AbstractModuleTestSupport.java:735)
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyWithInlineConfigParser(AbstractModuleTestSupport.java:275)
	at com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testImportJavaLinkTagWithMethod(UnusedImportsCheckTest.java:416)

com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testImportsJavadocQualifiedName -- Time elapsed: 0.024 s <<< FAILURE!
Violation lines for C:\Users\hario\checkstyle\src\test\resources\com\puppycrawl\tools\checkstyle\checks\imports\unusedimports\InputUnusedImportsJavadocQualifiedName.java differ.
unexpected (1): 10
---
expected      : [11]
but was       : [10, 11]
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyViolations(AbstractModuleTestSupport.java:735)
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyWithInlineConfigParser(AbstractModuleTestSupport.java:275)
	at com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testImportsJavadocQualifiedName(UnusedImportsCheckTest.java:271)

com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testProcessJavadocWithBlockTagContainingMethodParameters -- Time elapsed: 0.112 s <<< FAILURE!
Violation lines for C:\Users\hario\checkstyle\src\test\resources\com\puppycrawl\tools\checkstyle\checks\imports\unusedimports\InputUnusedImportsWithBlockMethodParameters.java differ.
expected to be empty
but was: [10, 11, 12]
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyViolations(AbstractModuleTestSupport.java:735)
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyWithInlineConfigParser(AbstractModuleTestSupport.java:275)
	at com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testProcessJavadocWithBlockTagContainingMethodParameters(UnusedImportsCheckTest.java:140)

com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testWithoutProcessJavadoc -- Time elapsed: 0.026 s <<< FAILURE!
Actual and expected violations differ.
expected to match: 31:(?:\d+:)?\s.*Unused import - java.io.File.createTempFile..*
but was          : 31:15: Unused import - java.io.File.//.
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyViolations(AbstractModuleTestSupport.java:739)
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyWithInlineConfigParser(AbstractModuleTestSupport.java:275)
	at com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testWithoutProcessJavadoc(UnusedImportsCheckTest.java:105)

com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testProcessJavadocWithLinkTag -- Time elapsed: 0.018 s <<< FAILURE!
Violation lines for C:\Users\hario\checkstyle\src\test\resources\com\puppycrawl\tools\checkstyle\checks\imports\unusedimports\InputUnusedImportsWithValueTag.java differ.
expected to be empty
but was: [10]
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyViolations(AbstractModuleTestSupport.java:735)
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyWithInlineConfigParser(AbstractModuleTestSupport.java:275)
	at com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testProcessJavadocWithLinkTag(UnusedImportsCheckTest.java:133)

com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testRecordsAndCompactCtors -- Time elapsed: 0.020 s <<< FAILURE!
Violation lines for C:\Users\hario\checkstyle\src\test\resources\com\puppycrawl\tools\checkstyle\checks\imports\unusedimports\InputUnusedImportsRecordsAndCompactCtors.java differ.
unexpected (2): 13, 18
---
expected      : [19, 20]
but was       : [13, 18, 19, 20]
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyViolations(AbstractModuleTestSupport.java:735)
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyWithInlineConfigParser(AbstractModuleTestSupport.java:275)
	at com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testRecordsAndCompactCtors(UnusedImportsCheckTest.java:291)

com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testNewlinesInsideTags -- Time elapsed: 0.033 s <<< FAILURE!
Violation lines for C:\Users\hario\checkstyle\src\test\resources\com\puppycrawl\tools\checkstyle\checks\imports\unusedimports\InputUnusedImportsWithNewlinesInsideTags.java differ.
expected to be empty
but was: [10, 11]
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyViolations(AbstractModuleTestSupport.java:735)
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyWithInlineConfigParser(AbstractModuleTestSupport.java:275)
	at com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testNewlinesInsideTags(UnusedImportsCheckTest.java:170)

com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testProcessJavadoc -- Time elapsed: 0.027 s <<< FAILURE!
Violation lines for C:\Users\hario\checkstyle\src\test\resources\com\puppycrawl\tools\checkstyle\checks\imports\unusedimports\InputUnusedImports.java differ.
unexpected (12): 34, 35, 37, 38, 39, 41, 42, 43, 44, 45, 46, 47
---
expected       : [11, 15, 17, 18, 21, 24, 26, 31, 36, 48]
but was        : [11, 15, 17, 18, 21, 24, 26, 31, 34, 35, 36, 37, 38, 39, 41, 42, 43, 44, 45, 46, 47, 48]
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyViolations(AbstractModuleTestSupport.java:735)
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyWithInlineConfigParser(AbstractModuleTestSupport.java:275)
	at com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testProcessJavadoc(UnusedImportsCheckTest.java:126)

com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testImportJavaLinkTag -- Time elapsed: 0.019 s <<< FAILURE!
Violation lines for C:\Users\hario\checkstyle\src\test\resources\com\puppycrawl\tools\checkstyle\checks\imports\unusedimports\InputUnusedImportsWithLinkTag.java differ.
unexpected (1): 11
---
expected      : [10, 12]
but was       : [10, 11, 12]
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyViolations(AbstractModuleTestSupport.java:735)
	at com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport.verifyWithInlineConfigParser(AbstractModuleTestSupport.java:275)
	at com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheckTest.testImportJavaLinkTag(UnusedImportsCheckTest.java:400)

@Hariom-kr
Copy link
Contributor Author

Hariom-kr commented Nov 5, 2025

I'm getting test failures where imports are incorrectly flagged as unused. Am I missing something in the textBlock conversion or javadoc extraction logic. More files needs to be changed ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Hariom-kr