% and _ escaping changed on LIKE operator NLPchina#137

eliranmoyal · eliranmoyal · commit 0b15c46b4046 · 2016-03-18T02:00:53.000+02:00
diff --git a/src/main/java/org/nlpcn/es4sql/query/maker/Maker.java b/src/main/java/org/nlpcn/es4sql/query/maker/Maker.java
@@ -156,9 +156,9 @@ private ToXContent make(Condition cond, String name, Object value) throws SqlPar
 			}
 		case LIKE:
         case NLIKE:
-			String queryStr = ((String) value).replace("[%]","ESCAPEDPERCENTAGE").replace("[_]","ESCAPEDUNDERSCORE");
+			String queryStr = ((String) value);
             queryStr = queryStr.replace('%', '*').replace('_', '?');
-            queryStr = queryStr.replace("ESCAPEDPERCENTAGE","%").replace("ESCAPEDUNDERSCORE","_");
+            queryStr = queryStr.replace("&PERCENT","%").replace("&UNDERSCORE","_");
 			WildcardQueryBuilder wildcardQuery = QueryBuilders.wildcardQuery(name, queryStr);
 			x = isQuery ? wildcardQuery : FilterBuilders.queryFilter(wildcardQuery);
 			break;
diff --git a/src/test/java/org/nlpcn/es4sql/SqlParserTests.java b/src/test/java/org/nlpcn/es4sql/SqlParserTests.java
@@ -782,7 +782,7 @@ public void fieldsAsNumbersOnWhere() throws SqlParseException {
 
     @Test
     public void likeTestWithEscaped() throws SqlParseException {
-        String query = "select * from x where name like '[_]hey_%[%]'";
+        String query = "select * from x where name like '&UNDERSCOREhey_%&PERCENT'";
         Select select = parser.parseSelect((SQLQueryExpr) queryToExpr(query));
         BoolFilterBuilder explan = FilterMaker.explan(select.getWhere());
         String filterAsString = explan.toString();
