Fix i18n API encoding#4505
Merged
Merged
Conversation
- Make `i18n_js_translations` call `_finish_ok` with an object response data like all the others - Fix `_finish` and `_finish_ok` documentation to reflect the expected `response_data` type for "json" `content_type`
Split long documentation lines
Member
|
Thanks @bzar! |
Member
|
@amercader i've checked, this dont need to be backported to 2.7.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4504
Proposed fixes:
i18n_js_translationscall_finish_okwith an object response data like all the others_finishand_finish_okdocumentation to reflect the expectedresponse_datatype for "json"content_typeFeatures: