Add $ anchor to log file regexps

babakks · babakks · commit b65286125b21 · 2025-04-11T12:41:31.000+01:00
Signed-off-by: Babak K. Shandiz &lt;babakks@github.com&gt;

This is to make sure we do not pick up the wrong file if there is a
`.txt` sequence in the middle of a job name.
diff --git a/pkg/cmd/run/view/view.go b/pkg/cmd/run/view/view.go
@@ -555,21 +555,21 @@ func getJobNameForLogFilename(name string) string {
 // number; e.g., "0_jobname.txt".
 func jobLogFilenameRegexp(job shared.Job) *regexp.Regexp {
 	sanitizedJobName := getJobNameForLogFilename(job.Name)
-	re := fmt.Sprintf(`^\d+_%s\.txt`, regexp.QuoteMeta(sanitizedJobName))
+	re := fmt.Sprintf(`^\d+_%s\.txt$`, regexp.QuoteMeta(sanitizedJobName))
 	return regexp.MustCompile(re)
 }
 
 // A legacy job run log file is a top-level .txt file whose name starts with a
 // negative number which is the ID of the run; e.g., "-2147483648_jobname.txt".
 func legacyJobLogFilenameRegexp(job shared.Job) *regexp.Regexp {
 	sanitizedJobName := getJobNameForLogFilename(job.Name)
-	re := fmt.Sprintf(`^-\d+_%s\.txt`, regexp.QuoteMeta(sanitizedJobName))
+	re := fmt.Sprintf(`^-\d+_%s\.txt$`, regexp.QuoteMeta(sanitizedJobName))
 	return regexp.MustCompile(re)
 }
 
 func stepLogFilenameRegexp(job shared.Job, step shared.Step) *regexp.Regexp {
 	sanitizedJobName := getJobNameForLogFilename(job.Name)
-	re := fmt.Sprintf(`^%s\/%d_.*\.txt`, regexp.QuoteMeta(sanitizedJobName), step.Number)
+	re := fmt.Sprintf(`^%s\/%d_.*\.txt$`, regexp.QuoteMeta(sanitizedJobName), step.Number)
 	return regexp.MustCompile(re)
 }
 
