Description
For reasons (mostly just being a long lived project afaik), there are a lot of commands that interact with the GitHub API directly via an http.Client rather than the api.Client (and associated go-gh api.Client underneath). This hasn't really been an issue, but now does present a challenge in supporting behaviour that should cross all API requests.
We should pay down some of this debt by trying to consolidate all (may end up being limited to most) API interactions behind the api client (or a similar abstraction).
There are a series of commands that should hopefully be lift-and-shift, and some that will require some more rework no longer having access to the original raw http response.
Expected Output
All (or most) api interactions go through the api client.
A comment is left on this issue explaining any interactions that could not go through the same api client.
Description
For reasons (mostly just being a long lived project afaik), there are a lot of commands that interact with the GitHub API directly via an
http.Clientrather than theapi.Client(and associatedgo-ghapi.Clientunderneath). This hasn't really been an issue, but now does present a challenge in supporting behaviour that should cross all API requests.We should pay down some of this debt by trying to consolidate all (may end up being limited to most) API interactions behind the api client (or a similar abstraction).
There are a series of commands that should hopefully be lift-and-shift, and some that will require some more rework no longer having access to the original raw http response.
Expected Output
All (or most) api interactions go through the api client.
A comment is left on this issue explaining any interactions that could not go through the same api client.