Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Switch to native bindings for macOS Keychain #7123

@mislav

Description

@mislav

Prerequisites:

  • our darwin builds should be code-signed and notarized
  • we should enable cgo in our darwin builds

Any reason why you are not using https://github.com/99designs/keyring besides the cgo problem? The zalando one forks a security command on MacOS, which is not a secure practice really.

I have to grant access to the security cli for the github auth token access, and security can then be invoked with any other shell script after that, losing control of who I grant access to those creds.
The 99designs lib does not have this problem, as it uses native API-s, so MacOS would prompt me to grant access to gh only.

Using the security cli tool directly opens up people's hosts to malicious shell scripts also being able to use the security cli tool and gaining access to the credentials, partially defeating the purpose of storing those secrets in the keychain.

Originally posted by @reegnz in #7023 (comment)

Metadata

Metadata

Assignees

Labels

blockedcoreThis issue is not accepting PRs from outside contributorsenhancementa request to improve CLIgh-authrelating to the gh auth command

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions