-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Closed
Labels
enhancementa request to improve CLIa request to improve CLIgh-extensionrelating to the gh extension commandrelating to the gh extension commandneeds-triageneeds to be reviewedneeds to be reviewed
Description
Describe the feature or problem you’d like to solve
There have been 2 improvements in cli/gh-extension-precompile that new Go extensions should take advantage of:
- Allow setting Go version from go.mod file gh-extension-precompile#46
- feat: add attestation support gh-extension-precompile#53
- upgrade to
actions/checkout@v4
Proposed solution
Update the Go release workflow below to 1) read Go version from go.mod and 2) generate attestations:
From this:
cli/pkg/cmd/extension/ext_tmpls/goBinWorkflow.yml
Lines 9 to 14 in b05bddc
| jobs: | |
| release: | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v3 | |
| - uses: cli/gh-extension-precompile@v1 |
To this:
jobs:
release:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: cli/gh-extension-precompile@v1
with:
generate_attestations: true
go_version_file: go.modAdditional context
Add any other context like screenshots or mockups are helpful, if applicable.
Metadata
Metadata
Assignees
Labels
enhancementa request to improve CLIa request to improve CLIgh-extensionrelating to the gh extension commandrelating to the gh extension commandneeds-triageneeds to be reviewedneeds to be reviewed