Avoid redirecting to localhost during authorization flow
#650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web developers who have previously ran an application on `http://localhost` that enabled HSTS (HTTP Strict Transport Security) will find themselves unable to authenticate because their browser (typically Safari, in practice) will keep redirecting them to `https://localhost`, which isn't handled by our local server. This switches the authorization callback to be to `127.0.0.1`, which should be equivalent to `localhost`, but not subject to HSTS.
vilmibm
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web developers who have had at any previous point ran an application on
http://localhostthat enabled HSTS (HTTP Strict Transport Security) will find themselves unable to authenticate because their browser (typically Safari) will keep redirecting them tohttps://localhost, which isn't handled by our local server.This switches the authorization callback to be to
127.0.0.1, which should be equivalent tolocalhost, but not subject to HSTS.The GitHub CLI OAuth apps have been edited to add
http://127.0.0.1/callbackas an additional allow-listed callback URL. /cc @ptoomey3Fixes #616