Thanks to visit codestin.com
Credit goes to github.com

Skip to content

100% test-coverage rule added to tox #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 17, 2020

Conversation

cumason123
Copy link
Contributor

Fixes #107, #105, #104

Changes

Tests now cover 100% of the codebase.
Tox has a new rule for 100% test-coverage
Added additional exception handling, and from_http input exception handling

One line description for the changelog

test coverage tox rule

  • [*] Tests pass
  • [*] Appropriate changes to README are included in PR

Curtis Mason and others added 7 commits August 16, 2020 16:24
Signed-off-by: Curtis Mason <[email protected]>
Signed-off-by: Curtis Mason <[email protected]>
Signed-off-by: Curtis Mason <[email protected]>
Signed-off-by: Curtis Mason <[email protected]>
Signed-off-by: Curtis Mason <[email protected]>
Signed-off-by: Curtis Mason <[email protected]>
@cumason123 cumason123 requested review from grayside and grant August 17, 2020 19:10
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks like we found some bugs too.

Copy link
Member

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Curtis Mason <[email protected]>
@cumason123 cumason123 changed the base branch from v1.0.2-dev to v1.1.0-dev August 17, 2020 20:20
@cumason123 cumason123 merged commit 3c26bcf into cloudevents:v1.1.0-dev Aug 17, 2020
@cumason123 cumason123 mentioned this pull request Aug 18, 2020
cumason123 added a commit that referenced this pull request Aug 18, 2020
* 100% test-coverage rule added to tox (#109)

* version bump

Signed-off-by: Curtis Mason <[email protected]>

* adding tests for marshaller

Signed-off-by: Curtis Mason <[email protected]>

* marshaller 100% test-coverage

Signed-off-by: Curtis Mason <[email protected]>

* bricked some tests

Signed-off-by: Curtis Mason <[email protected]>

* additional error handling

Signed-off-by: Curtis Mason <[email protected]>

* 100% test-coverage

Signed-off-by: Curtis Mason <[email protected]>

* handles empty data and capitalized headers

Signed-off-by: Curtis Mason <[email protected]>

* 1.1.0 version bump

Signed-off-by: Curtis Mason <[email protected]>

* Removed _http suffix from http_methods (#108)

* Removed _http suffix from http_methods

to_binary_http renamed to_binary, and to_structured_http renamed
to_structured. These functions are inside of cloudevents.http thus the
_http part should be implicitly understood.

Signed-off-by: Curtis Mason <[email protected]>

* version bump

Signed-off-by: Curtis Mason <[email protected]>

* deprecated instead of removal

Signed-off-by: Curtis Mason <[email protected]>

* Update setup.py

Co-authored-by: Dustin Ingram <[email protected]>
Signed-off-by: Curtis Mason <[email protected]>

* 1.1.0 version bump

Signed-off-by: Curtis Mason <[email protected]>

Co-authored-by: Dustin Ingram <[email protected]>

* swapped args for from_http (#110)

Signed-off-by: Curtis Mason <[email protected]>

* exception names shortened (#111)

* exception names shortened

Signed-off-by: Curtis Mason <[email protected]>

* to_structured documentation

Signed-off-by: Curtis Mason <[email protected]>

* adjusted readme and changelog (#113)

* adjusted readme and changelog

Signed-off-by: Curtis Mason <[email protected]>

* readme adjustment

Signed-off-by: Curtis Mason <[email protected]>

* structured content mode

Signed-off-by: Curtis Mason <[email protected]>

Co-authored-by: Dustin Ingram <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants