Thanks to visit codestin.com
Credit goes to github.com

Skip to content

from_http bug None and non dict data bug fixes #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2020

Conversation

cumason123
Copy link
Contributor

Fixes #115, #116

Changes

Added tests for known bugs
Changed exception handling for some specific inputs in from_http

One line description for the changelog

from_http bug None and non dict data bug fixes

  • [*] Tests pass
  • [*] Appropriate changes to README are included in PR

Curtis Mason added 2 commits August 19, 2020 10:15
Signed-off-by: Curtis Mason <[email protected]>
Signed-off-by: Curtis Mason <[email protected]>
@cumason123 cumason123 requested review from grayside and grant August 19, 2020 18:59
Signed-off-by: Curtis Mason <[email protected]>
@cumason123 cumason123 merged commit 06b07d0 into cloudevents:v1.2.0-dev Aug 19, 2020
cumason123 added a commit that referenced this pull request Aug 19, 2020
* from_http bug None and non dict data bug fixes (#119)

* resolving from_http bugs

Signed-off-by: Curtis Mason <[email protected]>

* resolved from_http bugs

Signed-off-by: Curtis Mason <[email protected]>

* nit fix

Signed-off-by: Curtis Mason <[email protected]>

* Exceptions general class (#120)

* More edgecase testing

Signed-off-by: Curtis Mason <[email protected]>

* Tested empty object edge cases

Signed-off-by: Curtis Mason <[email protected]>

* test-coverage

Signed-off-by: Curtis Mason <[email protected]>

* Changelog update (#121)

Signed-off-by: Curtis Mason <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants