Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit a4c4c5b

Browse files
authored
Bump base VSCode version for Quick Edit & Playground to 1.102.1 (#10047)
1 parent 9de2825 commit a4c4c5b

31 files changed

+5219
-1892
lines changed

.changeset/stale-eagles-yell.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@cloudflare/quick-edit": minor
3+
---
4+
5+
Bump base VSCode version for Quick Edit & Playground to 1.102.1

.github/workflows/deploy-pages-previews.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,8 @@ jobs:
3333
if: github.repository_owner == 'cloudflare' && github.head_ref != 'main' && (contains(github.event.*.labels.*.name, 'preview:chrome-devtools-patches') || contains(github.event.*.labels.*.name, 'preview:quick-edit') || contains(github.event.*.labels.*.name, 'preview:workers-playground'))
3434
timeout-minutes: 60
3535
concurrency:
36-
group: ${{ github.workflow }}-${{ github.ref }}
37-
cancel-in-progress: true
38-
runs-on: ubuntu-22.04
36+
group: ${{ github.workflow }}-${{ github.ref }}-app-previews
37+
runs-on: macos-latest-large
3938
steps:
4039
- name: Checkout Repo
4140
uses: actions/checkout@v4
@@ -44,6 +43,8 @@ jobs:
4443

4544
- name: Install Dependencies
4645
uses: ./.github/actions/install-dependencies
46+
with:
47+
node-version: 22
4748

4849
- name: Build tools and libraries
4950
run: pnpm run build
@@ -64,11 +65,11 @@ jobs:
6465

6566
- name: Build and Deploy Quick Edit preview
6667
if: contains(github.event.*.labels.*.name, 'preview:quick-edit')
67-
# Quick Edit requires yarn and VS Code build deps, so needs fairly specific logic
68-
run: pnpm --filter quick-edit run deploy
68+
run: pnpm --filter quick-edit run preview
6969
env:
7070
DEBIAN_FRONTEND: noninteractive
7171
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
72+
NODE_OPTIONS: "--max_old_space_size=30000"
7273

7374
- name: Deploy Workers Playground preview
7475
if: contains(github.event.*.labels.*.name, 'preview:workers-playground')

packages/quick-edit-extension/src/cfs.ts

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -194,16 +194,20 @@ declare module "*.bin" {
194194
}
195195
}
196196
}
197-
await this.writeFile(Uri.parse(`${this.rootFolder}/${path}`), contents, {
198-
create: true,
199-
overwrite: true,
200-
suppressChannelUpdate: true,
201-
readOnly: files.readOnly,
202-
});
197+
await this.writeFile(
198+
Uri.parse(`cfs:/${this.rootFolder}/${path}`),
199+
contents,
200+
{
201+
create: true,
202+
overwrite: true,
203+
suppressChannelUpdate: true,
204+
readOnly: files.readOnly,
205+
}
206+
);
203207
}
204208
if (this.readRoot !== null) {
205209
await this.readRoot(
206-
await this.readDirectory(Uri.parse(`${this.rootFolder}/`))
210+
await this.readDirectory(Uri.parse(`cfs:/${this.rootFolder}/`))
207211
);
208212
}
209213
}

0 commit comments

Comments
 (0)