Add support for variables in text style

YomesInc · web-flow · commit bb20a474dfe6 · 2021-08-06T15:39:23.000+03:00
diff --git a/src/Transformation/Layer/TextSource.php b/src/Transformation/Layer/TextSource.php
@@ -99,7 +99,7 @@ public function text($text)
     /**
      * Sets the text style.
      *
-     * @param array|TextStyle $style The text style.
+     * @param string|array|TextStyle $style The text style.
      *
      * @return $this
      */
diff --git a/tests/Unit/Transformation/Image/TextStyleTest.php b/tests/Unit/Transformation/Image/TextStyleTest.php
@@ -10,19 +10,22 @@
 
 namespace Cloudinary\Test\Unit\Transformation\Image;
 
+use Cloudinary\Asset\Image;
+use Cloudinary\Test\Unit\Asset\AssetTestCase;
 use Cloudinary\Transformation\Argument\Text\FontAntialias;
 use Cloudinary\Transformation\Argument\Text\FontFamily;
 use Cloudinary\Transformation\Argument\Text\FontWeight;
-use Cloudinary\Transformation\Argument\Text\Stroke;
 use Cloudinary\Transformation\Argument\Text\TextAlignment;
 use Cloudinary\Transformation\Argument\Text\TextDecoration;
+use Cloudinary\Transformation\Expression\Expression;
+use Cloudinary\Transformation\ImageSource;
 use Cloudinary\Transformation\TextStyle;
-use PHPUnit\Framework\TestCase;
+use Cloudinary\Transformation\Transformation;
 
 /**
  * Class TextStyleTest
  */
-final class TextStyleTest extends TestCase
+final class TextStyleTest extends AssetTestCase
 {
     public function testTextStyle()
     {
@@ -42,4 +45,35 @@ public function testTextStyle()
                 ->stroke()
         );
     }
+
+    public function testTextLayerStyleIdentifierVariables()
+    {
+        $image = new Image(self::IMAGE_NAME);
+        $image->addTransformation(
+            (new Transformation())
+                ->addVariable('$style', '!Arial_12!')
+                ->overlay(
+                    ImageSource::text('hello-world')->textStyle('$style')
+                )
+        );
+
+        self::assertImageUrl(
+            '$style_!Arial_12!/l_text:$style:hello-world/fl_layer_apply/' . self::IMAGE_NAME,
+            $image->toUrl()
+        );
+
+        $image = new Image(self::IMAGE_NAME);
+        $image->addTransformation(
+            (new Transformation())
+                ->addVariable('$style', '!Arial_12!')
+                ->overlay(
+                    ImageSource::text('hello-world')->textStyle(new Expression('$style'))
+                )
+        );
+
+        self::assertImageUrl(
+            '$style_!Arial_12!/l_text:$style:hello-world/fl_layer_apply/' . self::IMAGE_NAME,
+            $image->toUrl()
+        );
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ public function text($text)`
`99`	`99`	`/**`
`100`	`100`	`* Sets the text style.`
`101`	`101`	`*`
`102`		`- * @param array\|TextStyle $style The text style.`
	`102`	`+ * @param string\|array\|TextStyle $style The text style.`
`103`	`103`	`*`
`104`	`104`	`* @return $this`
`105`	`105`	`*/`