test: fix indentation

atdcloud · atdcloud · commit eb41ab02fbf9 · 2023-09-19T15:33:20.000+02:00
diff --git a/__TESTS__/unit/url/url.test.ts b/__TESTS__/unit/url/url.test.ts
@@ -103,7 +103,7 @@ describe('Tests for URL configuration', () => {
 
     //just added for playground
   it('Should include query params', function () {
-    const image = createNewImage('sample', {cloudName: 'demo'}, {queryParams: '_i=abcde&_t=false'}});
+    const image = createNewImage('sample', {cloudName: 'demo'}, {queryParams: '_i=abcde&_z=1234&_t=false'});
     const url = image.toURL();
     expect(url).toEqual(`https://res.cloudinary.com/demo/image/upload/sample?_i=abcde&_z=1234&_t=false`);
   });
diff --git a/src/assets/CloudinaryFile.ts b/src/assets/CloudinaryFile.ts
@@ -288,13 +288,14 @@ class CloudinaryFile {
       // 2. If we got an object we have to check if URLSearchParams is available, and only then use it
       //    Beause we want to throw a meaningful Error in case it's not - we can wrap the below code in a try catch clause 
       // 3. If it already was a string then we can skip the parsing but still we need to assign it to `queryParamsString`
-        //
 
-    const shouldAddAnalytics = this.urlConfig.analytics !== false && !(publicID.includes('?'));    
+      const shouldAddAnalytics = this.urlConfig.analytics !== false && !(publicID.includes('?'));    
 
-    if (typeof(this.urlConfig.queryParams) === 'object'){ //#1
+      let queryParamsString = '';
 
-        try { //#2
+      if (typeof(this.urlConfig.queryParams) === 'object'){ //#1
+
+        try { 
           const queryParams = new URLSearchParams(this.urlConfig.queryParams as Record<string, string>);
           // urlConfig.analytics is true by default, has to be explicitly set to false to overwrite
           // Don't add analytics when publicId includes a '?' to not risk changing existing query params
@@ -303,31 +304,33 @@ class CloudinaryFile {
             queryParams.set("_a", getSDKAnalyticsSignature(trackedAnalytics));
           }
          
-          const queryParamsString = queryParams.toString();
+          queryParamsString = queryParams.toString();
 
-        } catch(){
-            //TODO: improve error message, consult with docs team.
-            throw "Error: URLSearchParams is not available."; //#2
+        } catch(err) {
+          //TODO: improve error message, consult with docs team.
+          console.error("Error: URLSearchParams is not available");
+          //throw "Error: URLSearchParams is not available."; //#2
         }
-    } 
+      } 
     
-    //if (typeof(this.urlConfig.queryParams)  === 'string'){ //#3
-    else{ //#3
-       //assign to queryParamsString  
-        let queryParamsString = this.urlConfig.queryParams || '';
+      //if (typeof(this.urlConfig.queryParams)  === 'string'){ //#3
+      else{ //#3
+        //assign to queryParamsString  
+        queryParamsString = this.urlConfig.queryParams || '';
         
         if (shouldAddAnalytics) {
-            queryParams.set("_a", getSDKAnalyticsSignature(trackedAnalytics));
-            queryParamsString += (queryParamsString.length > 0 ? "&" :"") + "_a=" + getSDKAnalyticsSignature(trackedAnalytics);
+          //  queryParams.set("_a", getSDKAnalyticsSignature(trackedAnalytics));
+          queryParamsString += (queryParamsString.length > 0 ? "&" :"") + "_a=" + getSDKAnalyticsSignature(trackedAnalytics);
         }
         
-    }
 
-      if (queryParamsString) {
-        return `${safeURL}?${queryParamsString}`;
-      } else {
-        return safeURL;
+        if (queryParamsString) {
+          return `${safeURL}?${queryParamsString}`;
+        } else {
+          return safeURL;
+        }
       }
+
     }
   }
 }
