[probes.external] Fix serverutils.

manugarg · manugarg · commit f9cea3ca558f · 2024-05-21T09:58:24.000-07:00
We should not be writing to buffered stdout and stderr. This change was introduced recently in v0.13.4: github.com//pull/695
diff --git a/probes/external/serverutils/serverutils.go b/probes/external/serverutils/serverutils.go
@@ -169,10 +169,10 @@ func serve(ctx context.Context, probeFunc func(*serverpb.ProbeRequest, *serverpb
 //			}
 //		})
 func ServeContext(probeFunc func(*serverpb.ProbeRequest, *serverpb.ProbeReply)) {
-	serve(context.Background(), probeFunc, bufio.NewReader(os.Stdin), bufio.NewWriter(os.Stdout), bufio.NewWriter(os.Stderr))
+	serve(context.Background(), probeFunc, bufio.NewReader(os.Stdin), os.Stdout, os.Stderr)
 }
 
 // Serve is similar to ServeContext but uses the background context.
 func Serve(probeFunc func(*serverpb.ProbeRequest, *serverpb.ProbeReply)) {
-	serve(context.Background(), probeFunc, bufio.NewReader(os.Stdin), bufio.NewWriter(os.Stdout), bufio.NewWriter(os.Stderr))
+	serve(context.Background(), probeFunc, bufio.NewReader(os.Stdin), os.Stdout, os.Stderr)
 }

Original file line number	Diff line number	Diff line change
`@@ -169,10 +169,10 @@ func serve(ctx context.Context, probeFunc func(serverpb.ProbeRequest, serverpb`
`169`	`169`	`// }`
`170`	`170`	`// })`
`171`	`171`	`func ServeContext(probeFunc func(serverpb.ProbeRequest, serverpb.ProbeReply)) {`
`172`		`- serve(context.Background(), probeFunc, bufio.NewReader(os.Stdin), bufio.NewWriter(os.Stdout), bufio.NewWriter(os.Stderr))`
	`172`	`+ serve(context.Background(), probeFunc, bufio.NewReader(os.Stdin), os.Stdout, os.Stderr)`
`173`	`173`	`}`
`174`	`174`
`175`	`175`	`// Serve is similar to ServeContext but uses the background context.`
`176`	`176`	`func Serve(probeFunc func(serverpb.ProbeRequest, serverpb.ProbeReply)) {`
`177`		`- serve(context.Background(), probeFunc, bufio.NewReader(os.Stdin), bufio.NewWriter(os.Stdout), bufio.NewWriter(os.Stderr))`
	`177`	`+ serve(context.Background(), probeFunc, bufio.NewReader(os.Stdin), os.Stdout, os.Stderr)`
`178`	`178`	`}`