Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

This isn't a full-fledged bug.

Currently, SNS Topics return the following attributes in unknown_fields. The question is do we want to have the following fields as their own properties?

While TracingConfig is documented well in AWS API Documentation, the message delivery status fields (including %FailureFeedbackRoleArn such as HttpFailureFeedbackRoleArn) are not obvious via API and CLI Documentation. It's instead somewhat inferred from the SNS Developer Guide. These attributes have different names depending on the endpoint which include options such as (Http, Firehose, Lambda, Application, SQS) . There are a total of 15 attributes, and given that only 1 endpoint for logging can be configured - only 3 of them could have information. Which would mean there would be at least 12 empty fields per SNS Topic if we decide to implement all the fields.

There are a couple different options:

• We keep the attributes as in within unknown_fields (Do nothing).
• We can move out TracingConfig to a standalone field now since it's documented and keep the others in .
• We can move out TracingConfig and the other fields including %FailureFeedbackRoleArn, %SuccessFeedbackRoleArn, %SuccessFeedbackSampleRate.

TracingConfig, %FailureFeedbackRoleArn, %SuccessFeedbackRoleArn and more. This gets interesting as:

• TracingConfig is only supported on standard topics.
• %FailureFeedbackRoleArn, %SuccessFeedbackRoleArn, %SuccessFeedbackSampleRate` are present for when message delivery status logging is configured: https://docs.aws.amazon.com/sns/latest/dg/sns-topic-attributes.html#topic-attributes-sdksa

Full list of fields:

• HTTPSuccessFeedbackRoleArn
• HTTPSuccessFeedbackSampleRate
• HTTPFailureFeedbackRoleArn
• FirehoseSuccessFeedbackRoleArn
• FirehoseSuccessFeedbackSampleRate
• FirehoseFailureFeedbackRoleArn
• LambdaSuccessFeedbackRoleArn
• LambdaSuccessFeedbackSampleRate
• LambdaFailureFeedbackRoleArn
• ApplicationSuccessFeedbackRoleArn
• ApplicationSuccessFeedbackSampleRate
• ApplicationFailureFeedbackRoleArn
• SQSSuccessFeedbackRoleArn
• SQSSuccessFeedbackSampleRate
• SQSFailureFeedbackRoleArn

Expected Behavior

Do these nested properties get their own field and moved out of unknown_fields?

CloudQuery (redacted) config

tables: aws_sns_topics

Steps To Reproduce

{
"TracingConfig": "PassThrough",
"HTTPFailureFeedbackRoleArn": "arn:aws:iam::123412341234:role/Role",
"HTTPSuccessFeedbackRoleArn": "arn:aws:iam::123412341234:role/Role",
"HTTPSuccessFeedbackSampleRate": "100"
}

CloudQuery (redacted) logs

NA

CloudQuery version

NA

Additional Context

No response

Pull request (optional)

• I can submit a pull request