fix(grbl): address a regression in PR #889 related to the grbl-Mega connection handling (#893)

cheton · web-flow · commit 2553790c5af9 · 2024-10-31T16:39:17.000+08:00
* fix(grbl): address a regression in PR #889 related to the `grbl-Mega` connection handling * chore: update default settings
diff --git a/examples/.cncrc b/examples/.cncrc
@@ -18,7 +18,12 @@
   "controller": "",
   "state": {
     "allowAnonymousUsageDataCollection": false,
-    "checkForUpdates": true
+    "checkForUpdates": true,
+    "controller": {
+      "exception": {
+        "ignoreErrors": false
+      }
+    }
   },
   "commands": [
     {
diff --git a/src/server/controllers/Grbl/GrblController.js b/src/server/controllers/Grbl/GrblController.js
@@ -617,7 +617,13 @@ class GrblController {
         if (this.isOpen()) {
           this.connection.write('?');
         }
-      }, 2000, { trailing: true });
+      }, 1000, {
+        // For grbl-Mega, it is essential to allow a specific delay before querying the status report to avoid blocking the connection.
+        // Therefore, the `leading` option must be set to false.
+        // @see https://github.com/cncjs/cncjs/issues/889
+        leading: false,
+        trailing: true,
+      });
 
       const queryStatusReport = () => {
         // Check the ready flag
diff --git a/src/server/services/configstore/index.js b/src/server/services/configstore/index.js
@@ -7,6 +7,7 @@ import logger from '../../lib/logger';
 const log = logger('service:configstore');
 
 const defaultState = { // default state
+  allowAnonymousUsageDataCollection: false,
   checkForUpdates: true,
   controller: {
     exception: {
