From 07839ab7aba3484e6f75dbe5da45685b96580e8b Mon Sep 17 00:00:00 2001 From: Vercel Release Bot <88769842+vercel-release-bot@users.noreply.github.com> Date: Fri, 16 May 2025 11:00:37 +0200 Subject: [PATCH 1/4] Update Turbopack development test manifest (#79278) --- test/turbopack-dev-tests-manifest.json | 33 ++++++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/test/turbopack-dev-tests-manifest.json b/test/turbopack-dev-tests-manifest.json index aa7014a6ee222..c2c37dbe5636c 100644 --- a/test/turbopack-dev-tests-manifest.json +++ b/test/turbopack-dev-tests-manifest.json @@ -1930,9 +1930,10 @@ "Error recovery app render error not shown right after syntax error", "Error recovery app server component can recover from a component error", "Error recovery app server component can recover from syntax error", - "Error recovery app stuck error" + "Error recovery app stuck error", + "Error recovery app syntax > runtime error" ], - "failed": ["Error recovery app syntax > runtime error"], + "failed": [], "pending": [], "flakey": [], "runtimeError": false @@ -2722,6 +2723,16 @@ "flakey": [], "runtimeError": false }, + "test/development/app-dir/use-cache-errors/use-cache-errors.test.ts": { + "passed": [ + "use-cache-errors should not show a false-positive compiler error about a misplaced \"use cache\" directive", + "use-cache-errors should show a runtime error when calling the incorrectly used cache function" + ], + "failed": [], + "pending": [], + "flakey": [], + "runtimeError": false + }, "test/development/app-hmr/hmr.test.ts": { "passed": [ "app-dir-hmr filesystem changes can navigate cleanly to a page that requires a change in the Webpack runtime", @@ -3896,6 +3907,17 @@ "flakey": [], "runtimeError": false }, + "test/development/typescript-plugin/client-boundary/client-boundary.test.ts": { + "passed": [ + "typescript-plugin - client-boundary should have diagnostics for non-serializable props", + "typescript-plugin - client-boundary should not have diagnostics for non-serializable action props", + "typescript-plugin - client-boundary should not have diagnostics for serializable props" + ], + "failed": [], + "pending": [], + "flakey": [], + "runtimeError": false + }, "test/development/typescript-plugin/index.test.ts": { "passed": ["typescript-plugin should be able to get the language service"], "failed": [], @@ -7014,6 +7036,13 @@ "flakey": [], "runtimeError": false }, + "test/e2e/app-dir/monaco-editor/monaco-editor.test.ts": { + "passed": ["monaco-editor should load monaco-editor"], + "failed": [], + "pending": [], + "flakey": [], + "runtimeError": false + }, "test/e2e/app-dir/navigation-layout-suspense/navigation-layout-suspense.test.ts": { "passed": [ "app dir - navigation with Suspense in nested layout resolves data after client navigation to a nested layout with Suspense" From ff7e8e16277ae3cfbeb3f459086b8b8687992890 Mon Sep 17 00:00:00 2001 From: Vercel Release Bot <88769842+vercel-release-bot@users.noreply.github.com> Date: Fri, 16 May 2025 14:03:39 +0200 Subject: [PATCH 2/4] Update Turbopack production test manifest (#79277) --- test/turbopack-build-tests-manifest.json | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/test/turbopack-build-tests-manifest.json b/test/turbopack-build-tests-manifest.json index ad569dd6a11c9..ed5f19e779ec0 100644 --- a/test/turbopack-build-tests-manifest.json +++ b/test/turbopack-build-tests-manifest.json @@ -3292,6 +3292,13 @@ "flakey": [], "runtimeError": false }, + "test/e2e/app-dir/monaco-editor/monaco-editor.test.ts": { + "passed": ["monaco-editor should load monaco-editor"], + "failed": [], + "pending": [], + "flakey": [], + "runtimeError": false + }, "test/e2e/app-dir/navigation-layout-suspense/navigation-layout-suspense.test.ts": { "passed": [ "app dir - navigation with Suspense in nested layout resolves data after client navigation to a nested layout with Suspense" @@ -4185,12 +4192,11 @@ "ppr-full Dynamic RSC Response for /on-demand/c should have correct headers", "ppr-full Dynamic RSC Response for /static should have correct headers", "ppr-full Dynamic RSC Response for /static should not contain dynamic content", - "ppr-full HTML Fallback Dynamic Shell should render the dynamic shell as static if the page is static", + "ppr-full HTML Fallback Dynamic Shell should render the fallback shell even if the page is static", + "ppr-full HTML Fallback Dynamic Shell should render the fallback shell every time", "ppr-full HTML Fallback Dynamic Shell should render the fallback shell on first visit", - "ppr-full HTML Fallback Dynamic Shell should render the route shell on the second visit", "ppr-full HTML Fallback Dynamic Shell will allow dynamic fallback shells even when static is enforced", - "ppr-full HTML Fallback Dynamic Shell will only revalidate the page", - "ppr-full HTML Fallback Dynamic Shell will revalidate the page and fallback shell", + "ppr-full HTML Fallback Dynamic Shell will not revalidate the fallback shell", "ppr-full HTML Fallback for /fallback/nested/params/slug-01/slug-02 should render the fallback HTML immediately", "ppr-full HTML Fallback for /fallback/nested/use-params/slug-01/slug-02 should render the fallback HTML immediately", "ppr-full HTML Fallback for /fallback/nested/use-pathname/slug-01/slug-02 should render the fallback HTML immediately", From 1bc1326d1e7c1b67ce03cfd7774b45c20ec74aa8 Mon Sep 17 00:00:00 2001 From: Vercel Release Bot <88769842+vercel-release-bot@users.noreply.github.com> Date: Fri, 16 May 2025 14:05:26 +0200 Subject: [PATCH 3/4] Update Rspack production test manifest (#79275) --- test/rspack-build-tests-manifest.json | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/test/rspack-build-tests-manifest.json b/test/rspack-build-tests-manifest.json index 63c696ee1c650..54b718e75990a 100644 --- a/test/rspack-build-tests-manifest.json +++ b/test/rspack-build-tests-manifest.json @@ -3406,6 +3406,13 @@ "flakey": [], "runtimeError": false }, + "test/e2e/app-dir/monaco-editor/monaco-editor.test.ts": { + "passed": ["monaco-editor should load monaco-editor"], + "failed": [], + "pending": [], + "flakey": [], + "runtimeError": false + }, "test/e2e/app-dir/navigation-layout-suspense/navigation-layout-suspense.test.ts": { "passed": [ "app dir - navigation with Suspense in nested layout resolves data after client navigation to a nested layout with Suspense" @@ -4301,12 +4308,11 @@ "ppr-full Dynamic RSC Response for /on-demand/c should have correct headers", "ppr-full Dynamic RSC Response for /static should have correct headers", "ppr-full Dynamic RSC Response for /static should not contain dynamic content", - "ppr-full HTML Fallback Dynamic Shell should render the dynamic shell as static if the page is static", + "ppr-full HTML Fallback Dynamic Shell should render the fallback shell even if the page is static", + "ppr-full HTML Fallback Dynamic Shell should render the fallback shell every time", "ppr-full HTML Fallback Dynamic Shell should render the fallback shell on first visit", - "ppr-full HTML Fallback Dynamic Shell should render the route shell on the second visit", "ppr-full HTML Fallback Dynamic Shell will allow dynamic fallback shells even when static is enforced", - "ppr-full HTML Fallback Dynamic Shell will only revalidate the page", - "ppr-full HTML Fallback Dynamic Shell will revalidate the page and fallback shell", + "ppr-full HTML Fallback Dynamic Shell will not revalidate the fallback shell", "ppr-full HTML Fallback for /fallback/nested/params/slug-01/slug-02 should render the fallback HTML immediately", "ppr-full HTML Fallback for /fallback/nested/use-params/slug-01/slug-02 should render the fallback HTML immediately", "ppr-full HTML Fallback for /fallback/nested/use-pathname/slug-01/slug-02 should render the fallback HTML immediately", @@ -19454,11 +19460,10 @@ }, "test/production/pnpm-support/index.test.ts": { "passed": [ - "pnpm support should build with dependencies installed via pnpm" - ], - "failed": [ + "pnpm support should build with dependencies installed via pnpm", "pnpm support should execute client-side JS on each page in output: \"standalone\"" ], + "failed": [], "pending": [], "flakey": [], "runtimeError": false From 13af7b57f641fb3a80df85548ca288be91d99b63 Mon Sep 17 00:00:00 2001 From: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com> Date: Fri, 16 May 2025 14:58:29 +0200 Subject: [PATCH 4/4] Turbopack: remove dead code (#79280) - `IncludeIdentModule` is unused (and incompatible with the ModuleGraph anyway) - Cleanup some `todo!()`s --- .../src/source/static_assets.rs | 5 +-- .../src/async_chunk/module.rs | 2 +- .../src/manifest/chunk_asset.rs | 2 +- .../src/references/external_module.rs | 32 ------------------- .../src/worker_chunk/module.rs | 2 +- 5 files changed, 6 insertions(+), 37 deletions(-) diff --git a/turbopack/crates/turbopack-dev-server/src/source/static_assets.rs b/turbopack/crates/turbopack-dev-server/src/source/static_assets.rs index f6b4dc65eae6e..e0cc8578a0c09 100644 --- a/turbopack/crates/turbopack-dev-server/src/source/static_assets.rs +++ b/turbopack/crates/turbopack-dev-server/src/source/static_assets.rs @@ -140,8 +140,9 @@ impl Introspectable for StaticAssetsContentSource { .to_resolved() .await?, ), - DirectoryEntry::Other(_) => todo!("what's DirectoryContent::Other?"), - DirectoryEntry::Error => todo!(), + DirectoryEntry::Other(_) | DirectoryEntry::Error => { + todo!("unsupported DirectoryContent variant: {entry:?}") + } }; Ok((ResolvedVc::cell(name.clone()), child)) } diff --git a/turbopack/crates/turbopack-ecmascript/src/async_chunk/module.rs b/turbopack/crates/turbopack-ecmascript/src/async_chunk/module.rs index f2a42bd8b45ae..0b27482d0ad7a 100644 --- a/turbopack/crates/turbopack-ecmascript/src/async_chunk/module.rs +++ b/turbopack/crates/turbopack-ecmascript/src/async_chunk/module.rs @@ -76,7 +76,7 @@ impl Module for AsyncLoaderModule { impl Asset for AsyncLoaderModule { #[turbo_tasks::function] fn content(&self) -> Vc { - todo!() + panic!("content() should not be called"); } } diff --git a/turbopack/crates/turbopack-ecmascript/src/manifest/chunk_asset.rs b/turbopack/crates/turbopack-ecmascript/src/manifest/chunk_asset.rs index 914986d33edc6..30e1b12afc59e 100644 --- a/turbopack/crates/turbopack-ecmascript/src/manifest/chunk_asset.rs +++ b/turbopack/crates/turbopack-ecmascript/src/manifest/chunk_asset.rs @@ -152,7 +152,7 @@ impl Module for ManifestAsyncModule { impl Asset for ManifestAsyncModule { #[turbo_tasks::function] fn content(&self) -> Vc { - todo!() + panic!("content() should not be called"); } } diff --git a/turbopack/crates/turbopack-ecmascript/src/references/external_module.rs b/turbopack/crates/turbopack-ecmascript/src/references/external_module.rs index 15633a241950c..b5430179c1a26 100644 --- a/turbopack/crates/turbopack-ecmascript/src/references/external_module.rs +++ b/turbopack/crates/turbopack-ecmascript/src/references/external_module.rs @@ -268,35 +268,3 @@ impl EcmascriptChunkItem for CachedExternalModuleChunkItem { ) } } - -/// A module that only has an ident and no content nor references. -/// -/// It is used to include a module's ident in the module graph before the module -/// itself is resolved, as is the case with NextServerComponentModule's -/// "client modules" and "ssr modules". -#[turbo_tasks::value] -pub struct IncludeIdentModule { - ident: ResolvedVc, -} - -#[turbo_tasks::value_impl] -impl IncludeIdentModule { - #[turbo_tasks::function] - pub fn new(ident: ResolvedVc) -> Vc { - Self { ident }.cell() - } -} - -impl Asset for IncludeIdentModule { - fn content(self: Vc) -> Vc { - todo!("IncludeIdentModule doesn't implement content()") - } -} - -#[turbo_tasks::value_impl] -impl Module for IncludeIdentModule { - #[turbo_tasks::function] - fn ident(&self) -> Vc { - *self.ident - } -} diff --git a/turbopack/crates/turbopack-ecmascript/src/worker_chunk/module.rs b/turbopack/crates/turbopack-ecmascript/src/worker_chunk/module.rs index 238291b6ef883..853e398ff10f7 100644 --- a/turbopack/crates/turbopack-ecmascript/src/worker_chunk/module.rs +++ b/turbopack/crates/turbopack-ecmascript/src/worker_chunk/module.rs @@ -62,7 +62,7 @@ impl Module for WorkerLoaderModule { impl Asset for WorkerLoaderModule { #[turbo_tasks::function] fn content(&self) -> Vc { - todo!() + panic!("content() should not be called"); } }