[DevTools] Only check if we previously removed IO if its removal failed (facebook#34506)

eps1lon · web-flow · commit a51f925217e7 · 2025-09-16T19:55:03.000+02:00
diff --git a/packages/react-devtools-shared/src/backend/fiber/renderer.js b/packages/react-devtools-shared/src/backend/fiber/renderer.js
@@ -2902,29 +2902,32 @@ export function attach(
           // Let's remove it from the parent SuspenseNode.
           const ioInfo = asyncInfo.awaited;
           const suspendedBySet = parentSuspenseNode.suspendedBy.get(ioInfo);
-          // A boundary can await the same IO multiple times.
-          // We still want to error if we're trying to remove IO that isn't present on
-          // this boundary so we need to check if we've already removed it.
-          // We're assuming previousSuspendedBy is a small array so this should be faster
-          // than allocating and maintaining a Set.
-          let alreadyRemovedIO = false;
-          for (let j = 0; j < i; j++) {
-            const removedIOInfo = previousSuspendedBy[j].awaited;
-            if (removedIOInfo === ioInfo) {
-              alreadyRemovedIO = true;
-              break;
-            }
-          }
+
           if (
             suspendedBySet === undefined ||
-            (!alreadyRemovedIO && !suspendedBySet.delete(instance))
+            !suspendedBySet.delete(instance)
           ) {
-            throw new Error(
-              'We are cleaning up async info that was not on the parent Suspense boundary. ' +
-                'This is a bug in React.',
-            );
+            // A boundary can await the same IO multiple times.
+            // We still want to error if we're trying to remove IO that isn't present on
+            // this boundary so we need to check if we've already removed it.
+            // We're assuming previousSuspendedBy is a small array so this should be faster
+            // than allocating and maintaining a Set.
+            let alreadyRemovedIO = false;
+            for (let j = 0; j < i; j++) {
+              const removedIOInfo = previousSuspendedBy[j].awaited;
+              if (removedIOInfo === ioInfo) {
+                alreadyRemovedIO = true;
+                break;
+              }
+            }
+            if (!alreadyRemovedIO) {
+              throw new Error(
+                'We are cleaning up async info that was not on the parent Suspense boundary. ' +
+                  'This is a bug in React.',
+              );
+            }
           }
-          if (suspendedBySet.size === 0) {
+          if (suspendedBySet !== undefined && suspendedBySet.size === 0) {
             parentSuspenseNode.suspendedBy.delete(asyncInfo.awaited);
           }
           if (
