From 0672bcc7543bf9498202f88d2beb7a49bd5146db Mon Sep 17 00:00:00 2001 From: Nathan Bierema Date: Sun, 22 Jun 2025 13:13:50 -0400 Subject: [PATCH 1/2] Examples: Clean up. (#31303) --- examples/webgpu_compute_water.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/webgpu_compute_water.html b/examples/webgpu_compute_water.html index b90e92edc0dcb0..6a5b4a8ebf7935 100644 --- a/examples/webgpu_compute_water.html +++ b/examples/webgpu_compute_water.html @@ -277,8 +277,8 @@ borderGeom.rotateY( Math.PI * 0.25 ); poolBorder = new THREE.Mesh( borderGeom, new THREE.MeshStandardMaterial( { color: 0x908877, roughness: 0.2 } ) ); scene.add( poolBorder ); - borderGeom.receiveShadow = true; - borderGeom.castShadow = true; + poolBorder.receiveShadow = true; + poolBorder.castShadow = true; // THREE.Mesh just for mouse raycasting const geometryRay = new THREE.PlaneGeometry( BOUNDS, BOUNDS, 1, 1 ); From 1879d678bda341419cd3d2ecaffcbdcb5c0a5670 Mon Sep 17 00:00:00 2001 From: Michael Herzog Date: Sun, 22 Jun 2025 19:14:03 +0200 Subject: [PATCH 2/2] Quaternion: Update epsilon in `setFromUnitVectors()`. (#31302) * Quaternion: Update epsilon in `setFromUnitVectors()`. * Quaternion: Add comment. --- src/math/Quaternion.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/math/Quaternion.js b/src/math/Quaternion.js index 04766a421eb9f1..49cca909a8582c 100644 --- a/src/math/Quaternion.js +++ b/src/math/Quaternion.js @@ -482,7 +482,7 @@ class Quaternion { let r = vFrom.dot( vTo ) + 1; - if ( r < Number.EPSILON ) { + if ( r < 1e-8 ) { // the epsilon value has been discussed in #31286 // vFrom and vTo point in opposite directions