diff --git a/src/CSharp/CodeCracker/Design/CatchEmptyAnalyzer.cs b/src/CSharp/CodeCracker/Design/CatchEmptyAnalyzer.cs index 82e455d7f..16547aed4 100644 --- a/src/CSharp/CodeCracker/Design/CatchEmptyAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/CatchEmptyAnalyzer.cs @@ -18,7 +18,7 @@ public class CatchEmptyAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.CatchEmpty], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.CatchEmpty)); diff --git a/src/CSharp/CodeCracker/Design/EmptyCatchBlockAnalyzer.cs b/src/CSharp/CodeCracker/Design/EmptyCatchBlockAnalyzer.cs index f77e42f85..f63604a98 100644 --- a/src/CSharp/CodeCracker/Design/EmptyCatchBlockAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/EmptyCatchBlockAnalyzer.cs @@ -20,7 +20,7 @@ public class EmptyCatchBlockAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.EmptyCatchBlock], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.EmptyCatchBlock)); diff --git a/src/CSharp/CodeCracker/Design/MakeMethodStaticAnalyzer.cs b/src/CSharp/CodeCracker/Design/MakeMethodStaticAnalyzer.cs index a5fecd666..ca375e682 100644 --- a/src/CSharp/CodeCracker/Design/MakeMethodStaticAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/MakeMethodStaticAnalyzer.cs @@ -1,10 +1,11 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; using System.Linq; using System.Collections.Immutable; using System; +using CodeCracker; namespace CodeCracker.CSharp.Design { @@ -23,7 +24,7 @@ public class MakeMethodStaticAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.MakeMethodStatic], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.MakeMethodStatic)); diff --git a/src/CSharp/CodeCracker/Design/NameOfAnalyzer.cs b/src/CSharp/CodeCracker/Design/NameOfAnalyzer.cs index 1631dc9f9..b9e4bb409 100644 --- a/src/CSharp/CodeCracker/Design/NameOfAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/NameOfAnalyzer.cs @@ -1,4 +1,5 @@ -using CodeCracker.Properties; +using CodeCracker; +using CodeCracker.Properties; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class NameOfAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.NameOf], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NameOf)); @@ -30,7 +31,7 @@ public class NameOfAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.NameOf_External], isEnabledByDefault: false, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NameOf_External)); diff --git a/src/CSharp/CodeCracker/Design/StaticConstructorExceptionAnalyzer.cs b/src/CSharp/CodeCracker/Design/StaticConstructorExceptionAnalyzer.cs index c8a9f2f23..a8f9dc501 100644 --- a/src/CSharp/CodeCracker/Design/StaticConstructorExceptionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/StaticConstructorExceptionAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -21,7 +22,7 @@ public class StaticConstructorExceptionAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.StaticConstructorException], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StaticConstructorException)); diff --git a/src/CSharp/CodeCracker/Design/SwitchWithoutDefaultAnalyzer.cs b/src/CSharp/CodeCracker/Design/SwitchWithoutDefaultAnalyzer.cs index 82a31165c..d523cde47 100644 --- a/src/CSharp/CodeCracker/Design/SwitchWithoutDefaultAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/SwitchWithoutDefaultAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; using System; using System.Collections.Generic; @@ -8,7 +8,7 @@ using System.Collections.Immutable; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; - +using CodeCracker; namespace CodeCracker.CSharp.Design { @@ -23,7 +23,7 @@ public class SwitchWithoutDefaultAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.SwitchCaseWithoutDefault], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SwitchCaseWithoutDefault)); diff --git a/src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs b/src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs index 6a30e2533..221346b54 100644 --- a/src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -23,7 +24,7 @@ public class UseInvokeMethodToFireEventAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.UseInvokeMethodToFireEvent], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseInvokeMethodToFireEvent)); diff --git a/src/CSharp/CodeCracker/Maintainability/XmlDocumentationAnalyzer.cs b/src/CSharp/CodeCracker/Maintainability/XmlDocumentationAnalyzer.cs index 5f987fddb..6da91478a 100644 --- a/src/CSharp/CodeCracker/Maintainability/XmlDocumentationAnalyzer.cs +++ b/src/CSharp/CodeCracker/Maintainability/XmlDocumentationAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -6,6 +6,7 @@ using System.Collections.Immutable; using System.Linq; using CodeCracker.Properties; +using CodeCracker; namespace CodeCracker.CSharp.Maintainability { @@ -19,7 +20,7 @@ public sealed class XmlDocumentationAnalyzer : DiagnosticAnalyzer Title, Title, SupportedCategories.Maintainability, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.XmlDocumentation_MissingInCSharp], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.XmlDocumentation_MissingInCSharp)); @@ -28,7 +29,7 @@ public sealed class XmlDocumentationAnalyzer : DiagnosticAnalyzer Title, Title, SupportedCategories.Maintainability, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.XmlDocumentation_MissingInXml], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.XmlDocumentation_MissingInXml)); diff --git a/src/CSharp/CodeCracker/Performance/EmptyFinalizerAnalyzer.cs b/src/CSharp/CodeCracker/Performance/EmptyFinalizerAnalyzer.cs index cd5a4f333..d8c44348b 100644 --- a/src/CSharp/CodeCracker/Performance/EmptyFinalizerAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/EmptyFinalizerAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -22,7 +23,7 @@ public class EmptyFinalizerAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.EmptyFinalizer], true, customTags: WellKnownDiagnosticTags.Unnecessary, description: Description, diff --git a/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs b/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs index f49aba20a..9214b369b 100644 --- a/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -20,7 +21,7 @@ public class MakeLocalVariableConstWhenItIsPossibleAnalyzer : Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.MakeLocalVariableConstWhenItIsPossible], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.MakeLocalVariableConstWhenItIsPossible)); diff --git a/src/CSharp/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.cs b/src/CSharp/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.cs index 9ba262a53..3901b3d9b 100644 --- a/src/CSharp/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -41,7 +41,7 @@ public class RemoveWhereWhenItIsPossibleAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.RemoveWhereWhenItIsPossible], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveWhereWhenItIsPossible)); diff --git a/src/CSharp/CodeCracker/Performance/SealedAttributeAnalyzer.cs b/src/CSharp/CodeCracker/Performance/SealedAttributeAnalyzer.cs index dc4cf7553..e6a7c49f2 100644 --- a/src/CSharp/CodeCracker/Performance/SealedAttributeAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/SealedAttributeAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; using System; using System.Collections.Immutable; @@ -19,7 +19,7 @@ public class SealedAttributeAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.SealedAttribute], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SealedAttribute)); diff --git a/src/CSharp/CodeCracker/Performance/StringBuilderInLoopAnalyzer.cs b/src/CSharp/CodeCracker/Performance/StringBuilderInLoopAnalyzer.cs index 60960be01..d49aac119 100644 --- a/src/CSharp/CodeCracker/Performance/StringBuilderInLoopAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/StringBuilderInLoopAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class StringBuilderInLoopAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.StringBuilderInLoop], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringBuilderInLoop)); diff --git a/src/CSharp/CodeCracker/Performance/UseStaticRegexIsMatchAnalyzer.cs b/src/CSharp/CodeCracker/Performance/UseStaticRegexIsMatchAnalyzer.cs index 19c4e2374..a6c5093dd 100644 --- a/src/CSharp/CodeCracker/Performance/UseStaticRegexIsMatchAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/UseStaticRegexIsMatchAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -20,7 +20,7 @@ public class UseStaticRegexIsMatchAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.UseStaticRegexIsMatch], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseStaticRegexIsMatch)); diff --git a/src/CSharp/CodeCracker/Refactoring/AddBracesToSwitchSectionsAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/AddBracesToSwitchSectionsAnalyzer.cs index 6ef64c506..b02b40354 100644 --- a/src/CSharp/CodeCracker/Refactoring/AddBracesToSwitchSectionsAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/AddBracesToSwitchSectionsAnalyzer.cs @@ -1,4 +1,4 @@ -using System.Collections.Immutable; +using System.Collections.Immutable; using System.Linq; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; @@ -19,7 +19,7 @@ public class AddBracesToSwitchSectionsAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.AddBracesToSwitchSections], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AddBracesToSwitchSections)); diff --git a/src/CSharp/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.cs index eda3b461a..8666aab69 100644 --- a/src/CSharp/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -18,7 +18,7 @@ public class AllowMembersOrderingAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.AllowMembersOrdering], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AllowMembersOrdering)); diff --git a/src/CSharp/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.cs index 8e52451bb..d5aa74ff0 100644 --- a/src/CSharp/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.cs @@ -23,7 +23,7 @@ public class ChangeAnyToAllAnalyzer : DiagnosticAnalyzer TitleAny, MessageAny, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.ChangeAnyToAll], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ChangeAnyToAll)); internal static readonly DiagnosticDescriptor RuleAll = new DiagnosticDescriptor( @@ -31,7 +31,7 @@ public class ChangeAnyToAllAnalyzer : DiagnosticAnalyzer TitleAll, MessageAll, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.ChangeAllToAny], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ChangeAllToAny)); diff --git a/src/CSharp/CodeCracker/Refactoring/ComputeExpressionAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/ComputeExpressionAnalyzer.cs index 63224cd90..d205ebc06 100644 --- a/src/CSharp/CodeCracker/Refactoring/ComputeExpressionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/ComputeExpressionAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -20,7 +21,7 @@ public class ComputeExpressionAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.ComputeExpression], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ComputeExpression)); diff --git a/src/CSharp/CodeCracker/Refactoring/IntroduceFieldFromConstructorAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/IntroduceFieldFromConstructorAnalyzer.cs index 7b20fe932..ae3a50829 100644 --- a/src/CSharp/CodeCracker/Refactoring/IntroduceFieldFromConstructorAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/IntroduceFieldFromConstructorAnalyzer.cs @@ -1,4 +1,5 @@ -using CodeCracker.Properties; +using CodeCracker; +using CodeCracker.Properties; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -22,7 +23,7 @@ public class IntroduceFieldFromConstructorAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.IntroduceFieldFromConstructor], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.IntroduceFieldFromConstructor)); diff --git a/src/CSharp/CodeCracker/Refactoring/InvertForAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/InvertForAnalyzer.cs index 75dc49e56..f49fe423b 100644 --- a/src/CSharp/CodeCracker/Refactoring/InvertForAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/InvertForAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -18,7 +18,7 @@ public class InvertForAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.InvertFor], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.InvertFor)); diff --git a/src/CSharp/CodeCracker/Refactoring/MergeNestedIfAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/MergeNestedIfAnalyzer.cs index e4ffa333b..7f463d0a6 100644 --- a/src/CSharp/CodeCracker/Refactoring/MergeNestedIfAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/MergeNestedIfAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -18,7 +18,7 @@ public class MergeNestedIfAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.MergeNestedIf], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.MergeNestedIf)); diff --git a/src/CSharp/CodeCracker/Refactoring/NumericLiteralAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/NumericLiteralAnalyzer.cs index f60caa320..08456407b 100644 --- a/src/CSharp/CodeCracker/Refactoring/NumericLiteralAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/NumericLiteralAnalyzer.cs @@ -18,7 +18,7 @@ public class NumericLiteralAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.NumericLiteral], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NumericLiteral)); diff --git a/src/CSharp/CodeCracker/Refactoring/ParameterRefactoryAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/ParameterRefactoryAnalyzer.cs index f113c416e..256f56855 100644 --- a/src/CSharp/CodeCracker/Refactoring/ParameterRefactoryAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/ParameterRefactoryAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +20,7 @@ public class ParameterRefactoryAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.ParameterRefactory], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ParameterRefactory)); diff --git a/src/CSharp/CodeCracker/Refactoring/PropertyChangedEventArgsUnnecessaryAllocationAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/PropertyChangedEventArgsUnnecessaryAllocationAnalyzer.cs index a3f061c3e..65b15223e 100644 --- a/src/CSharp/CodeCracker/Refactoring/PropertyChangedEventArgsUnnecessaryAllocationAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/PropertyChangedEventArgsUnnecessaryAllocationAnalyzer.cs @@ -1,4 +1,5 @@ -using CodeCracker.Properties; +using CodeCracker; +using CodeCracker.Properties; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -33,7 +34,7 @@ public sealed class PropertyChangedEventArgsUnnecessaryAllocationAnalyzer : Diag Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.PropertyChangedEventArgsUnnecessaryAllocation], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.PropertyChangedEventArgsUnnecessaryAllocation)); diff --git a/src/CSharp/CodeCracker/Refactoring/ReplaceWithGetterOnlyAutoPropertyAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/ReplaceWithGetterOnlyAutoPropertyAnalyzer.cs index cc8b4ef13..09f536fad 100644 --- a/src/CSharp/CodeCracker/Refactoring/ReplaceWithGetterOnlyAutoPropertyAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/ReplaceWithGetterOnlyAutoPropertyAnalyzer.cs @@ -1,4 +1,4 @@ -using CodeCracker.Properties; +using CodeCracker.Properties; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -22,7 +22,7 @@ public class ReplaceWithGetterOnlyAutoPropertyAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.ReplaceWithGetterOnlyAutoProperty], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ReplaceWithGetterOnlyAutoProperty)); diff --git a/src/CSharp/CodeCracker/Refactoring/SplitIntoNestedIfAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/SplitIntoNestedIfAnalyzer.cs index e37d41246..2af7eda33 100644 --- a/src/CSharp/CodeCracker/Refactoring/SplitIntoNestedIfAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/SplitIntoNestedIfAnalyzer.cs @@ -18,7 +18,7 @@ public class SplitIntoNestedIfAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.SplitIntoNestedIf], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SplitIntoNestedIf)); diff --git a/src/CSharp/CodeCracker/Refactoring/StringRepresentationAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/StringRepresentationAnalyzer.cs index 3c7bbd8a3..3e356a34a 100644 --- a/src/CSharp/CodeCracker/Refactoring/StringRepresentationAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/StringRepresentationAnalyzer.cs @@ -16,7 +16,7 @@ public class StringRepresentationAnalyzer : DiagnosticAnalyzer "Regular string", "Change to regular string", SupportedCategories.Refactoring, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.StringRepresentation_RegularString], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringRepresentation_RegularString)); @@ -25,7 +25,7 @@ public class StringRepresentationAnalyzer : DiagnosticAnalyzer "Verbatim string", "Change to verbatim string", SupportedCategories.Refactoring, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.StringRepresentation_VerbatimString], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringRepresentation_VerbatimString)); diff --git a/src/CSharp/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.cs b/src/CSharp/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.cs index 4af4bbf13..2fc5fc8c3 100644 --- a/src/CSharp/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.cs +++ b/src/CSharp/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -18,7 +18,7 @@ public class UseConfigureAwaitFalseAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.UseConfigureAwaitFalse], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseConfigureAwaitFalse)); diff --git a/src/CSharp/CodeCracker/Style/AlwaysUseVarAnalyzer.cs b/src/CSharp/CodeCracker/Style/AlwaysUseVarAnalyzer.cs index 7e5c5aab2..d034922c7 100644 --- a/src/CSharp/CodeCracker/Style/AlwaysUseVarAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/AlwaysUseVarAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -21,7 +21,7 @@ public class AlwaysUseVarAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.AlwaysUseVar], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AlwaysUseVar)); @@ -31,7 +31,7 @@ public class AlwaysUseVarAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.AlwaysUseVarOnPrimitives], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AlwaysUseVarOnPrimitives)); diff --git a/src/CSharp/CodeCracker/Style/ConsoleWriteLineAnalyzer.cs b/src/CSharp/CodeCracker/Style/ConsoleWriteLineAnalyzer.cs index d9d34cf1c..15769bf57 100644 --- a/src/CSharp/CodeCracker/Style/ConsoleWriteLineAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ConsoleWriteLineAnalyzer.cs @@ -19,7 +19,7 @@ public class ConsoleWriteLineAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.ConsoleWriteLine], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ConsoleWriteLine)); diff --git a/src/CSharp/CodeCracker/Style/ConvertLambdaExpressionToMethodGroupAnalyzer.cs b/src/CSharp/CodeCracker/Style/ConvertLambdaExpressionToMethodGroupAnalyzer.cs index bb335f76d..dc3245751 100644 --- a/src/CSharp/CodeCracker/Style/ConvertLambdaExpressionToMethodGroupAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ConvertLambdaExpressionToMethodGroupAnalyzer.cs @@ -1,4 +1,4 @@ -using System.Collections.Immutable; +using System.Collections.Immutable; using System.Linq; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; @@ -20,7 +20,7 @@ public class ConvertLambdaExpressionToMethodGroupAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.ConvertLambdaExpressionToMethodGroup], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ConvertLambdaExpressionToMethodGroup)); diff --git a/src/CSharp/CodeCracker/Style/ConvertToExpressionBodiedMemberAnalyzer.cs b/src/CSharp/CodeCracker/Style/ConvertToExpressionBodiedMemberAnalyzer.cs index ede46efcd..31b933230 100644 --- a/src/CSharp/CodeCracker/Style/ConvertToExpressionBodiedMemberAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ConvertToExpressionBodiedMemberAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +19,7 @@ public class ConvertToExpressionBodiedMemberAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.ConvertToExpressionBodiedMember], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ConvertToExpressionBodiedMember)); diff --git a/src/CSharp/CodeCracker/Style/ConvertToSwitchAnalyzer.cs b/src/CSharp/CodeCracker/Style/ConvertToSwitchAnalyzer.cs index 4924daafe..73cad2fa4 100644 --- a/src/CSharp/CodeCracker/Style/ConvertToSwitchAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ConvertToSwitchAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -22,7 +22,7 @@ public class ConvertToSwitchAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.ConvertToSwitch], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ConvertToSwitch)); diff --git a/src/CSharp/CodeCracker/Style/EmptyObjectInitializerAnalyzer.cs b/src/CSharp/CodeCracker/Style/EmptyObjectInitializerAnalyzer.cs index 1ae23376f..f60a4b8bd 100644 --- a/src/CSharp/CodeCracker/Style/EmptyObjectInitializerAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/EmptyObjectInitializerAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +19,7 @@ public class EmptyObjectInitializerAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.EmptyObjectInitializer], isEnabledByDefault: true, customTags: WellKnownDiagnosticTags.Unnecessary, description: Description, diff --git a/src/CSharp/CodeCracker/Style/ExistenceOperatorAnalyzer.cs b/src/CSharp/CodeCracker/Style/ExistenceOperatorAnalyzer.cs index c22b39f18..52b93fcca 100644 --- a/src/CSharp/CodeCracker/Style/ExistenceOperatorAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ExistenceOperatorAnalyzer.cs @@ -18,7 +18,7 @@ public class ExistenceOperatorAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.ExistenceOperator], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ExistenceOperator)); diff --git a/src/CSharp/CodeCracker/Style/ForInArrayAnalyzer.cs b/src/CSharp/CodeCracker/Style/ForInArrayAnalyzer.cs index d76eee1d0..8f36dc842 100644 --- a/src/CSharp/CodeCracker/Style/ForInArrayAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ForInArrayAnalyzer.cs @@ -6,6 +6,7 @@ using System.Linq; using System; using System.Collections.Generic; +using CodeCracker; namespace CodeCracker.CSharp.Style { @@ -21,7 +22,7 @@ public class ForInArrayAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.ForInArray], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ForInArray)); diff --git a/src/CSharp/CodeCracker/Style/InterfaceNameAnalyzer.cs b/src/CSharp/CodeCracker/Style/InterfaceNameAnalyzer.cs index 4cce637cd..e2ba23e44 100644 --- a/src/CSharp/CodeCracker/Style/InterfaceNameAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/InterfaceNameAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +19,7 @@ public class InterfaceNameAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.InterfaceName], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.InterfaceName)); diff --git a/src/CSharp/CodeCracker/Style/ObjectInitializerAnalyzer.cs b/src/CSharp/CodeCracker/Style/ObjectInitializerAnalyzer.cs index 4e67acf8b..132339cb3 100644 --- a/src/CSharp/CodeCracker/Style/ObjectInitializerAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ObjectInitializerAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -23,7 +24,7 @@ public class ObjectInitializerAnalyzer : DiagnosticAnalyzer TitleLocalDeclaration, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.ObjectInitializer_Assignment], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ObjectInitializer_Assignment)); @@ -33,7 +34,7 @@ public class ObjectInitializerAnalyzer : DiagnosticAnalyzer TitleLocalDeclaration, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.ObjectInitializer_LocalDeclaration], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ObjectInitializer_LocalDeclaration)); diff --git a/src/CSharp/CodeCracker/Style/PropertyPrivateSetAnalyzer.cs b/src/CSharp/CodeCracker/Style/PropertyPrivateSetAnalyzer.cs index 093a20c9d..2a9ca361a 100644 --- a/src/CSharp/CodeCracker/Style/PropertyPrivateSetAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/PropertyPrivateSetAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +20,7 @@ public class PropertyPrivateSetAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.PropertyPrivateSet], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.PropertyPrivateSet)); diff --git a/src/CSharp/CodeCracker/Style/RemoveAsyncFromMethodAnalyzer.cs b/src/CSharp/CodeCracker/Style/RemoveAsyncFromMethodAnalyzer.cs index 8d68344e1..b9ce6621a 100644 --- a/src/CSharp/CodeCracker/Style/RemoveAsyncFromMethodAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/RemoveAsyncFromMethodAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -20,7 +21,7 @@ public class RemoveAsyncFromMethodAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.RemoveAsyncFromMethod], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveAsyncFromMethod)); diff --git a/src/CSharp/CodeCracker/Style/RemoveCommentedCodeAnalyzer.cs b/src/CSharp/CodeCracker/Style/RemoveCommentedCodeAnalyzer.cs index a25c49944..ed108038b 100644 --- a/src/CSharp/CodeCracker/Style/RemoveCommentedCodeAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/RemoveCommentedCodeAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.Diagnostics; using Microsoft.CodeAnalysis.Text; @@ -19,7 +19,7 @@ public class RemoveCommentedCodeAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.RemoveCommentedCode], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveCommentedCode)); diff --git a/src/CSharp/CodeCracker/Style/RemoveTrailingWhitespaceAnalyzer.cs b/src/CSharp/CodeCracker/Style/RemoveTrailingWhitespaceAnalyzer.cs index e34368cda..c527a8a98 100644 --- a/src/CSharp/CodeCracker/Style/RemoveTrailingWhitespaceAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/RemoveTrailingWhitespaceAnalyzer.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Collections.Immutable; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; @@ -21,7 +21,7 @@ public class RemoveTrailingWhitespaceAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.RemoveTrailingWhitespace], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveTrailingWhitespace)); diff --git a/src/CSharp/CodeCracker/Style/StringFormatAnalyzer.cs b/src/CSharp/CodeCracker/Style/StringFormatAnalyzer.cs index 55a9a819a..3a67e0705 100644 --- a/src/CSharp/CodeCracker/Style/StringFormatAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/StringFormatAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using CodeCracker.Properties; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; @@ -22,7 +23,7 @@ public class StringFormatAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.StringFormat], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringFormat)); diff --git a/src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs b/src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs index a51c2dff6..de3c5369d 100644 --- a/src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using CodeCracker.Properties; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; @@ -22,7 +23,7 @@ public class SwitchToAutoPropAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.SwitchToAutoProp], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SwitchToAutoProp)); diff --git a/src/CSharp/CodeCracker/Style/TaskNameAsyncAnalyzer.cs b/src/CSharp/CodeCracker/Style/TaskNameAsyncAnalyzer.cs index 160d792e2..3bf838f3e 100644 --- a/src/CSharp/CodeCracker/Style/TaskNameAsyncAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/TaskNameAsyncAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -20,7 +21,7 @@ public class TaskNameAsyncAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.TaskNameAsync], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.TaskNameAsync)); diff --git a/src/CSharp/CodeCracker/Style/TernaryOperatorAnalyzer.cs b/src/CSharp/CodeCracker/Style/TernaryOperatorAnalyzer.cs index 0b53d35e5..6607ad2a2 100644 --- a/src/CSharp/CodeCracker/Style/TernaryOperatorAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/TernaryOperatorAnalyzer.cs @@ -20,7 +20,7 @@ public class TernaryOperatorAnalyzer : DiagnosticAnalyzer Title, MessageFormatForIfWithReturn, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.TernaryOperator_Return], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Return)); @@ -29,7 +29,7 @@ public class TernaryOperatorAnalyzer : DiagnosticAnalyzer Title, MessageFormatForIfWithAssignment, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.TernaryOperator_Assignment], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Assignment)); diff --git a/src/CSharp/CodeCracker/Style/UnnecessaryParenthesisAnalyzer.cs b/src/CSharp/CodeCracker/Style/UnnecessaryParenthesisAnalyzer.cs index 410eb60be..37f24df52 100644 --- a/src/CSharp/CodeCracker/Style/UnnecessaryParenthesisAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/UnnecessaryParenthesisAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -20,7 +20,7 @@ public class UnnecessaryParenthesisAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.UnnecessaryParenthesis], customTags: WellKnownDiagnosticTags.Unnecessary, isEnabledByDefault: true, description: Description, diff --git a/src/CSharp/CodeCracker/Style/UnnecessaryToStringInStringConcatenationAnalyzer.cs b/src/CSharp/CodeCracker/Style/UnnecessaryToStringInStringConcatenationAnalyzer.cs index 20bc013e4..e17201734 100644 --- a/src/CSharp/CodeCracker/Style/UnnecessaryToStringInStringConcatenationAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/UnnecessaryToStringInStringConcatenationAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -25,7 +26,7 @@ public class UnnecessaryToStringInStringConcatenationAnalyzer : DiagnosticAnalyz Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.UnnecessaryToStringInStringConcatenation], customTags: WellKnownDiagnosticTags.Unnecessary, isEnabledByDefault: true, description: Description, diff --git a/src/CSharp/CodeCracker/Style/UseEmptyStringAnalyzer.cs b/src/CSharp/CodeCracker/Style/UseEmptyStringAnalyzer.cs index cfba91fb3..44de0bb37 100644 --- a/src/CSharp/CodeCracker/Style/UseEmptyStringAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/UseEmptyStringAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -23,7 +24,7 @@ public class UseEmptyStringAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.UseEmptyString], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseEmptyString)); diff --git a/src/CSharp/CodeCracker/Style/UseStringEmptyAnalyzer.cs b/src/CSharp/CodeCracker/Style/UseStringEmptyAnalyzer.cs index 0edc4fe64..3cb86722f 100644 --- a/src/CSharp/CodeCracker/Style/UseStringEmptyAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/UseStringEmptyAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +20,7 @@ public class UseStringEmptyAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentCS[DiagnosticId.UseStringEmpty], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseStringEmpty)); diff --git a/src/CSharp/CodeCracker/Usage/AbstractClassShouldNotHavePublicCtorsAnalyzer.cs b/src/CSharp/CodeCracker/Usage/AbstractClassShouldNotHavePublicCtorsAnalyzer.cs index 273f37ee7..e3001b217 100644 --- a/src/CSharp/CodeCracker/Usage/AbstractClassShouldNotHavePublicCtorsAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/AbstractClassShouldNotHavePublicCtorsAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +20,7 @@ public class AbstractClassShouldNotHavePublicCtorsAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.AbstractClassShouldNotHavePublicCtors], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AbstractClassShouldNotHavePublicCtors)); diff --git a/src/CSharp/CodeCracker/Usage/ArgumentExceptionAnalyzer.cs b/src/CSharp/CodeCracker/Usage/ArgumentExceptionAnalyzer.cs index b2a1daa96..e850bb046 100644 --- a/src/CSharp/CodeCracker/Usage/ArgumentExceptionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/ArgumentExceptionAnalyzer.cs @@ -22,7 +22,7 @@ public class ArgumentExceptionAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.ArgumentException], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ArgumentException)); diff --git a/src/CSharp/CodeCracker/Usage/CallExtensionMethodAsExtensionAnalyzer.cs b/src/CSharp/CodeCracker/Usage/CallExtensionMethodAsExtensionAnalyzer.cs index 0a6f14de5..a744ad81a 100644 --- a/src/CSharp/CodeCracker/Usage/CallExtensionMethodAsExtensionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/CallExtensionMethodAsExtensionAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Extensions; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class CallExtensionMethodAsExtensionAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.CallExtensionMethodAsExtension], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.CallExtensionMethodAsExtension)); diff --git a/src/CSharp/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.cs b/src/CSharp/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.cs index b90b12001..2e2929bf9 100644 --- a/src/CSharp/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class DisposableFieldNotDisposedAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.DisposableFieldNotDisposed_Returned], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.DisposableFieldNotDisposed_Returned)); @@ -30,7 +31,7 @@ public class DisposableFieldNotDisposedAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.DisposableFieldNotDisposed_Created], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.DisposableFieldNotDisposed_Created)); diff --git a/src/CSharp/CodeCracker/Usage/DisposableVariableNotDisposedAnalyzer.cs b/src/CSharp/CodeCracker/Usage/DisposableVariableNotDisposedAnalyzer.cs index 3ed958b5f..8cd76c3e7 100644 --- a/src/CSharp/CodeCracker/Usage/DisposableVariableNotDisposedAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/DisposableVariableNotDisposedAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -22,7 +23,7 @@ public class DisposableVariableNotDisposedAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.DisposableVariableNotDisposed], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.DisposableVariableNotDisposed)); diff --git a/src/CSharp/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.cs b/src/CSharp/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.cs index b70f8d735..0dcbc95af 100644 --- a/src/CSharp/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.cs @@ -1,10 +1,11 @@ -using System; +using System; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; using System.Collections.Immutable; using System.Linq; using Microsoft.CodeAnalysis.CSharp; +using CodeCracker; namespace CodeCracker.CSharp.Usage { @@ -22,7 +23,7 @@ public class DisposablesShouldCallSuppressFinalizeAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.DisposablesShouldCallSuppressFinalize], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.DisposablesShouldCallSuppressFinalize)); diff --git a/src/CSharp/CodeCracker/Usage/IPAddressAnalyzer.cs b/src/CSharp/CodeCracker/Usage/IPAddressAnalyzer.cs index ba2b3b03b..9f121c65b 100644 --- a/src/CSharp/CodeCracker/Usage/IPAddressAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/IPAddressAnalyzer.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Collections.Immutable; using System.Reflection; using CodeCracker.CSharp.Usage.MethodAnalyzers; @@ -23,7 +23,7 @@ public class IPAddressAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Error, + SeverityConfigurations.CurrentCS[DiagnosticId.IPAddress], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.IPAddress)); diff --git a/src/CSharp/CodeCracker/Usage/IfReturnTrueAnalyzer.cs b/src/CSharp/CodeCracker/Usage/IfReturnTrueAnalyzer.cs index c03121553..edad491cd 100644 --- a/src/CSharp/CodeCracker/Usage/IfReturnTrueAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/IfReturnTrueAnalyzer.cs @@ -19,7 +19,7 @@ public class IfReturnTrueAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.IfReturnTrue], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.IfReturnTrue)); diff --git a/src/CSharp/CodeCracker/Usage/JsonNetAnalyzer.cs b/src/CSharp/CodeCracker/Usage/JsonNetAnalyzer.cs index d69c802dc..5aa1e9402 100644 --- a/src/CSharp/CodeCracker/Usage/JsonNetAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/JsonNetAnalyzer.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Collections.Immutable; using System.Reflection; using Microsoft.CodeAnalysis; @@ -22,7 +22,7 @@ public class JsonNetAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Error, + SeverityConfigurations.CurrentCS[DiagnosticId.JsonNet], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.JsonNet)); diff --git a/src/CSharp/CodeCracker/Usage/NoPrivateReadonlyFieldAnalyzer.cs b/src/CSharp/CodeCracker/Usage/NoPrivateReadonlyFieldAnalyzer.cs index f87394915..306fc77e3 100644 --- a/src/CSharp/CodeCracker/Usage/NoPrivateReadonlyFieldAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/NoPrivateReadonlyFieldAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class NoPrivateReadonlyFieldAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.NoPrivateReadonlyField], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NoPrivateReadonlyField)); diff --git a/src/CSharp/CodeCracker/Usage/ReadOnlyComplexTypesAnalyzer.cs b/src/CSharp/CodeCracker/Usage/ReadOnlyComplexTypesAnalyzer.cs index 089013936..43c494497 100644 --- a/src/CSharp/CodeCracker/Usage/ReadOnlyComplexTypesAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/ReadOnlyComplexTypesAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -22,7 +22,7 @@ public class ReadOnlyComplexTypesAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.ReadOnlyComplexTypes], isEnabledByDefault: false, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ReadOnlyComplexTypes)); diff --git a/src/CSharp/CodeCracker/Usage/ReadonlyFieldAnalyzer.cs b/src/CSharp/CodeCracker/Usage/ReadonlyFieldAnalyzer.cs index 1fa957957..4835a802f 100644 --- a/src/CSharp/CodeCracker/Usage/ReadonlyFieldAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/ReadonlyFieldAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class ReadonlyFieldAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.ReadonlyField], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ReadonlyField)); diff --git a/src/CSharp/CodeCracker/Usage/RedundantFieldAssignmentAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RedundantFieldAssignmentAnalyzer.cs index 7791f70cb..962616dbd 100644 --- a/src/CSharp/CodeCracker/Usage/RedundantFieldAssignmentAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RedundantFieldAssignmentAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class RedundantFieldAssignmentAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.RedundantFieldAssignment], isEnabledByDefault: true, customTags: WellKnownDiagnosticTags.Unnecessary, description: Description, diff --git a/src/CSharp/CodeCracker/Usage/RegexAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RegexAnalyzer.cs index 41393ac96..1f869aece 100644 --- a/src/CSharp/CodeCracker/Usage/RegexAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RegexAnalyzer.cs @@ -20,7 +20,7 @@ public class RegexAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Error, + SeverityConfigurations.CurrentCS[DiagnosticId.Regex], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.Regex)); diff --git a/src/CSharp/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.cs index 26b80458c..99db4b28c 100644 --- a/src/CSharp/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -23,7 +24,7 @@ public class RemovePrivateMethodNeverUsedAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.RemovePrivateMethodNeverUsed], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemovePrivateMethodNeverUsed)); diff --git a/src/CSharp/CodeCracker/Usage/RemoveRedundantElseClauseAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RemoveRedundantElseClauseAnalyzer.cs index 03294eb66..1f4bcf811 100644 --- a/src/CSharp/CodeCracker/Usage/RemoveRedundantElseClauseAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RemoveRedundantElseClauseAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +19,7 @@ public class RemoveRedundantElseClauseAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.RemoveRedundantElseClause], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveRedundantElseClause)); diff --git a/src/CSharp/CodeCracker/Usage/RethrowExceptionAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RethrowExceptionAnalyzer.cs index cf2376d77..8d1b35508 100644 --- a/src/CSharp/CodeCracker/Usage/RethrowExceptionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RethrowExceptionAnalyzer.cs @@ -21,7 +21,7 @@ public class RethrowExceptionAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.RethrowException], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RethrowException)); diff --git a/src/CSharp/CodeCracker/Usage/SimplifyRedundantBooleanComparisonsAnalyzer.cs b/src/CSharp/CodeCracker/Usage/SimplifyRedundantBooleanComparisonsAnalyzer.cs index 0a149d2b5..492c56b6e 100644 --- a/src/CSharp/CodeCracker/Usage/SimplifyRedundantBooleanComparisonsAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/SimplifyRedundantBooleanComparisonsAnalyzer.cs @@ -1,4 +1,4 @@ -using System.Collections.Immutable; +using System.Collections.Immutable; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -18,7 +18,7 @@ public class SimplifyRedundantBooleanComparisonsAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentCS[DiagnosticId.SimplifyRedundantBooleanComparisons], isEnabledByDefault: true, customTags: WellKnownDiagnosticTags.Unnecessary, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SimplifyRedundantBooleanComparisons)); diff --git a/src/CSharp/CodeCracker/Usage/StringFormatArgsAnalyzer.cs b/src/CSharp/CodeCracker/Usage/StringFormatArgsAnalyzer.cs index 3213dfe6c..7aa3053df 100644 --- a/src/CSharp/CodeCracker/Usage/StringFormatArgsAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/StringFormatArgsAnalyzer.cs @@ -23,7 +23,7 @@ public class StringFormatArgsAnalyzer : DiagnosticAnalyzer Title, IncorrectNumberOfArgsMessage, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.StringFormatArgs_ExtraArgs], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringFormatArgs_ExtraArgs)); @@ -33,7 +33,7 @@ public class StringFormatArgsAnalyzer : DiagnosticAnalyzer Title, InvalidArgsReferenceMessage, Category, - DiagnosticSeverity.Error, + SeverityConfigurations.CurrentCS[DiagnosticId.StringFormatArgs_InvalidArgs], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringFormatArgs_InvalidArgs)); diff --git a/src/CSharp/CodeCracker/Usage/UnusedParametersAnalyzer.cs b/src/CSharp/CodeCracker/Usage/UnusedParametersAnalyzer.cs index db1cbdf65..bee655b2c 100644 --- a/src/CSharp/CodeCracker/Usage/UnusedParametersAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/UnusedParametersAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class UnusedParametersAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.UnusedParameters], isEnabledByDefault: true, description: Description, customTags: WellKnownDiagnosticTags.Unnecessary, diff --git a/src/CSharp/CodeCracker/Usage/UriAnalyzer.cs b/src/CSharp/CodeCracker/Usage/UriAnalyzer.cs index 464976212..24c766c87 100644 --- a/src/CSharp/CodeCracker/Usage/UriAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/UriAnalyzer.cs @@ -1,4 +1,4 @@ -using CodeCracker.CSharp.Usage.MethodAnalyzers; +using CodeCracker.CSharp.Usage.MethodAnalyzers; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.Diagnostics; @@ -22,7 +22,7 @@ public class UriAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Error, + SeverityConfigurations.CurrentCS[DiagnosticId.Uri], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.Uri)); diff --git a/src/CSharp/CodeCracker/Usage/VirtualMethodOnConstructorAnalyzer.cs b/src/CSharp/CodeCracker/Usage/VirtualMethodOnConstructorAnalyzer.cs index f0d2becef..adfd9334e 100644 --- a/src/CSharp/CodeCracker/Usage/VirtualMethodOnConstructorAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/VirtualMethodOnConstructorAnalyzer.cs @@ -1,4 +1,4 @@ -using System.Collections.Immutable; +using System.Collections.Immutable; using System.Linq; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; @@ -23,7 +23,7 @@ public class VirtualMethodOnConstructorAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentCS[DiagnosticId.VirtualMethodOnConstructor], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.VirtualMethodOnConstructor)); diff --git a/src/Common/CodeCracker.Common/CodeCracker.Common.csproj b/src/Common/CodeCracker.Common/CodeCracker.Common.csproj index 8f502cca1..e5f0c971c 100644 --- a/src/Common/CodeCracker.Common/CodeCracker.Common.csproj +++ b/src/Common/CodeCracker.Common/CodeCracker.Common.csproj @@ -46,6 +46,7 @@ + diff --git a/src/Common/CodeCracker.Common/SeverityConfigurations.cs b/src/Common/CodeCracker.Common/SeverityConfigurations.cs new file mode 100644 index 000000000..0dedbc486 --- /dev/null +++ b/src/Common/CodeCracker.Common/SeverityConfigurations.cs @@ -0,0 +1,172 @@ +using Microsoft.CodeAnalysis; +using System; +using System.Collections; +using System.Collections.Concurrent; +using System.Collections.Generic; +using System.Linq; +using System.Text; +using System.Threading; +using System.Threading.Tasks; + +namespace CodeCracker +{ + /// + /// Contains all DiagnosticSeverities for all DiagnosticIds. + /// + public class SeverityConfigurations + { + /// + /// Gets the DiagnosticSeverities that is configured by the user in VB language. + /// + public static SeverityConfigurations CurrentVB => _vbDefault.Value; + + /// + /// Gets the DiagnosticSeverities that is configured by the user in C# language. + /// + public static SeverityConfigurations CurrentCS => _csDefault.Value; + + /// + /// Gets the default DiagnosticSeverities of all DiagnosticIds. + /// + public static SeverityConfigurations Default => _default.Value; + + /// + /// Initialize a new instance of . + /// + /// The differential to the default values. + private SeverityConfigurations(IDictionary additional = null) + { + if (additional != null) + { + foreach (var pair in additional) + { + _diagnosticSeverities[pair.Key] = pair.Value; + } + } + } + + /// + /// Gets the of the specified . + /// + /// The which you want to get the . + /// The of the specified . + public DiagnosticSeverity this[DiagnosticId id] + => _diagnosticSeverities.TryGetValue(id, out var value) + ? value + : DiagnosticSeverity.Warning; + + /// + /// Stores all the DiagnosticSeverities. + /// + private readonly ConcurrentDictionary _diagnosticSeverities + = new ConcurrentDictionary(new Dictionary + { + { DiagnosticId.None, DiagnosticSeverity.Hidden }, + { DiagnosticId.AlwaysUseVar, DiagnosticSeverity.Warning }, + { DiagnosticId.ArgumentException, DiagnosticSeverity.Warning }, + { DiagnosticId.CatchEmpty, DiagnosticSeverity.Warning }, + { DiagnosticId.EmptyCatchBlock, DiagnosticSeverity.Warning }, + { DiagnosticId.EmptyObjectInitializer, DiagnosticSeverity.Warning }, + { DiagnosticId.ForInArray, DiagnosticSeverity.Warning }, + { DiagnosticId.IfReturnTrue, DiagnosticSeverity.Warning }, + { DiagnosticId.ObjectInitializer_LocalDeclaration, DiagnosticSeverity.Warning }, + { DiagnosticId.ObjectInitializer_Assignment, DiagnosticSeverity.Warning }, + { DiagnosticId.Regex, DiagnosticSeverity.Error }, + { DiagnosticId.RemoveWhereWhenItIsPossible, DiagnosticSeverity.Warning }, + { DiagnosticId.RethrowException, DiagnosticSeverity.Warning }, + { DiagnosticId.TernaryOperator_Return, DiagnosticSeverity.Info }, + { DiagnosticId.TernaryOperator_Assignment, DiagnosticSeverity.Info }, + { DiagnosticId.UnnecessaryParenthesis, DiagnosticSeverity.Warning }, + { DiagnosticId.SwitchToAutoProp, DiagnosticSeverity.Info }, + { DiagnosticId.ExistenceOperator, DiagnosticSeverity.Info }, + { DiagnosticId.ConvertToSwitch, DiagnosticSeverity.Info }, + { DiagnosticId.ConvertLambdaExpressionToMethodGroup, DiagnosticSeverity.Hidden }, + { DiagnosticId.NameOf, DiagnosticSeverity.Warning }, + { DiagnosticId.DisposableVariableNotDisposed, DiagnosticSeverity.Warning }, + { DiagnosticId.SealedAttribute, DiagnosticSeverity.Warning }, + { DiagnosticId.StaticConstructorException, DiagnosticSeverity.Warning }, + { DiagnosticId.EmptyFinalizer, DiagnosticSeverity.Warning }, + { DiagnosticId.CallExtensionMethodAsExtension, DiagnosticSeverity.Info }, + { DiagnosticId.DisposablesShouldCallSuppressFinalize, DiagnosticSeverity.Warning }, + { DiagnosticId.MakeLocalVariableConstWhenItIsPossible, DiagnosticSeverity.Info }, + { DiagnosticId.UseInvokeMethodToFireEvent, DiagnosticSeverity.Warning }, + { DiagnosticId.DisposableFieldNotDisposed_Returned, DiagnosticSeverity.Info }, + { DiagnosticId.DisposableFieldNotDisposed_Created, DiagnosticSeverity.Warning }, + { DiagnosticId.AllowMembersOrdering, DiagnosticSeverity.Hidden }, + { DiagnosticId.RedundantFieldAssignment, DiagnosticSeverity.Info }, + { DiagnosticId.RemoveCommentedCode, DiagnosticSeverity.Info }, + { DiagnosticId.ConvertToExpressionBodiedMember, DiagnosticSeverity.Hidden }, + { DiagnosticId.StringBuilderInLoop, DiagnosticSeverity.Warning }, + { DiagnosticId.InvertFor, DiagnosticSeverity.Hidden }, + { DiagnosticId.ChangeAnyToAll, DiagnosticSeverity.Hidden }, + { DiagnosticId.ParameterRefactory, DiagnosticSeverity.Hidden }, + { DiagnosticId.StringRepresentation_RegularString, DiagnosticSeverity.Hidden }, + { DiagnosticId.StringRepresentation_VerbatimString, DiagnosticSeverity.Hidden }, + { DiagnosticId.PropertyPrivateSet, DiagnosticSeverity.Hidden }, + { DiagnosticId.StringFormat, DiagnosticSeverity.Info }, + { DiagnosticId.SimplifyRedundantBooleanComparisons, DiagnosticSeverity.Info }, + { DiagnosticId.ReadonlyField, DiagnosticSeverity.Info }, + { DiagnosticId.JsonNet, DiagnosticSeverity.Error }, + { DiagnosticId.StringFormatArgs_InvalidArgs, DiagnosticSeverity.Error }, + { DiagnosticId.UnusedParameters, DiagnosticSeverity.Warning }, + { DiagnosticId.AbstractClassShouldNotHavePublicCtors, DiagnosticSeverity.Warning }, + { DiagnosticId.TaskNameAsync, DiagnosticSeverity.Info }, + { DiagnosticId.InterfaceName, DiagnosticSeverity.Info }, + { DiagnosticId.Uri, DiagnosticSeverity.Error }, + { DiagnosticId.IPAddress, DiagnosticSeverity.Error }, + { DiagnosticId.RemoveTrailingWhitespace, DiagnosticSeverity.Info }, + { DiagnosticId.VirtualMethodOnConstructor, DiagnosticSeverity.Warning }, + { DiagnosticId.RemovePrivateMethodNeverUsed, DiagnosticSeverity.Info }, + { DiagnosticId.UseConfigureAwaitFalse, DiagnosticSeverity.Hidden }, + { DiagnosticId.IntroduceFieldFromConstructor, DiagnosticSeverity.Hidden }, + { DiagnosticId.RemoveAsyncFromMethod, DiagnosticSeverity.Info }, + { DiagnosticId.AddBracesToSwitchSections, DiagnosticSeverity.Hidden }, + { DiagnosticId.NoPrivateReadonlyField, DiagnosticSeverity.Info }, + { DiagnosticId.MergeNestedIf, DiagnosticSeverity.Hidden }, + { DiagnosticId.SplitIntoNestedIf, DiagnosticSeverity.Hidden }, + { DiagnosticId.NumericLiteral, DiagnosticSeverity.Hidden }, + { DiagnosticId.TernaryOperator_Iif, DiagnosticSeverity.Warning }, + { DiagnosticId.UseStaticRegexIsMatch, DiagnosticSeverity.Info }, + { DiagnosticId.ComputeExpression, DiagnosticSeverity.Hidden }, + { DiagnosticId.UseStringEmpty, DiagnosticSeverity.Hidden }, + { DiagnosticId.UseEmptyString, DiagnosticSeverity.Hidden }, + { DiagnosticId.RemoveRedundantElseClause, DiagnosticSeverity.Info }, + { DiagnosticId.XmlDocumentation_MissingInCSharp, DiagnosticSeverity.Info }, + { DiagnosticId.MakeMethodStatic, DiagnosticSeverity.Warning }, + { DiagnosticId.ChangeAllToAny, DiagnosticSeverity.Hidden }, + { DiagnosticId.ConsoleWriteLine, DiagnosticSeverity.Info }, + { DiagnosticId.XmlDocumentation_MissingInXml, DiagnosticSeverity.Warning }, + { DiagnosticId.NameOf_External, DiagnosticSeverity.Warning }, + { DiagnosticId.StringFormatArgs_ExtraArgs, DiagnosticSeverity.Warning }, + { DiagnosticId.AlwaysUseVarOnPrimitives, DiagnosticSeverity.Warning }, + { DiagnosticId.PropertyChangedEventArgsUnnecessaryAllocation, DiagnosticSeverity.Hidden }, + { DiagnosticId.UnnecessaryToStringInStringConcatenation, DiagnosticSeverity.Info }, + { DiagnosticId.SwitchCaseWithoutDefault, DiagnosticSeverity.Warning }, + { DiagnosticId.ReadOnlyComplexTypes, DiagnosticSeverity.Warning }, + { DiagnosticId.ReplaceWithGetterOnlyAutoProperty, DiagnosticSeverity.Hidden }, + }); + + /// + /// Lazy initialize value for . + /// + private static readonly Lazy _vbDefault = new Lazy(() + => new SeverityConfigurations(new Dictionary + { + // These are the differantials to the C# version. + { DiagnosticId.TernaryOperator_Assignment, DiagnosticSeverity.Warning }, + { DiagnosticId.TernaryOperator_Return, DiagnosticSeverity.Warning }, + }), LazyThreadSafetyMode.ExecutionAndPublication); + + /// + /// Lazy initialize value for . + /// + private static readonly Lazy _csDefault = new Lazy(() + => new SeverityConfigurations(), LazyThreadSafetyMode.ExecutionAndPublication); + + /// + /// Lazy initialize value for default. + /// + private static readonly Lazy _default = new Lazy(() + => new SeverityConfigurations(), LazyThreadSafetyMode.ExecutionAndPublication); + } +} diff --git a/src/VisualBasic/CodeCracker/Design/CatchEmptyAnalyzer.vb b/src/VisualBasic/CodeCracker/Design/CatchEmptyAnalyzer.vb index e4f1b7c9c..f5a7f288c 100644 --- a/src/VisualBasic/CodeCracker/Design/CatchEmptyAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Design/CatchEmptyAnalyzer.vb @@ -1,4 +1,4 @@ -Imports Microsoft.CodeAnalysis +Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic Imports System.Collections.Immutable @@ -17,7 +17,7 @@ Namespace Design Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.CatchEmpty), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.CatchEmpty)) diff --git a/src/VisualBasic/CodeCracker/Design/EmptyCatchBlockAnalyzer.vb b/src/VisualBasic/CodeCracker/Design/EmptyCatchBlockAnalyzer.vb index cda5e4b6e..62068cd6a 100644 --- a/src/VisualBasic/CodeCracker/Design/EmptyCatchBlockAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Design/EmptyCatchBlockAnalyzer.vb @@ -20,7 +20,7 @@ If the error is expected, consider logging it or changing the control flow such Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.EmptyCatchBlock), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.EmptyCatchBlock)) diff --git a/src/VisualBasic/CodeCracker/Design/NameOfAnalyzer.vb b/src/VisualBasic/CodeCracker/Design/NameOfAnalyzer.vb index 482eceea5..1854d8318 100644 --- a/src/VisualBasic/CodeCracker/Design/NameOfAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Design/NameOfAnalyzer.vb @@ -1,4 +1,4 @@ -Imports Microsoft.CodeAnalysis +Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic Imports Microsoft.CodeAnalysis.VisualBasic.Syntax @@ -20,7 +20,7 @@ Namespace Design Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.NameOf), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.NameOf)) @@ -29,7 +29,7 @@ Namespace Design Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.NameOf_External), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.NameOf_External)) diff --git a/src/VisualBasic/CodeCracker/Design/StaticConstructorExceptionAnalyzer.vb b/src/VisualBasic/CodeCracker/Design/StaticConstructorExceptionAnalyzer.vb index 3cfaab1f3..3bfb359b7 100644 --- a/src/VisualBasic/CodeCracker/Design/StaticConstructorExceptionAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Design/StaticConstructorExceptionAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -19,7 +19,7 @@ Namespace Design Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.StaticConstructorException), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.StaticConstructorException)) diff --git a/src/VisualBasic/CodeCracker/Performance/MakeLocalVariableConstWhenPossibleAnalyzer.vb b/src/VisualBasic/CodeCracker/Performance/MakeLocalVariableConstWhenPossibleAnalyzer.vb index e406b7fd7..01c818015 100644 --- a/src/VisualBasic/CodeCracker/Performance/MakeLocalVariableConstWhenPossibleAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Performance/MakeLocalVariableConstWhenPossibleAnalyzer.vb @@ -1,4 +1,4 @@ -Imports Microsoft.CodeAnalysis +Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic Imports Microsoft.CodeAnalysis.VisualBasic.Syntax @@ -19,7 +19,7 @@ Namespace Performance Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentVB(DiagnosticId.MakeLocalVariableConstWhenItIsPossible), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.MakeLocalVariableConstWhenItIsPossible)) diff --git a/src/VisualBasic/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.vb b/src/VisualBasic/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.vb index 584604eb5..28c5ac103 100644 --- a/src/VisualBasic/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.vb @@ -1,4 +1,4 @@ -Imports Microsoft.CodeAnalysis +Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic Imports Microsoft.CodeAnalysis.VisualBasic.Syntax @@ -19,7 +19,7 @@ Namespace Performance Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.RemoveWhereWhenItIsPossible), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.RemoveWhereWhenItIsPossible)) diff --git a/src/VisualBasic/CodeCracker/Performance/SealedAttributeAnalyzer.vb b/src/VisualBasic/CodeCracker/Performance/SealedAttributeAnalyzer.vb index 1f8429ad8..fd7a0573a 100644 --- a/src/VisualBasic/CodeCracker/Performance/SealedAttributeAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Performance/SealedAttributeAnalyzer.vb @@ -1,4 +1,4 @@ -Imports Microsoft.CodeAnalysis +Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports System.Collections.Immutable @@ -17,7 +17,7 @@ Namespace Performance Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.SealedAttribute), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.SealedAttribute)) diff --git a/src/VisualBasic/CodeCracker/Performance/StringBuilderInLoopAnalyzer.vb b/src/VisualBasic/CodeCracker/Performance/StringBuilderInLoopAnalyzer.vb index 36c1a1ac1..676684327 100644 --- a/src/VisualBasic/CodeCracker/Performance/StringBuilderInLoopAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Performance/StringBuilderInLoopAnalyzer.vb @@ -1,4 +1,4 @@ -Imports Microsoft.CodeAnalysis +Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic Imports Microsoft.CodeAnalysis.VisualBasic.Syntax @@ -19,7 +19,7 @@ Namespace Performance Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.StringBuilderInLoop), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.StringBuilderInLoop)) diff --git a/src/VisualBasic/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.vb b/src/VisualBasic/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.vb index 00f929e16..c3742351d 100644 --- a/src/VisualBasic/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -19,7 +19,7 @@ Namespace Refactoring Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentVB(DiagnosticId.AllowMembersOrdering), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.AllowMembersOrdering)) diff --git a/src/VisualBasic/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.vb b/src/VisualBasic/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.vb index 8ca812ef0..607b7edb0 100644 --- a/src/VisualBasic/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -20,7 +20,7 @@ Namespace Refactoring TitleAny, MessageAny, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentVB(DiagnosticId.ChangeAnyToAll), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.ChangeAnyToAll)) Friend Shared RuleAll As New DiagnosticDescriptor( @@ -28,7 +28,7 @@ Namespace Refactoring TitleAll, MessageAll, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentVB(DiagnosticId.ChangeAllToAny), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.ChangeAllToAny)) diff --git a/src/VisualBasic/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.vb b/src/VisualBasic/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.vb index bffee2b9c..ec39234ce 100644 --- a/src/VisualBasic/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports System.Threading Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics @@ -20,7 +20,7 @@ Namespace Reliability Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.CurrentVB(DiagnosticId.UseConfigureAwaitFalse), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.UseConfigureAwaitFalse)) diff --git a/src/VisualBasic/CodeCracker/Style/TernaryOperatorAnalyzer.vb b/src/VisualBasic/CodeCracker/Style/TernaryOperatorAnalyzer.vb index 81602adea..097b88c12 100644 --- a/src/VisualBasic/CodeCracker/Style/TernaryOperatorAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Style/TernaryOperatorAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -17,7 +17,7 @@ Namespace Style Title, MessageFormat, SupportedCategories.Style, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.TernaryOperator_Return), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Return)) @@ -26,7 +26,7 @@ Namespace Style Title, MessageFormat, SupportedCategories.Style, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.TernaryOperator_Assignment), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Assignment)) @@ -35,7 +35,7 @@ Namespace Style Title, MessageFormat, SupportedCategories.Style, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.TernaryOperator_Iif), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Iif)) diff --git a/src/VisualBasic/CodeCracker/Usage/ArgumentExceptionAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/ArgumentExceptionAnalyzer.vb index 5f44756e4..803648820 100644 --- a/src/VisualBasic/CodeCracker/Usage/ArgumentExceptionAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/ArgumentExceptionAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -18,7 +18,7 @@ It can be either specified directly or using nameof() (VB 14 and above only)." Title, MessageFormat, SupportedCategories.Naming, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.ArgumentException), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.ArgumentException)) diff --git a/src/VisualBasic/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.vb index 16ed817be..6f0a69c66 100644 --- a/src/VisualBasic/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -18,7 +18,7 @@ Namespace Usage Title, MessageFormat, SupportedCategories.Usage, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentVB(DiagnosticId.DisposableFieldNotDisposed_Returned), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.DisposableFieldNotDisposed_Returned)) @@ -28,7 +28,7 @@ Namespace Usage Title, MessageFormat, SupportedCategories.Usage, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.DisposableFieldNotDisposed_Created), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.DisposableFieldNotDisposed_Created)) diff --git a/src/VisualBasic/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.vb index 2b80fa72d..654a84788 100644 --- a/src/VisualBasic/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic.Syntax @@ -20,7 +20,7 @@ This rule should be followed even if the class doesn't have a finalizer in a der Title, MessageFormat, SupportedCategories.Naming, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.DisposablesShouldCallSuppressFinalize), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.DisposablesShouldCallSuppressFinalize)) diff --git a/src/VisualBasic/CodeCracker/Usage/IPAddressAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/IPAddressAnalyzer.vb index 49b2acf07..621bb883b 100644 --- a/src/VisualBasic/CodeCracker/Usage/IPAddressAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/IPAddressAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports System.Reflection Imports CodeCracker.VisualBasic.Usage.MethodAnalyzers Imports Microsoft.CodeAnalysis @@ -18,7 +18,7 @@ Public Class IPAddressAnalyzer Title, MessageFormat, SupportedCategories.Usage, - DiagnosticSeverity.Error, + SeverityConfigurations.CurrentVB(DiagnosticId.IPAddress), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.IPAddress)) diff --git a/src/VisualBasic/CodeCracker/Usage/JsonNetAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/JsonNetAnalyzer.vb index fc5ca332d..5689dfac4 100644 --- a/src/VisualBasic/CodeCracker/Usage/JsonNetAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/JsonNetAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports System.Reflection Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics @@ -19,7 +19,7 @@ Namespace Usage Title, MessageFormat, SupportedCategories.Usage, - DiagnosticSeverity.Error, + SeverityConfigurations.CurrentVB(DiagnosticId.JsonNet), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.JsonNet)) diff --git a/src/VisualBasic/CodeCracker/Usage/MustInheritClassShouldNotHavePublicConstructorsAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/MustInheritClassShouldNotHavePublicConstructorsAnalyzer.vb index 0ca476ee2..d931fea4d 100644 --- a/src/VisualBasic/CodeCracker/Usage/MustInheritClassShouldNotHavePublicConstructorsAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/MustInheritClassShouldNotHavePublicConstructorsAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -17,7 +17,7 @@ Namespace Usage Title, MessageFormat, SupportedCategories.Usage, - DiagnosticSeverity.Warning, + SeverityConfigurations.CurrentVB(DiagnosticId.AbstractClassShouldNotHavePublicCtors), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.AbstractClassShouldNotHavePublicCtors)) diff --git a/src/VisualBasic/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.vb index 652a83ca7..fc6efd46a 100644 --- a/src/VisualBasic/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -18,7 +18,7 @@ Namespace Usage Title, Message, SupportedCategories.Usage, - DiagnosticSeverity.Info, + SeverityConfigurations.CurrentVB(DiagnosticId.RemovePrivateMethodNeverUsed), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.RemovePrivateMethodNeverUsed))