From 9dc560d925f95af2d670eceee6b3b165885b0c66 Mon Sep 17 00:00:00 2001 From: walterlv Date: Fri, 30 Aug 2019 12:15:16 +0800 Subject: [PATCH 1/6] Extract all diagnostic severities so that we can make default rulesets. --- .../CodeCracker.Common.csproj | 1 + .../ServerityConfigurations.cs | 115 ++++++++++++++++++ 2 files changed, 116 insertions(+) create mode 100644 src/Common/CodeCracker.Common/ServerityConfigurations.cs diff --git a/src/Common/CodeCracker.Common/CodeCracker.Common.csproj b/src/Common/CodeCracker.Common/CodeCracker.Common.csproj index 8f502cca1..b21385b61 100644 --- a/src/Common/CodeCracker.Common/CodeCracker.Common.csproj +++ b/src/Common/CodeCracker.Common/CodeCracker.Common.csproj @@ -46,6 +46,7 @@ + diff --git a/src/Common/CodeCracker.Common/ServerityConfigurations.cs b/src/Common/CodeCracker.Common/ServerityConfigurations.cs new file mode 100644 index 000000000..b00337d64 --- /dev/null +++ b/src/Common/CodeCracker.Common/ServerityConfigurations.cs @@ -0,0 +1,115 @@ +using Microsoft.CodeAnalysis; +using System; +using System.Collections.Concurrent; +using System.Collections.Generic; +using System.Linq; +using System.Text; +using System.Threading.Tasks; + +namespace CodeCracker +{ + public class SeverityConfigurations + { + public static SeverityConfigurations Current { get; } = new SeverityConfigurations(); + + public static SeverityConfigurations Default { get; } = new SeverityConfigurations(); + + private readonly ConcurrentDictionary _diagnosticServerities; + + private SeverityConfigurations() + { + var values = new Dictionary + { + { DiagnosticId.None, DiagnosticSeverity.Hidden }, + { DiagnosticId.AlwaysUseVar, DiagnosticSeverity.Warning }, + { DiagnosticId.ArgumentException, DiagnosticSeverity.Warning }, + { DiagnosticId.CatchEmpty, DiagnosticSeverity.Warning }, + { DiagnosticId.EmptyCatchBlock, DiagnosticSeverity.Warning }, + { DiagnosticId.EmptyObjectInitializer, DiagnosticSeverity.Warning }, + { DiagnosticId.ForInArray, DiagnosticSeverity.Warning }, + { DiagnosticId.IfReturnTrue, DiagnosticSeverity.Warning }, + { DiagnosticId.ObjectInitializer_LocalDeclaration, DiagnosticSeverity.Warning }, + { DiagnosticId.ObjectInitializer_Assignment, DiagnosticSeverity.Warning }, + { DiagnosticId.Regex, DiagnosticSeverity.Error }, + { DiagnosticId.RemoveWhereWhenItIsPossible, DiagnosticSeverity.Warning }, + { DiagnosticId.RethrowException, DiagnosticSeverity.Warning }, + { DiagnosticId.TernaryOperator_Return, DiagnosticSeverity.Info }, + { DiagnosticId.TernaryOperator_Assignment, DiagnosticSeverity.Info }, + { DiagnosticId.UnnecessaryParenthesis, DiagnosticSeverity.Warning }, + { DiagnosticId.SwitchToAutoProp, DiagnosticSeverity.Info }, + { DiagnosticId.ExistenceOperator, DiagnosticSeverity.Info }, + { DiagnosticId.ConvertToSwitch, DiagnosticSeverity.Info }, + { DiagnosticId.ConvertLambdaExpressionToMethodGroup, DiagnosticSeverity.Hidden }, + { DiagnosticId.NameOf, DiagnosticSeverity.Warning }, + { DiagnosticId.DisposableVariableNotDisposed, DiagnosticSeverity.Warning }, + { DiagnosticId.SealedAttribute, DiagnosticSeverity.Warning }, + { DiagnosticId.StaticConstructorException, DiagnosticSeverity.Warning }, + { DiagnosticId.EmptyFinalizer, DiagnosticSeverity.Warning }, + { DiagnosticId.CallExtensionMethodAsExtension, DiagnosticSeverity.Info }, + { DiagnosticId.DisposablesShouldCallSuppressFinalize, DiagnosticSeverity.Warning }, + { DiagnosticId.MakeLocalVariableConstWhenItIsPossible, DiagnosticSeverity.Info }, + { DiagnosticId.UseInvokeMethodToFireEvent, DiagnosticSeverity.Warning }, + { DiagnosticId.DisposableFieldNotDisposed_Returned, DiagnosticSeverity.Info }, + { DiagnosticId.DisposableFieldNotDisposed_Created, DiagnosticSeverity.Warning }, + { DiagnosticId.AllowMembersOrdering, DiagnosticSeverity.Hidden }, + { DiagnosticId.RedundantFieldAssignment, DiagnosticSeverity.Info }, + { DiagnosticId.RemoveCommentedCode, DiagnosticSeverity.Info }, + { DiagnosticId.ConvertToExpressionBodiedMember, DiagnosticSeverity.Hidden }, + { DiagnosticId.StringBuilderInLoop, DiagnosticSeverity.Warning }, + { DiagnosticId.InvertFor, DiagnosticSeverity.Hidden }, + { DiagnosticId.ChangeAnyToAll, DiagnosticSeverity.Hidden }, + { DiagnosticId.ParameterRefactory, DiagnosticSeverity.Hidden }, + { DiagnosticId.StringRepresentation_RegularString, DiagnosticSeverity.Hidden }, + { DiagnosticId.StringRepresentation_VerbatimString, DiagnosticSeverity.Hidden }, + { DiagnosticId.PropertyPrivateSet, DiagnosticSeverity.Hidden }, + { DiagnosticId.StringFormat, DiagnosticSeverity.Info }, + { DiagnosticId.SimplifyRedundantBooleanComparisons, DiagnosticSeverity.Info }, + { DiagnosticId.ReadonlyField, DiagnosticSeverity.Info }, + { DiagnosticId.JsonNet, DiagnosticSeverity.Error }, + { DiagnosticId.StringFormatArgs_InvalidArgs, DiagnosticSeverity.Error }, + { DiagnosticId.UnusedParameters, DiagnosticSeverity.Warning }, + { DiagnosticId.AbstractClassShouldNotHavePublicCtors, DiagnosticSeverity.Warning }, + { DiagnosticId.TaskNameAsync, DiagnosticSeverity.Info }, + { DiagnosticId.InterfaceName, DiagnosticSeverity.Info }, + { DiagnosticId.Uri, DiagnosticSeverity.Error }, + { DiagnosticId.IPAddress, DiagnosticSeverity.Error }, + { DiagnosticId.RemoveTrailingWhitespace, DiagnosticSeverity.Info }, + { DiagnosticId.VirtualMethodOnConstructor, DiagnosticSeverity.Warning }, + { DiagnosticId.RemovePrivateMethodNeverUsed, DiagnosticSeverity.Info }, + { DiagnosticId.UseConfigureAwaitFalse, DiagnosticSeverity.Hidden }, + { DiagnosticId.IntroduceFieldFromConstructor, DiagnosticSeverity.Hidden }, + { DiagnosticId.RemoveAsyncFromMethod, DiagnosticSeverity.Info }, + { DiagnosticId.AddBracesToSwitchSections, DiagnosticSeverity.Hidden }, + { DiagnosticId.NoPrivateReadonlyField, DiagnosticSeverity.Info }, + { DiagnosticId.MergeNestedIf, DiagnosticSeverity.Hidden }, + { DiagnosticId.SplitIntoNestedIf, DiagnosticSeverity.Hidden }, + { DiagnosticId.NumericLiteral, DiagnosticSeverity.Hidden }, + { DiagnosticId.TernaryOperator_Iif, DiagnosticSeverity.Warning }, + { DiagnosticId.UseStaticRegexIsMatch, DiagnosticSeverity.Info }, + { DiagnosticId.ComputeExpression, DiagnosticSeverity.Hidden }, + { DiagnosticId.UseStringEmpty, DiagnosticSeverity.Hidden }, + { DiagnosticId.UseEmptyString, DiagnosticSeverity.Hidden }, + { DiagnosticId.RemoveRedundantElseClause, DiagnosticSeverity.Info }, + { DiagnosticId.XmlDocumentation_MissingInCSharp, DiagnosticSeverity.Info }, + { DiagnosticId.MakeMethodStatic, DiagnosticSeverity.Warning }, + { DiagnosticId.ChangeAllToAny, DiagnosticSeverity.Hidden }, + { DiagnosticId.ConsoleWriteLine, DiagnosticSeverity.Info }, + { DiagnosticId.XmlDocumentation_MissingInXml, DiagnosticSeverity.Warning }, + { DiagnosticId.NameOf_External, DiagnosticSeverity.Warning }, + { DiagnosticId.StringFormatArgs_ExtraArgs, DiagnosticSeverity.Warning }, + { DiagnosticId.AlwaysUseVarOnPrimitives, DiagnosticSeverity.Warning }, + { DiagnosticId.PropertyChangedEventArgsUnnecessaryAllocation, DiagnosticSeverity.Hidden }, + { DiagnosticId.UnnecessaryToStringInStringConcatenation, DiagnosticSeverity.Info }, + { DiagnosticId.SwitchCaseWithoutDefault, DiagnosticSeverity.Warning }, + { DiagnosticId.ReadOnlyComplexTypes, DiagnosticSeverity.Warning }, + { DiagnosticId.ReplaceWithGetterOnlyAutoProperty, DiagnosticSeverity.Hidden }, + }; + _diagnosticServerities = new ConcurrentDictionary(values); + } + + public DiagnosticSeverity this[DiagnosticId id] + => _diagnosticServerities.TryGetValue(id, out var value) + ? value + : DiagnosticSeverity.Warning; + } +} From 3ce813a28f37c295075fb963f26f94ca858fe494 Mon Sep 17 00:00:00 2001 From: walterlv Date: Fri, 30 Aug 2019 12:16:07 +0800 Subject: [PATCH 2/6] Let all csharp analyzers use the configuration rulesets. --- src/CSharp/CodeCracker/Design/CatchEmptyAnalyzer.cs | 2 +- src/CSharp/CodeCracker/Design/EmptyCatchBlockAnalyzer.cs | 2 +- src/CSharp/CodeCracker/Design/MakeMethodStaticAnalyzer.cs | 5 +++-- src/CSharp/CodeCracker/Design/NameOfAnalyzer.cs | 7 ++++--- .../Design/StaticConstructorExceptionAnalyzer.cs | 5 +++-- .../CodeCracker/Design/SwitchWithoutDefaultAnalyzer.cs | 6 +++--- .../Design/UseInvokeMethodToFireEventAnalyzer.cs | 5 +++-- .../Maintainability/XmlDocumentationAnalyzer.cs | 7 ++++--- .../CodeCracker/Performance/EmptyFinalizerAnalyzer.cs | 5 +++-- .../MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs | 5 +++-- .../Performance/RemoveWhereWhenItIsPossibleAnalyzer.cs | 4 ++-- .../CodeCracker/Performance/SealedAttributeAnalyzer.cs | 4 ++-- .../CodeCracker/Performance/StringBuilderInLoopAnalyzer.cs | 3 ++- .../Performance/UseStaticRegexIsMatchAnalyzer.cs | 4 ++-- .../Refactoring/AddBracesToSwitchSectionsAnalyzer.cs | 4 ++-- .../Refactoring/AllowMembersOrderingAnalyzer.cs | 4 ++-- .../CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.cs | 4 ++-- .../CodeCracker/Refactoring/ComputeExpressionAnalyzer.cs | 3 ++- .../Refactoring/IntroduceFieldFromConstructorAnalyzer.cs | 5 +++-- src/CSharp/CodeCracker/Refactoring/InvertForAnalyzer.cs | 4 ++-- .../CodeCracker/Refactoring/MergeNestedIfAnalyzer.cs | 4 ++-- .../CodeCracker/Refactoring/NumericLiteralAnalyzer.cs | 2 +- .../CodeCracker/Refactoring/ParameterRefactoryAnalyzer.cs | 5 +++-- ...ropertyChangedEventArgsUnnecessaryAllocationAnalyzer.cs | 5 +++-- .../ReplaceWithGetterOnlyAutoPropertyAnalyzer.cs | 4 ++-- .../CodeCracker/Refactoring/SplitIntoNestedIfAnalyzer.cs | 2 +- .../Refactoring/StringRepresentationAnalyzer.cs | 4 ++-- .../Reliability/UseConfigureAwaitFalseAnalyzer.cs | 4 ++-- src/CSharp/CodeCracker/Style/AlwaysUseVarAnalyzer.cs | 6 +++--- src/CSharp/CodeCracker/Style/ConsoleWriteLineAnalyzer.cs | 2 +- .../Style/ConvertLambdaExpressionToMethodGroupAnalyzer.cs | 4 ++-- .../Style/ConvertToExpressionBodiedMemberAnalyzer.cs | 4 ++-- src/CSharp/CodeCracker/Style/ConvertToSwitchAnalyzer.cs | 4 ++-- .../CodeCracker/Style/EmptyObjectInitializerAnalyzer.cs | 4 ++-- src/CSharp/CodeCracker/Style/ExistenceOperatorAnalyzer.cs | 2 +- src/CSharp/CodeCracker/Style/ForInArrayAnalyzer.cs | 3 ++- src/CSharp/CodeCracker/Style/InterfaceNameAnalyzer.cs | 4 ++-- src/CSharp/CodeCracker/Style/ObjectInitializerAnalyzer.cs | 5 +++-- src/CSharp/CodeCracker/Style/PropertyPrivateSetAnalyzer.cs | 5 +++-- .../CodeCracker/Style/RemoveAsyncFromMethodAnalyzer.cs | 5 +++-- .../CodeCracker/Style/RemoveCommentedCodeAnalyzer.cs | 4 ++-- .../CodeCracker/Style/RemoveTrailingWhitespaceAnalyzer.cs | 4 ++-- src/CSharp/CodeCracker/Style/StringFormatAnalyzer.cs | 3 ++- src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs | 3 ++- src/CSharp/CodeCracker/Style/TaskNameAsyncAnalyzer.cs | 5 +++-- src/CSharp/CodeCracker/Style/TernaryOperatorAnalyzer.cs | 4 ++-- .../CodeCracker/Style/UnnecessaryParenthesisAnalyzer.cs | 4 ++-- .../UnnecessaryToStringInStringConcatenationAnalyzer.cs | 5 +++-- src/CSharp/CodeCracker/Style/UseEmptyStringAnalyzer.cs | 3 ++- src/CSharp/CodeCracker/Style/UseStringEmptyAnalyzer.cs | 5 +++-- .../Usage/AbstractClassShouldNotHavePublicCtorsAnalyzer.cs | 5 +++-- src/CSharp/CodeCracker/Usage/ArgumentExceptionAnalyzer.cs | 2 +- .../Usage/CallExtensionMethodAsExtensionAnalyzer.cs | 5 +++-- .../Usage/DisposableFieldNotDisposedAnalyzer.cs | 5 +++-- .../Usage/DisposableVariableNotDisposedAnalyzer.cs | 3 ++- .../Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.cs | 5 +++-- src/CSharp/CodeCracker/Usage/IPAddressAnalyzer.cs | 4 ++-- src/CSharp/CodeCracker/Usage/IfReturnTrueAnalyzer.cs | 2 +- src/CSharp/CodeCracker/Usage/JsonNetAnalyzer.cs | 4 ++-- .../CodeCracker/Usage/NoPrivateReadonlyFieldAnalyzer.cs | 3 ++- .../CodeCracker/Usage/ReadOnlyComplexTypesAnalyzer.cs | 4 ++-- src/CSharp/CodeCracker/Usage/ReadonlyFieldAnalyzer.cs | 3 ++- .../CodeCracker/Usage/RedundantFieldAssignmentAnalyzer.cs | 3 ++- src/CSharp/CodeCracker/Usage/RegexAnalyzer.cs | 2 +- .../Usage/RemovePrivateMethodNeverUsedAnalyzer.cs | 5 +++-- .../CodeCracker/Usage/RemoveRedundantElseClauseAnalyzer.cs | 4 ++-- src/CSharp/CodeCracker/Usage/RethrowExceptionAnalyzer.cs | 2 +- .../Usage/SimplifyRedundantBooleanComparisonsAnalyzer.cs | 4 ++-- src/CSharp/CodeCracker/Usage/StringFormatArgsAnalyzer.cs | 4 ++-- src/CSharp/CodeCracker/Usage/UnusedParametersAnalyzer.cs | 3 ++- src/CSharp/CodeCracker/Usage/UriAnalyzer.cs | 4 ++-- .../Usage/VirtualMethodOnConstructorAnalyzer.cs | 4 ++-- 72 files changed, 159 insertions(+), 127 deletions(-) diff --git a/src/CSharp/CodeCracker/Design/CatchEmptyAnalyzer.cs b/src/CSharp/CodeCracker/Design/CatchEmptyAnalyzer.cs index 82e455d7f..6e5ec175a 100644 --- a/src/CSharp/CodeCracker/Design/CatchEmptyAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/CatchEmptyAnalyzer.cs @@ -18,7 +18,7 @@ public class CatchEmptyAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.CatchEmpty], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.CatchEmpty)); diff --git a/src/CSharp/CodeCracker/Design/EmptyCatchBlockAnalyzer.cs b/src/CSharp/CodeCracker/Design/EmptyCatchBlockAnalyzer.cs index f77e42f85..03b20c7fb 100644 --- a/src/CSharp/CodeCracker/Design/EmptyCatchBlockAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/EmptyCatchBlockAnalyzer.cs @@ -20,7 +20,7 @@ public class EmptyCatchBlockAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.EmptyCatchBlock], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.EmptyCatchBlock)); diff --git a/src/CSharp/CodeCracker/Design/MakeMethodStaticAnalyzer.cs b/src/CSharp/CodeCracker/Design/MakeMethodStaticAnalyzer.cs index a5fecd666..2974a4fc9 100644 --- a/src/CSharp/CodeCracker/Design/MakeMethodStaticAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/MakeMethodStaticAnalyzer.cs @@ -1,10 +1,11 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; using System.Linq; using System.Collections.Immutable; using System; +using CodeCracker; namespace CodeCracker.CSharp.Design { @@ -23,7 +24,7 @@ public class MakeMethodStaticAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.MakeMethodStatic], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.MakeMethodStatic)); diff --git a/src/CSharp/CodeCracker/Design/NameOfAnalyzer.cs b/src/CSharp/CodeCracker/Design/NameOfAnalyzer.cs index 1631dc9f9..be38c817f 100644 --- a/src/CSharp/CodeCracker/Design/NameOfAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/NameOfAnalyzer.cs @@ -1,4 +1,5 @@ -using CodeCracker.Properties; +using CodeCracker; +using CodeCracker.Properties; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class NameOfAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.NameOf], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NameOf)); @@ -30,7 +31,7 @@ public class NameOfAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.NameOf_External], isEnabledByDefault: false, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NameOf_External)); diff --git a/src/CSharp/CodeCracker/Design/StaticConstructorExceptionAnalyzer.cs b/src/CSharp/CodeCracker/Design/StaticConstructorExceptionAnalyzer.cs index c8a9f2f23..550b5eb41 100644 --- a/src/CSharp/CodeCracker/Design/StaticConstructorExceptionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/StaticConstructorExceptionAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -21,7 +22,7 @@ public class StaticConstructorExceptionAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.StaticConstructorException], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StaticConstructorException)); diff --git a/src/CSharp/CodeCracker/Design/SwitchWithoutDefaultAnalyzer.cs b/src/CSharp/CodeCracker/Design/SwitchWithoutDefaultAnalyzer.cs index 82a31165c..cdc1839cb 100644 --- a/src/CSharp/CodeCracker/Design/SwitchWithoutDefaultAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/SwitchWithoutDefaultAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; using System; using System.Collections.Generic; @@ -8,7 +8,7 @@ using System.Collections.Immutable; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; - +using CodeCracker; namespace CodeCracker.CSharp.Design { @@ -23,7 +23,7 @@ public class SwitchWithoutDefaultAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.SwitchCaseWithoutDefault], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SwitchCaseWithoutDefault)); diff --git a/src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs b/src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs index 6a30e2533..2b73f2445 100644 --- a/src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -23,7 +24,7 @@ public class UseInvokeMethodToFireEventAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.UseInvokeMethodToFireEvent], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseInvokeMethodToFireEvent)); diff --git a/src/CSharp/CodeCracker/Maintainability/XmlDocumentationAnalyzer.cs b/src/CSharp/CodeCracker/Maintainability/XmlDocumentationAnalyzer.cs index 5f987fddb..6919b5991 100644 --- a/src/CSharp/CodeCracker/Maintainability/XmlDocumentationAnalyzer.cs +++ b/src/CSharp/CodeCracker/Maintainability/XmlDocumentationAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -6,6 +6,7 @@ using System.Collections.Immutable; using System.Linq; using CodeCracker.Properties; +using CodeCracker; namespace CodeCracker.CSharp.Maintainability { @@ -19,7 +20,7 @@ public sealed class XmlDocumentationAnalyzer : DiagnosticAnalyzer Title, Title, SupportedCategories.Maintainability, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.XmlDocumentation_MissingInCSharp], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.XmlDocumentation_MissingInCSharp)); @@ -28,7 +29,7 @@ public sealed class XmlDocumentationAnalyzer : DiagnosticAnalyzer Title, Title, SupportedCategories.Maintainability, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.XmlDocumentation_MissingInXml], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.XmlDocumentation_MissingInXml)); diff --git a/src/CSharp/CodeCracker/Performance/EmptyFinalizerAnalyzer.cs b/src/CSharp/CodeCracker/Performance/EmptyFinalizerAnalyzer.cs index cd5a4f333..ee72e991c 100644 --- a/src/CSharp/CodeCracker/Performance/EmptyFinalizerAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/EmptyFinalizerAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -22,7 +23,7 @@ public class EmptyFinalizerAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.EmptyFinalizer], true, customTags: WellKnownDiagnosticTags.Unnecessary, description: Description, diff --git a/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs b/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs index f49aba20a..28febb209 100644 --- a/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -20,7 +21,7 @@ public class MakeLocalVariableConstWhenItIsPossibleAnalyzer : Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.MakeLocalVariableConstWhenItIsPossible], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.MakeLocalVariableConstWhenItIsPossible)); diff --git a/src/CSharp/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.cs b/src/CSharp/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.cs index 9ba262a53..8b46da0a8 100644 --- a/src/CSharp/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -41,7 +41,7 @@ public class RemoveWhereWhenItIsPossibleAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.RemoveWhereWhenItIsPossible], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveWhereWhenItIsPossible)); diff --git a/src/CSharp/CodeCracker/Performance/SealedAttributeAnalyzer.cs b/src/CSharp/CodeCracker/Performance/SealedAttributeAnalyzer.cs index dc4cf7553..6533b01f9 100644 --- a/src/CSharp/CodeCracker/Performance/SealedAttributeAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/SealedAttributeAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; using System; using System.Collections.Immutable; @@ -19,7 +19,7 @@ public class SealedAttributeAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.SealedAttribute], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SealedAttribute)); diff --git a/src/CSharp/CodeCracker/Performance/StringBuilderInLoopAnalyzer.cs b/src/CSharp/CodeCracker/Performance/StringBuilderInLoopAnalyzer.cs index 60960be01..6a07b4f3d 100644 --- a/src/CSharp/CodeCracker/Performance/StringBuilderInLoopAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/StringBuilderInLoopAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class StringBuilderInLoopAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.StringBuilderInLoop], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringBuilderInLoop)); diff --git a/src/CSharp/CodeCracker/Performance/UseStaticRegexIsMatchAnalyzer.cs b/src/CSharp/CodeCracker/Performance/UseStaticRegexIsMatchAnalyzer.cs index 19c4e2374..a8dcdb5d7 100644 --- a/src/CSharp/CodeCracker/Performance/UseStaticRegexIsMatchAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/UseStaticRegexIsMatchAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -20,7 +20,7 @@ public class UseStaticRegexIsMatchAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.UseStaticRegexIsMatch], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseStaticRegexIsMatch)); diff --git a/src/CSharp/CodeCracker/Refactoring/AddBracesToSwitchSectionsAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/AddBracesToSwitchSectionsAnalyzer.cs index 6ef64c506..857d5cb2e 100644 --- a/src/CSharp/CodeCracker/Refactoring/AddBracesToSwitchSectionsAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/AddBracesToSwitchSectionsAnalyzer.cs @@ -1,4 +1,4 @@ -using System.Collections.Immutable; +using System.Collections.Immutable; using System.Linq; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; @@ -19,7 +19,7 @@ public class AddBracesToSwitchSectionsAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.AddBracesToSwitchSections], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AddBracesToSwitchSections)); diff --git a/src/CSharp/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.cs index eda3b461a..a040d71eb 100644 --- a/src/CSharp/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -18,7 +18,7 @@ public class AllowMembersOrderingAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.AllowMembersOrdering], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AllowMembersOrdering)); diff --git a/src/CSharp/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.cs index 8e52451bb..8fe62fc8e 100644 --- a/src/CSharp/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.cs @@ -23,7 +23,7 @@ public class ChangeAnyToAllAnalyzer : DiagnosticAnalyzer TitleAny, MessageAny, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.ChangeAnyToAll], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ChangeAnyToAll)); internal static readonly DiagnosticDescriptor RuleAll = new DiagnosticDescriptor( @@ -31,7 +31,7 @@ public class ChangeAnyToAllAnalyzer : DiagnosticAnalyzer TitleAll, MessageAll, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.ChangeAllToAny], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ChangeAllToAny)); diff --git a/src/CSharp/CodeCracker/Refactoring/ComputeExpressionAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/ComputeExpressionAnalyzer.cs index 63224cd90..93c0b6e67 100644 --- a/src/CSharp/CodeCracker/Refactoring/ComputeExpressionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/ComputeExpressionAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -20,7 +21,7 @@ public class ComputeExpressionAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.ComputeExpression], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ComputeExpression)); diff --git a/src/CSharp/CodeCracker/Refactoring/IntroduceFieldFromConstructorAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/IntroduceFieldFromConstructorAnalyzer.cs index 7b20fe932..bb13003a5 100644 --- a/src/CSharp/CodeCracker/Refactoring/IntroduceFieldFromConstructorAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/IntroduceFieldFromConstructorAnalyzer.cs @@ -1,4 +1,5 @@ -using CodeCracker.Properties; +using CodeCracker; +using CodeCracker.Properties; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -22,7 +23,7 @@ public class IntroduceFieldFromConstructorAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.IntroduceFieldFromConstructor], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.IntroduceFieldFromConstructor)); diff --git a/src/CSharp/CodeCracker/Refactoring/InvertForAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/InvertForAnalyzer.cs index 75dc49e56..b3aab8a90 100644 --- a/src/CSharp/CodeCracker/Refactoring/InvertForAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/InvertForAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -18,7 +18,7 @@ public class InvertForAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.InvertFor], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.InvertFor)); diff --git a/src/CSharp/CodeCracker/Refactoring/MergeNestedIfAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/MergeNestedIfAnalyzer.cs index e4ffa333b..5575c5ed7 100644 --- a/src/CSharp/CodeCracker/Refactoring/MergeNestedIfAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/MergeNestedIfAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -18,7 +18,7 @@ public class MergeNestedIfAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.MergeNestedIf], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.MergeNestedIf)); diff --git a/src/CSharp/CodeCracker/Refactoring/NumericLiteralAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/NumericLiteralAnalyzer.cs index f60caa320..ee5c2e225 100644 --- a/src/CSharp/CodeCracker/Refactoring/NumericLiteralAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/NumericLiteralAnalyzer.cs @@ -18,7 +18,7 @@ public class NumericLiteralAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.NumericLiteral], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NumericLiteral)); diff --git a/src/CSharp/CodeCracker/Refactoring/ParameterRefactoryAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/ParameterRefactoryAnalyzer.cs index f113c416e..7ca6af87e 100644 --- a/src/CSharp/CodeCracker/Refactoring/ParameterRefactoryAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/ParameterRefactoryAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +20,7 @@ public class ParameterRefactoryAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.ParameterRefactory], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ParameterRefactory)); diff --git a/src/CSharp/CodeCracker/Refactoring/PropertyChangedEventArgsUnnecessaryAllocationAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/PropertyChangedEventArgsUnnecessaryAllocationAnalyzer.cs index a3f061c3e..90f782a4f 100644 --- a/src/CSharp/CodeCracker/Refactoring/PropertyChangedEventArgsUnnecessaryAllocationAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/PropertyChangedEventArgsUnnecessaryAllocationAnalyzer.cs @@ -1,4 +1,5 @@ -using CodeCracker.Properties; +using CodeCracker; +using CodeCracker.Properties; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -33,7 +34,7 @@ public sealed class PropertyChangedEventArgsUnnecessaryAllocationAnalyzer : Diag Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.PropertyChangedEventArgsUnnecessaryAllocation], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.PropertyChangedEventArgsUnnecessaryAllocation)); diff --git a/src/CSharp/CodeCracker/Refactoring/ReplaceWithGetterOnlyAutoPropertyAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/ReplaceWithGetterOnlyAutoPropertyAnalyzer.cs index cc8b4ef13..9e9f145f0 100644 --- a/src/CSharp/CodeCracker/Refactoring/ReplaceWithGetterOnlyAutoPropertyAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/ReplaceWithGetterOnlyAutoPropertyAnalyzer.cs @@ -1,4 +1,4 @@ -using CodeCracker.Properties; +using CodeCracker.Properties; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -22,7 +22,7 @@ public class ReplaceWithGetterOnlyAutoPropertyAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.ReplaceWithGetterOnlyAutoProperty], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ReplaceWithGetterOnlyAutoProperty)); diff --git a/src/CSharp/CodeCracker/Refactoring/SplitIntoNestedIfAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/SplitIntoNestedIfAnalyzer.cs index e37d41246..60f57bdb2 100644 --- a/src/CSharp/CodeCracker/Refactoring/SplitIntoNestedIfAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/SplitIntoNestedIfAnalyzer.cs @@ -18,7 +18,7 @@ public class SplitIntoNestedIfAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.SplitIntoNestedIf], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SplitIntoNestedIf)); diff --git a/src/CSharp/CodeCracker/Refactoring/StringRepresentationAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/StringRepresentationAnalyzer.cs index 3c7bbd8a3..ce6cabe46 100644 --- a/src/CSharp/CodeCracker/Refactoring/StringRepresentationAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/StringRepresentationAnalyzer.cs @@ -16,7 +16,7 @@ public class StringRepresentationAnalyzer : DiagnosticAnalyzer "Regular string", "Change to regular string", SupportedCategories.Refactoring, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.StringRepresentation_RegularString], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringRepresentation_RegularString)); @@ -25,7 +25,7 @@ public class StringRepresentationAnalyzer : DiagnosticAnalyzer "Verbatim string", "Change to verbatim string", SupportedCategories.Refactoring, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.StringRepresentation_VerbatimString], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringRepresentation_VerbatimString)); diff --git a/src/CSharp/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.cs b/src/CSharp/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.cs index 4af4bbf13..ae6f27d6d 100644 --- a/src/CSharp/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.cs +++ b/src/CSharp/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -18,7 +18,7 @@ public class UseConfigureAwaitFalseAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.UseConfigureAwaitFalse], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseConfigureAwaitFalse)); diff --git a/src/CSharp/CodeCracker/Style/AlwaysUseVarAnalyzer.cs b/src/CSharp/CodeCracker/Style/AlwaysUseVarAnalyzer.cs index 7e5c5aab2..f0a33bb05 100644 --- a/src/CSharp/CodeCracker/Style/AlwaysUseVarAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/AlwaysUseVarAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -21,7 +21,7 @@ public class AlwaysUseVarAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.AlwaysUseVar], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AlwaysUseVar)); @@ -31,7 +31,7 @@ public class AlwaysUseVarAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.AlwaysUseVarOnPrimitives], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AlwaysUseVarOnPrimitives)); diff --git a/src/CSharp/CodeCracker/Style/ConsoleWriteLineAnalyzer.cs b/src/CSharp/CodeCracker/Style/ConsoleWriteLineAnalyzer.cs index d9d34cf1c..bf0f08903 100644 --- a/src/CSharp/CodeCracker/Style/ConsoleWriteLineAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ConsoleWriteLineAnalyzer.cs @@ -19,7 +19,7 @@ public class ConsoleWriteLineAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.ConsoleWriteLine], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ConsoleWriteLine)); diff --git a/src/CSharp/CodeCracker/Style/ConvertLambdaExpressionToMethodGroupAnalyzer.cs b/src/CSharp/CodeCracker/Style/ConvertLambdaExpressionToMethodGroupAnalyzer.cs index bb335f76d..e1b068be6 100644 --- a/src/CSharp/CodeCracker/Style/ConvertLambdaExpressionToMethodGroupAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ConvertLambdaExpressionToMethodGroupAnalyzer.cs @@ -1,4 +1,4 @@ -using System.Collections.Immutable; +using System.Collections.Immutable; using System.Linq; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; @@ -20,7 +20,7 @@ public class ConvertLambdaExpressionToMethodGroupAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.ConvertLambdaExpressionToMethodGroup], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ConvertLambdaExpressionToMethodGroup)); diff --git a/src/CSharp/CodeCracker/Style/ConvertToExpressionBodiedMemberAnalyzer.cs b/src/CSharp/CodeCracker/Style/ConvertToExpressionBodiedMemberAnalyzer.cs index ede46efcd..67efa64bd 100644 --- a/src/CSharp/CodeCracker/Style/ConvertToExpressionBodiedMemberAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ConvertToExpressionBodiedMemberAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +19,7 @@ public class ConvertToExpressionBodiedMemberAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.ConvertToExpressionBodiedMember], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ConvertToExpressionBodiedMember)); diff --git a/src/CSharp/CodeCracker/Style/ConvertToSwitchAnalyzer.cs b/src/CSharp/CodeCracker/Style/ConvertToSwitchAnalyzer.cs index 4924daafe..9594b378f 100644 --- a/src/CSharp/CodeCracker/Style/ConvertToSwitchAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ConvertToSwitchAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -22,7 +22,7 @@ public class ConvertToSwitchAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.ConvertToSwitch], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ConvertToSwitch)); diff --git a/src/CSharp/CodeCracker/Style/EmptyObjectInitializerAnalyzer.cs b/src/CSharp/CodeCracker/Style/EmptyObjectInitializerAnalyzer.cs index 1ae23376f..d85d89fb3 100644 --- a/src/CSharp/CodeCracker/Style/EmptyObjectInitializerAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/EmptyObjectInitializerAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +19,7 @@ public class EmptyObjectInitializerAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.EmptyObjectInitializer], isEnabledByDefault: true, customTags: WellKnownDiagnosticTags.Unnecessary, description: Description, diff --git a/src/CSharp/CodeCracker/Style/ExistenceOperatorAnalyzer.cs b/src/CSharp/CodeCracker/Style/ExistenceOperatorAnalyzer.cs index c22b39f18..21c291203 100644 --- a/src/CSharp/CodeCracker/Style/ExistenceOperatorAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ExistenceOperatorAnalyzer.cs @@ -18,7 +18,7 @@ public class ExistenceOperatorAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.ExistenceOperator], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ExistenceOperator)); diff --git a/src/CSharp/CodeCracker/Style/ForInArrayAnalyzer.cs b/src/CSharp/CodeCracker/Style/ForInArrayAnalyzer.cs index d76eee1d0..6277675fb 100644 --- a/src/CSharp/CodeCracker/Style/ForInArrayAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ForInArrayAnalyzer.cs @@ -6,6 +6,7 @@ using System.Linq; using System; using System.Collections.Generic; +using CodeCracker; namespace CodeCracker.CSharp.Style { @@ -21,7 +22,7 @@ public class ForInArrayAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.ForInArray], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ForInArray)); diff --git a/src/CSharp/CodeCracker/Style/InterfaceNameAnalyzer.cs b/src/CSharp/CodeCracker/Style/InterfaceNameAnalyzer.cs index 4cce637cd..e343ba19c 100644 --- a/src/CSharp/CodeCracker/Style/InterfaceNameAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/InterfaceNameAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +19,7 @@ public class InterfaceNameAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.InterfaceName], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.InterfaceName)); diff --git a/src/CSharp/CodeCracker/Style/ObjectInitializerAnalyzer.cs b/src/CSharp/CodeCracker/Style/ObjectInitializerAnalyzer.cs index 4e67acf8b..76118d566 100644 --- a/src/CSharp/CodeCracker/Style/ObjectInitializerAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ObjectInitializerAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -23,7 +24,7 @@ public class ObjectInitializerAnalyzer : DiagnosticAnalyzer TitleLocalDeclaration, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.ObjectInitializer_Assignment], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ObjectInitializer_Assignment)); @@ -33,7 +34,7 @@ public class ObjectInitializerAnalyzer : DiagnosticAnalyzer TitleLocalDeclaration, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.ObjectInitializer_LocalDeclaration], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ObjectInitializer_LocalDeclaration)); diff --git a/src/CSharp/CodeCracker/Style/PropertyPrivateSetAnalyzer.cs b/src/CSharp/CodeCracker/Style/PropertyPrivateSetAnalyzer.cs index 093a20c9d..a728b7f38 100644 --- a/src/CSharp/CodeCracker/Style/PropertyPrivateSetAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/PropertyPrivateSetAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +20,7 @@ public class PropertyPrivateSetAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.PropertyPrivateSet], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.PropertyPrivateSet)); diff --git a/src/CSharp/CodeCracker/Style/RemoveAsyncFromMethodAnalyzer.cs b/src/CSharp/CodeCracker/Style/RemoveAsyncFromMethodAnalyzer.cs index 8d68344e1..0f6e4634c 100644 --- a/src/CSharp/CodeCracker/Style/RemoveAsyncFromMethodAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/RemoveAsyncFromMethodAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -20,7 +21,7 @@ public class RemoveAsyncFromMethodAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.RemoveAsyncFromMethod], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveAsyncFromMethod)); diff --git a/src/CSharp/CodeCracker/Style/RemoveCommentedCodeAnalyzer.cs b/src/CSharp/CodeCracker/Style/RemoveCommentedCodeAnalyzer.cs index a25c49944..838795de7 100644 --- a/src/CSharp/CodeCracker/Style/RemoveCommentedCodeAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/RemoveCommentedCodeAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.Diagnostics; using Microsoft.CodeAnalysis.Text; @@ -19,7 +19,7 @@ public class RemoveCommentedCodeAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.RemoveCommentedCode], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveCommentedCode)); diff --git a/src/CSharp/CodeCracker/Style/RemoveTrailingWhitespaceAnalyzer.cs b/src/CSharp/CodeCracker/Style/RemoveTrailingWhitespaceAnalyzer.cs index e34368cda..f7dbf1028 100644 --- a/src/CSharp/CodeCracker/Style/RemoveTrailingWhitespaceAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/RemoveTrailingWhitespaceAnalyzer.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Collections.Immutable; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.Diagnostics; @@ -21,7 +21,7 @@ public class RemoveTrailingWhitespaceAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.RemoveTrailingWhitespace], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveTrailingWhitespace)); diff --git a/src/CSharp/CodeCracker/Style/StringFormatAnalyzer.cs b/src/CSharp/CodeCracker/Style/StringFormatAnalyzer.cs index 55a9a819a..dba6b5a16 100644 --- a/src/CSharp/CodeCracker/Style/StringFormatAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/StringFormatAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using CodeCracker.Properties; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; @@ -22,7 +23,7 @@ public class StringFormatAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.StringFormat], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringFormat)); diff --git a/src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs b/src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs index a51c2dff6..02fac7075 100644 --- a/src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using CodeCracker.Properties; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; @@ -22,7 +23,7 @@ public class SwitchToAutoPropAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.SwitchToAutoProp], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SwitchToAutoProp)); diff --git a/src/CSharp/CodeCracker/Style/TaskNameAsyncAnalyzer.cs b/src/CSharp/CodeCracker/Style/TaskNameAsyncAnalyzer.cs index 160d792e2..7c27fbc39 100644 --- a/src/CSharp/CodeCracker/Style/TaskNameAsyncAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/TaskNameAsyncAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -20,7 +21,7 @@ public class TaskNameAsyncAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.TaskNameAsync], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.TaskNameAsync)); diff --git a/src/CSharp/CodeCracker/Style/TernaryOperatorAnalyzer.cs b/src/CSharp/CodeCracker/Style/TernaryOperatorAnalyzer.cs index 0b53d35e5..b5aaebf25 100644 --- a/src/CSharp/CodeCracker/Style/TernaryOperatorAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/TernaryOperatorAnalyzer.cs @@ -20,7 +20,7 @@ public class TernaryOperatorAnalyzer : DiagnosticAnalyzer Title, MessageFormatForIfWithReturn, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.TernaryOperator_Return], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Return)); @@ -29,7 +29,7 @@ public class TernaryOperatorAnalyzer : DiagnosticAnalyzer Title, MessageFormatForIfWithAssignment, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.TernaryOperator_Assignment], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Assignment)); diff --git a/src/CSharp/CodeCracker/Style/UnnecessaryParenthesisAnalyzer.cs b/src/CSharp/CodeCracker/Style/UnnecessaryParenthesisAnalyzer.cs index 410eb60be..3a03cd0de 100644 --- a/src/CSharp/CodeCracker/Style/UnnecessaryParenthesisAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/UnnecessaryParenthesisAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -20,7 +20,7 @@ public class UnnecessaryParenthesisAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.UnnecessaryParenthesis], customTags: WellKnownDiagnosticTags.Unnecessary, isEnabledByDefault: true, description: Description, diff --git a/src/CSharp/CodeCracker/Style/UnnecessaryToStringInStringConcatenationAnalyzer.cs b/src/CSharp/CodeCracker/Style/UnnecessaryToStringInStringConcatenationAnalyzer.cs index 20bc013e4..dd59fedc6 100644 --- a/src/CSharp/CodeCracker/Style/UnnecessaryToStringInStringConcatenationAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/UnnecessaryToStringInStringConcatenationAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -25,7 +26,7 @@ public class UnnecessaryToStringInStringConcatenationAnalyzer : DiagnosticAnalyz Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.UnnecessaryToStringInStringConcatenation], customTags: WellKnownDiagnosticTags.Unnecessary, isEnabledByDefault: true, description: Description, diff --git a/src/CSharp/CodeCracker/Style/UseEmptyStringAnalyzer.cs b/src/CSharp/CodeCracker/Style/UseEmptyStringAnalyzer.cs index cfba91fb3..c4c9326f3 100644 --- a/src/CSharp/CodeCracker/Style/UseEmptyStringAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/UseEmptyStringAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -23,7 +24,7 @@ public class UseEmptyStringAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.UseEmptyString], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseEmptyString)); diff --git a/src/CSharp/CodeCracker/Style/UseStringEmptyAnalyzer.cs b/src/CSharp/CodeCracker/Style/UseStringEmptyAnalyzer.cs index 0edc4fe64..0c73c25c3 100644 --- a/src/CSharp/CodeCracker/Style/UseStringEmptyAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/UseStringEmptyAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +20,7 @@ public class UseStringEmptyAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current[DiagnosticId.UseStringEmpty], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseStringEmpty)); diff --git a/src/CSharp/CodeCracker/Usage/AbstractClassShouldNotHavePublicCtorsAnalyzer.cs b/src/CSharp/CodeCracker/Usage/AbstractClassShouldNotHavePublicCtorsAnalyzer.cs index 273f37ee7..93170d37f 100644 --- a/src/CSharp/CodeCracker/Usage/AbstractClassShouldNotHavePublicCtorsAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/AbstractClassShouldNotHavePublicCtorsAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +20,7 @@ public class AbstractClassShouldNotHavePublicCtorsAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.AbstractClassShouldNotHavePublicCtors], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AbstractClassShouldNotHavePublicCtors)); diff --git a/src/CSharp/CodeCracker/Usage/ArgumentExceptionAnalyzer.cs b/src/CSharp/CodeCracker/Usage/ArgumentExceptionAnalyzer.cs index b2a1daa96..ebacc8642 100644 --- a/src/CSharp/CodeCracker/Usage/ArgumentExceptionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/ArgumentExceptionAnalyzer.cs @@ -22,7 +22,7 @@ public class ArgumentExceptionAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.ArgumentException], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ArgumentException)); diff --git a/src/CSharp/CodeCracker/Usage/CallExtensionMethodAsExtensionAnalyzer.cs b/src/CSharp/CodeCracker/Usage/CallExtensionMethodAsExtensionAnalyzer.cs index 0a6f14de5..e7ff75e7f 100644 --- a/src/CSharp/CodeCracker/Usage/CallExtensionMethodAsExtensionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/CallExtensionMethodAsExtensionAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Extensions; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class CallExtensionMethodAsExtensionAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.CallExtensionMethodAsExtension], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.CallExtensionMethodAsExtension)); diff --git a/src/CSharp/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.cs b/src/CSharp/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.cs index b90b12001..e1a9a1fd2 100644 --- a/src/CSharp/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class DisposableFieldNotDisposedAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.DisposableFieldNotDisposed_Returned], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.DisposableFieldNotDisposed_Returned)); @@ -30,7 +31,7 @@ public class DisposableFieldNotDisposedAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.DisposableFieldNotDisposed_Created], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.DisposableFieldNotDisposed_Created)); diff --git a/src/CSharp/CodeCracker/Usage/DisposableVariableNotDisposedAnalyzer.cs b/src/CSharp/CodeCracker/Usage/DisposableVariableNotDisposedAnalyzer.cs index 3ed958b5f..b39eb9544 100644 --- a/src/CSharp/CodeCracker/Usage/DisposableVariableNotDisposedAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/DisposableVariableNotDisposedAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -22,7 +23,7 @@ public class DisposableVariableNotDisposedAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.DisposableVariableNotDisposed], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.DisposableVariableNotDisposed)); diff --git a/src/CSharp/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.cs b/src/CSharp/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.cs index b70f8d735..b89397295 100644 --- a/src/CSharp/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.cs @@ -1,10 +1,11 @@ -using System; +using System; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; using System.Collections.Immutable; using System.Linq; using Microsoft.CodeAnalysis.CSharp; +using CodeCracker; namespace CodeCracker.CSharp.Usage { @@ -22,7 +23,7 @@ public class DisposablesShouldCallSuppressFinalizeAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.DisposablesShouldCallSuppressFinalize], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.DisposablesShouldCallSuppressFinalize)); diff --git a/src/CSharp/CodeCracker/Usage/IPAddressAnalyzer.cs b/src/CSharp/CodeCracker/Usage/IPAddressAnalyzer.cs index ba2b3b03b..27d4a6329 100644 --- a/src/CSharp/CodeCracker/Usage/IPAddressAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/IPAddressAnalyzer.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Collections.Immutable; using System.Reflection; using CodeCracker.CSharp.Usage.MethodAnalyzers; @@ -23,7 +23,7 @@ public class IPAddressAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Error, + SeverityConfigurations.Current[DiagnosticId.IPAddress], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.IPAddress)); diff --git a/src/CSharp/CodeCracker/Usage/IfReturnTrueAnalyzer.cs b/src/CSharp/CodeCracker/Usage/IfReturnTrueAnalyzer.cs index c03121553..c62462f7d 100644 --- a/src/CSharp/CodeCracker/Usage/IfReturnTrueAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/IfReturnTrueAnalyzer.cs @@ -19,7 +19,7 @@ public class IfReturnTrueAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.IfReturnTrue], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.IfReturnTrue)); diff --git a/src/CSharp/CodeCracker/Usage/JsonNetAnalyzer.cs b/src/CSharp/CodeCracker/Usage/JsonNetAnalyzer.cs index d69c802dc..925b88aec 100644 --- a/src/CSharp/CodeCracker/Usage/JsonNetAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/JsonNetAnalyzer.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Collections.Immutable; using System.Reflection; using Microsoft.CodeAnalysis; @@ -22,7 +22,7 @@ public class JsonNetAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Error, + SeverityConfigurations.Current[DiagnosticId.JsonNet], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.JsonNet)); diff --git a/src/CSharp/CodeCracker/Usage/NoPrivateReadonlyFieldAnalyzer.cs b/src/CSharp/CodeCracker/Usage/NoPrivateReadonlyFieldAnalyzer.cs index f87394915..5911228b0 100644 --- a/src/CSharp/CodeCracker/Usage/NoPrivateReadonlyFieldAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/NoPrivateReadonlyFieldAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class NoPrivateReadonlyFieldAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.NoPrivateReadonlyField], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NoPrivateReadonlyField)); diff --git a/src/CSharp/CodeCracker/Usage/ReadOnlyComplexTypesAnalyzer.cs b/src/CSharp/CodeCracker/Usage/ReadOnlyComplexTypesAnalyzer.cs index 089013936..0a0835cad 100644 --- a/src/CSharp/CodeCracker/Usage/ReadOnlyComplexTypesAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/ReadOnlyComplexTypesAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -22,7 +22,7 @@ public class ReadOnlyComplexTypesAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.ReadOnlyComplexTypes], isEnabledByDefault: false, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ReadOnlyComplexTypes)); diff --git a/src/CSharp/CodeCracker/Usage/ReadonlyFieldAnalyzer.cs b/src/CSharp/CodeCracker/Usage/ReadonlyFieldAnalyzer.cs index 1fa957957..60c9acf4a 100644 --- a/src/CSharp/CodeCracker/Usage/ReadonlyFieldAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/ReadonlyFieldAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class ReadonlyFieldAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.ReadonlyField], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ReadonlyField)); diff --git a/src/CSharp/CodeCracker/Usage/RedundantFieldAssignmentAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RedundantFieldAssignmentAnalyzer.cs index 7791f70cb..780858873 100644 --- a/src/CSharp/CodeCracker/Usage/RedundantFieldAssignmentAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RedundantFieldAssignmentAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class RedundantFieldAssignmentAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.RedundantFieldAssignment], isEnabledByDefault: true, customTags: WellKnownDiagnosticTags.Unnecessary, description: Description, diff --git a/src/CSharp/CodeCracker/Usage/RegexAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RegexAnalyzer.cs index 41393ac96..f9ab98f87 100644 --- a/src/CSharp/CodeCracker/Usage/RegexAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RegexAnalyzer.cs @@ -20,7 +20,7 @@ public class RegexAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Error, + SeverityConfigurations.Current[DiagnosticId.Regex], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.Regex)); diff --git a/src/CSharp/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.cs index 26b80458c..fc15aa3f9 100644 --- a/src/CSharp/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.cs @@ -1,4 +1,5 @@ -using Microsoft.CodeAnalysis; +using CodeCracker; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -23,7 +24,7 @@ public class RemovePrivateMethodNeverUsedAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.RemovePrivateMethodNeverUsed], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemovePrivateMethodNeverUsed)); diff --git a/src/CSharp/CodeCracker/Usage/RemoveRedundantElseClauseAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RemoveRedundantElseClauseAnalyzer.cs index 03294eb66..6573a22c7 100644 --- a/src/CSharp/CodeCracker/Usage/RemoveRedundantElseClauseAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RemoveRedundantElseClauseAnalyzer.cs @@ -1,4 +1,4 @@ -using Microsoft.CodeAnalysis; +using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; using Microsoft.CodeAnalysis.Diagnostics; @@ -19,7 +19,7 @@ public class RemoveRedundantElseClauseAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.RemoveRedundantElseClause], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveRedundantElseClause)); diff --git a/src/CSharp/CodeCracker/Usage/RethrowExceptionAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RethrowExceptionAnalyzer.cs index cf2376d77..086fc30dd 100644 --- a/src/CSharp/CodeCracker/Usage/RethrowExceptionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RethrowExceptionAnalyzer.cs @@ -21,7 +21,7 @@ public class RethrowExceptionAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.RethrowException], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RethrowException)); diff --git a/src/CSharp/CodeCracker/Usage/SimplifyRedundantBooleanComparisonsAnalyzer.cs b/src/CSharp/CodeCracker/Usage/SimplifyRedundantBooleanComparisonsAnalyzer.cs index 0a149d2b5..d0c7b44e6 100644 --- a/src/CSharp/CodeCracker/Usage/SimplifyRedundantBooleanComparisonsAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/SimplifyRedundantBooleanComparisonsAnalyzer.cs @@ -1,4 +1,4 @@ -using System.Collections.Immutable; +using System.Collections.Immutable; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -18,7 +18,7 @@ public class SimplifyRedundantBooleanComparisonsAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current[DiagnosticId.SimplifyRedundantBooleanComparisons], isEnabledByDefault: true, customTags: WellKnownDiagnosticTags.Unnecessary, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SimplifyRedundantBooleanComparisons)); diff --git a/src/CSharp/CodeCracker/Usage/StringFormatArgsAnalyzer.cs b/src/CSharp/CodeCracker/Usage/StringFormatArgsAnalyzer.cs index 3213dfe6c..36aec816e 100644 --- a/src/CSharp/CodeCracker/Usage/StringFormatArgsAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/StringFormatArgsAnalyzer.cs @@ -23,7 +23,7 @@ public class StringFormatArgsAnalyzer : DiagnosticAnalyzer Title, IncorrectNumberOfArgsMessage, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.StringFormatArgs_ExtraArgs], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringFormatArgs_ExtraArgs)); @@ -33,7 +33,7 @@ public class StringFormatArgsAnalyzer : DiagnosticAnalyzer Title, InvalidArgsReferenceMessage, Category, - DiagnosticSeverity.Error, + SeverityConfigurations.Current[DiagnosticId.StringFormatArgs_InvalidArgs], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringFormatArgs_InvalidArgs)); diff --git a/src/CSharp/CodeCracker/Usage/UnusedParametersAnalyzer.cs b/src/CSharp/CodeCracker/Usage/UnusedParametersAnalyzer.cs index db1cbdf65..49236df09 100644 --- a/src/CSharp/CodeCracker/Usage/UnusedParametersAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/UnusedParametersAnalyzer.cs @@ -1,3 +1,4 @@ +using CodeCracker; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.CSharp.Syntax; @@ -21,7 +22,7 @@ public class UnusedParametersAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.UnusedParameters], isEnabledByDefault: true, description: Description, customTags: WellKnownDiagnosticTags.Unnecessary, diff --git a/src/CSharp/CodeCracker/Usage/UriAnalyzer.cs b/src/CSharp/CodeCracker/Usage/UriAnalyzer.cs index 464976212..b3e5e0049 100644 --- a/src/CSharp/CodeCracker/Usage/UriAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/UriAnalyzer.cs @@ -1,4 +1,4 @@ -using CodeCracker.CSharp.Usage.MethodAnalyzers; +using CodeCracker.CSharp.Usage.MethodAnalyzers; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; using Microsoft.CodeAnalysis.Diagnostics; @@ -22,7 +22,7 @@ public class UriAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - DiagnosticSeverity.Error, + SeverityConfigurations.Current[DiagnosticId.Uri], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.Uri)); diff --git a/src/CSharp/CodeCracker/Usage/VirtualMethodOnConstructorAnalyzer.cs b/src/CSharp/CodeCracker/Usage/VirtualMethodOnConstructorAnalyzer.cs index f0d2becef..b1283e7e0 100644 --- a/src/CSharp/CodeCracker/Usage/VirtualMethodOnConstructorAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/VirtualMethodOnConstructorAnalyzer.cs @@ -1,4 +1,4 @@ -using System.Collections.Immutable; +using System.Collections.Immutable; using System.Linq; using Microsoft.CodeAnalysis; using Microsoft.CodeAnalysis.CSharp; @@ -23,7 +23,7 @@ public class VirtualMethodOnConstructorAnalyzer : DiagnosticAnalyzer Title, Message, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current[DiagnosticId.VirtualMethodOnConstructor], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.VirtualMethodOnConstructor)); From e50094f80b4f689cd4c2bf240aabd391196a160e Mon Sep 17 00:00:00 2001 From: walterlv Date: Fri, 30 Aug 2019 12:41:28 +0800 Subject: [PATCH 3/6] Let all vb analyzers use the configuration rulesets. --- src/VisualBasic/CodeCracker/Design/CatchEmptyAnalyzer.vb | 4 ++-- .../CodeCracker/Design/EmptyCatchBlockAnalyzer.vb | 2 +- src/VisualBasic/CodeCracker/Design/NameOfAnalyzer.vb | 6 +++--- .../Design/StaticConstructorExceptionAnalyzer.vb | 4 ++-- .../MakeLocalVariableConstWhenPossibleAnalyzer.vb | 4 ++-- .../Performance/RemoveWhereWhenItIsPossibleAnalyzer.vb | 4 ++-- .../CodeCracker/Performance/SealedAttributeAnalyzer.vb | 4 ++-- .../Performance/StringBuilderInLoopAnalyzer.vb | 4 ++-- .../Refactoring/AllowMembersOrderingAnalyzer.vb | 4 ++-- .../CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.vb | 6 +++--- .../Reliability/UseConfigureAwaitFalseAnalyzer.vb | 4 ++-- .../CodeCracker/Style/TernaryOperatorAnalyzer.vb | 8 ++++---- .../CodeCracker/Usage/ArgumentExceptionAnalyzer.vb | 4 ++-- .../Usage/DisposableFieldNotDisposedAnalyzer.vb | 6 +++--- .../DisposablesShouldCallSuppressFinalizeAnalyzer.vb | 4 ++-- src/VisualBasic/CodeCracker/Usage/IPAddressAnalyzer.vb | 4 ++-- src/VisualBasic/CodeCracker/Usage/JsonNetAnalyzer.vb | 4 ++-- ...InheritClassShouldNotHavePublicConstructorsAnalyzer.vb | 4 ++-- .../Usage/RemovePrivateMethodNeverUsedAnalyzer.vb | 4 ++-- 19 files changed, 42 insertions(+), 42 deletions(-) diff --git a/src/VisualBasic/CodeCracker/Design/CatchEmptyAnalyzer.vb b/src/VisualBasic/CodeCracker/Design/CatchEmptyAnalyzer.vb index e4f1b7c9c..c3282e01c 100644 --- a/src/VisualBasic/CodeCracker/Design/CatchEmptyAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Design/CatchEmptyAnalyzer.vb @@ -1,4 +1,4 @@ -Imports Microsoft.CodeAnalysis +Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic Imports System.Collections.Immutable @@ -17,7 +17,7 @@ Namespace Design Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.CatchEmpty), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.CatchEmpty)) diff --git a/src/VisualBasic/CodeCracker/Design/EmptyCatchBlockAnalyzer.vb b/src/VisualBasic/CodeCracker/Design/EmptyCatchBlockAnalyzer.vb index cda5e4b6e..3383c37be 100644 --- a/src/VisualBasic/CodeCracker/Design/EmptyCatchBlockAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Design/EmptyCatchBlockAnalyzer.vb @@ -20,7 +20,7 @@ If the error is expected, consider logging it or changing the control flow such Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.EmptyCatchBlock), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.EmptyCatchBlock)) diff --git a/src/VisualBasic/CodeCracker/Design/NameOfAnalyzer.vb b/src/VisualBasic/CodeCracker/Design/NameOfAnalyzer.vb index 482eceea5..cbe6a24a6 100644 --- a/src/VisualBasic/CodeCracker/Design/NameOfAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Design/NameOfAnalyzer.vb @@ -1,4 +1,4 @@ -Imports Microsoft.CodeAnalysis +Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic Imports Microsoft.CodeAnalysis.VisualBasic.Syntax @@ -20,7 +20,7 @@ Namespace Design Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.NameOf), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.NameOf)) @@ -29,7 +29,7 @@ Namespace Design Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.NameOf_External), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.NameOf_External)) diff --git a/src/VisualBasic/CodeCracker/Design/StaticConstructorExceptionAnalyzer.vb b/src/VisualBasic/CodeCracker/Design/StaticConstructorExceptionAnalyzer.vb index 3cfaab1f3..df103982a 100644 --- a/src/VisualBasic/CodeCracker/Design/StaticConstructorExceptionAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Design/StaticConstructorExceptionAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -19,7 +19,7 @@ Namespace Design Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.StaticConstructorException), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.StaticConstructorException)) diff --git a/src/VisualBasic/CodeCracker/Performance/MakeLocalVariableConstWhenPossibleAnalyzer.vb b/src/VisualBasic/CodeCracker/Performance/MakeLocalVariableConstWhenPossibleAnalyzer.vb index e406b7fd7..46901c1a5 100644 --- a/src/VisualBasic/CodeCracker/Performance/MakeLocalVariableConstWhenPossibleAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Performance/MakeLocalVariableConstWhenPossibleAnalyzer.vb @@ -1,4 +1,4 @@ -Imports Microsoft.CodeAnalysis +Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic Imports Microsoft.CodeAnalysis.VisualBasic.Syntax @@ -19,7 +19,7 @@ Namespace Performance Title, MessageFormat, Category, - DiagnosticSeverity.Info, + SeverityConfigurations.Current(DiagnosticId.MakeLocalVariableConstWhenItIsPossible), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.MakeLocalVariableConstWhenItIsPossible)) diff --git a/src/VisualBasic/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.vb b/src/VisualBasic/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.vb index 584604eb5..b2e9db4ae 100644 --- a/src/VisualBasic/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.vb @@ -1,4 +1,4 @@ -Imports Microsoft.CodeAnalysis +Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic Imports Microsoft.CodeAnalysis.VisualBasic.Syntax @@ -19,7 +19,7 @@ Namespace Performance Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.RemoveWhereWhenItIsPossible), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.RemoveWhereWhenItIsPossible)) diff --git a/src/VisualBasic/CodeCracker/Performance/SealedAttributeAnalyzer.vb b/src/VisualBasic/CodeCracker/Performance/SealedAttributeAnalyzer.vb index 1f8429ad8..cc772307e 100644 --- a/src/VisualBasic/CodeCracker/Performance/SealedAttributeAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Performance/SealedAttributeAnalyzer.vb @@ -1,4 +1,4 @@ -Imports Microsoft.CodeAnalysis +Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports System.Collections.Immutable @@ -17,7 +17,7 @@ Namespace Performance Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.SealedAttribute), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.SealedAttribute)) diff --git a/src/VisualBasic/CodeCracker/Performance/StringBuilderInLoopAnalyzer.vb b/src/VisualBasic/CodeCracker/Performance/StringBuilderInLoopAnalyzer.vb index 36c1a1ac1..8e22e84e0 100644 --- a/src/VisualBasic/CodeCracker/Performance/StringBuilderInLoopAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Performance/StringBuilderInLoopAnalyzer.vb @@ -1,4 +1,4 @@ -Imports Microsoft.CodeAnalysis +Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic Imports Microsoft.CodeAnalysis.VisualBasic.Syntax @@ -19,7 +19,7 @@ Namespace Performance Title, MessageFormat, Category, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.StringBuilderInLoop), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.StringBuilderInLoop)) diff --git a/src/VisualBasic/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.vb b/src/VisualBasic/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.vb index 00f929e16..909bfcabb 100644 --- a/src/VisualBasic/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -19,7 +19,7 @@ Namespace Refactoring Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current(DiagnosticId.AllowMembersOrdering), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.AllowMembersOrdering)) diff --git a/src/VisualBasic/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.vb b/src/VisualBasic/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.vb index 8ca812ef0..5d30a6517 100644 --- a/src/VisualBasic/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -20,7 +20,7 @@ Namespace Refactoring TitleAny, MessageAny, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current(DiagnosticId.ChangeAnyToAll), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.ChangeAnyToAll)) Friend Shared RuleAll As New DiagnosticDescriptor( @@ -28,7 +28,7 @@ Namespace Refactoring TitleAll, MessageAll, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current(DiagnosticId.ChangeAllToAny), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.ChangeAllToAny)) diff --git a/src/VisualBasic/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.vb b/src/VisualBasic/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.vb index bffee2b9c..f2ce229f5 100644 --- a/src/VisualBasic/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports System.Threading Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics @@ -20,7 +20,7 @@ Namespace Reliability Title, MessageFormat, Category, - DiagnosticSeverity.Hidden, + SeverityConfigurations.Current(DiagnosticId.UseConfigureAwaitFalse), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.UseConfigureAwaitFalse)) diff --git a/src/VisualBasic/CodeCracker/Style/TernaryOperatorAnalyzer.vb b/src/VisualBasic/CodeCracker/Style/TernaryOperatorAnalyzer.vb index 81602adea..07eece8ee 100644 --- a/src/VisualBasic/CodeCracker/Style/TernaryOperatorAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Style/TernaryOperatorAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -17,7 +17,7 @@ Namespace Style Title, MessageFormat, SupportedCategories.Style, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.TernaryOperator_Return), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Return)) @@ -26,7 +26,7 @@ Namespace Style Title, MessageFormat, SupportedCategories.Style, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.TernaryOperator_Assignment), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Assignment)) @@ -35,7 +35,7 @@ Namespace Style Title, MessageFormat, SupportedCategories.Style, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.TernaryOperator_Iif), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Iif)) diff --git a/src/VisualBasic/CodeCracker/Usage/ArgumentExceptionAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/ArgumentExceptionAnalyzer.vb index 5f44756e4..d9cfcc062 100644 --- a/src/VisualBasic/CodeCracker/Usage/ArgumentExceptionAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/ArgumentExceptionAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -18,7 +18,7 @@ It can be either specified directly or using nameof() (VB 14 and above only)." Title, MessageFormat, SupportedCategories.Naming, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.ArgumentException), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.ArgumentException)) diff --git a/src/VisualBasic/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.vb index 16ed817be..adb3a4642 100644 --- a/src/VisualBasic/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -18,7 +18,7 @@ Namespace Usage Title, MessageFormat, SupportedCategories.Usage, - DiagnosticSeverity.Info, + SeverityConfigurations.Current(DiagnosticId.DisposableFieldNotDisposed_Returned), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.DisposableFieldNotDisposed_Returned)) @@ -28,7 +28,7 @@ Namespace Usage Title, MessageFormat, SupportedCategories.Usage, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.DisposableFieldNotDisposed_Created), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.DisposableFieldNotDisposed_Created)) diff --git a/src/VisualBasic/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.vb index 2b80fa72d..9a0009272 100644 --- a/src/VisualBasic/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic.Syntax @@ -20,7 +20,7 @@ This rule should be followed even if the class doesn't have a finalizer in a der Title, MessageFormat, SupportedCategories.Naming, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.DisposablesShouldCallSuppressFinalize), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.DisposablesShouldCallSuppressFinalize)) diff --git a/src/VisualBasic/CodeCracker/Usage/IPAddressAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/IPAddressAnalyzer.vb index 49b2acf07..8191d2ea2 100644 --- a/src/VisualBasic/CodeCracker/Usage/IPAddressAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/IPAddressAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports System.Reflection Imports CodeCracker.VisualBasic.Usage.MethodAnalyzers Imports Microsoft.CodeAnalysis @@ -18,7 +18,7 @@ Public Class IPAddressAnalyzer Title, MessageFormat, SupportedCategories.Usage, - DiagnosticSeverity.Error, + SeverityConfigurations.Current(DiagnosticId.IPAddress), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.IPAddress)) diff --git a/src/VisualBasic/CodeCracker/Usage/JsonNetAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/JsonNetAnalyzer.vb index fc5ca332d..3783073d1 100644 --- a/src/VisualBasic/CodeCracker/Usage/JsonNetAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/JsonNetAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports System.Reflection Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics @@ -19,7 +19,7 @@ Namespace Usage Title, MessageFormat, SupportedCategories.Usage, - DiagnosticSeverity.Error, + SeverityConfigurations.Current(DiagnosticId.JsonNet), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.JsonNet)) diff --git a/src/VisualBasic/CodeCracker/Usage/MustInheritClassShouldNotHavePublicConstructorsAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/MustInheritClassShouldNotHavePublicConstructorsAnalyzer.vb index 0ca476ee2..b76d30a2f 100644 --- a/src/VisualBasic/CodeCracker/Usage/MustInheritClassShouldNotHavePublicConstructorsAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/MustInheritClassShouldNotHavePublicConstructorsAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -17,7 +17,7 @@ Namespace Usage Title, MessageFormat, SupportedCategories.Usage, - DiagnosticSeverity.Warning, + SeverityConfigurations.Current(DiagnosticId.AbstractClassShouldNotHavePublicCtors), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.AbstractClassShouldNotHavePublicCtors)) diff --git a/src/VisualBasic/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.vb index 652a83ca7..f372c1518 100644 --- a/src/VisualBasic/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.vb @@ -1,4 +1,4 @@ -Imports System.Collections.Immutable +Imports System.Collections.Immutable Imports Microsoft.CodeAnalysis Imports Microsoft.CodeAnalysis.Diagnostics Imports Microsoft.CodeAnalysis.VisualBasic @@ -18,7 +18,7 @@ Namespace Usage Title, Message, SupportedCategories.Usage, - DiagnosticSeverity.Info, + SeverityConfigurations.Current(DiagnosticId.RemovePrivateMethodNeverUsed), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.RemovePrivateMethodNeverUsed)) From 9a81baf96ab2d968d56fb2b886a0073d2f80a6ec Mon Sep 17 00:00:00 2001 From: walterlv Date: Fri, 30 Aug 2019 12:52:24 +0800 Subject: [PATCH 4/6] Add comments for SeverityConfigurations --- .../ServerityConfigurations.cs | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/src/Common/CodeCracker.Common/ServerityConfigurations.cs b/src/Common/CodeCracker.Common/ServerityConfigurations.cs index b00337d64..3dc3ebfb0 100644 --- a/src/Common/CodeCracker.Common/ServerityConfigurations.cs +++ b/src/Common/CodeCracker.Common/ServerityConfigurations.cs @@ -8,14 +8,29 @@ namespace CodeCracker { + /// + /// Contains all DiagnosticSeverities for all DiagnosticIds. + /// public class SeverityConfigurations { + /// + /// Gets the DiagnosticSeverities that is configured by the user. + /// public static SeverityConfigurations Current { get; } = new SeverityConfigurations(); + /// + /// Gets the default DiagnosticSeverities of all DiagnosticIds. + /// public static SeverityConfigurations Default { get; } = new SeverityConfigurations(); + /// + /// Stores all the DiagnosticSeverities. + /// private readonly ConcurrentDictionary _diagnosticServerities; + /// + /// Initialize a new instance of . + /// private SeverityConfigurations() { var values = new Dictionary @@ -107,6 +122,11 @@ private SeverityConfigurations() _diagnosticServerities = new ConcurrentDictionary(values); } + /// + /// Gets the of the specified . + /// + /// The which you want to get the . + /// The of the specified . public DiagnosticSeverity this[DiagnosticId id] => _diagnosticServerities.TryGetValue(id, out var value) ? value From 591e0d119c8ee1095fbea04807459c79a3059cb7 Mon Sep 17 00:00:00 2001 From: walterlv Date: Fri, 30 Aug 2019 12:54:24 +0800 Subject: [PATCH 5/6] Fix wrong words. --- src/Common/CodeCracker.Common/CodeCracker.Common.csproj | 2 +- ...ServerityConfigurations.cs => SeverityConfigurations.cs} | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) rename src/Common/CodeCracker.Common/{ServerityConfigurations.cs => SeverityConfigurations.cs} (97%) diff --git a/src/Common/CodeCracker.Common/CodeCracker.Common.csproj b/src/Common/CodeCracker.Common/CodeCracker.Common.csproj index b21385b61..e5f0c971c 100644 --- a/src/Common/CodeCracker.Common/CodeCracker.Common.csproj +++ b/src/Common/CodeCracker.Common/CodeCracker.Common.csproj @@ -46,7 +46,7 @@ - + diff --git a/src/Common/CodeCracker.Common/ServerityConfigurations.cs b/src/Common/CodeCracker.Common/SeverityConfigurations.cs similarity index 97% rename from src/Common/CodeCracker.Common/ServerityConfigurations.cs rename to src/Common/CodeCracker.Common/SeverityConfigurations.cs index 3dc3ebfb0..e67a2e592 100644 --- a/src/Common/CodeCracker.Common/ServerityConfigurations.cs +++ b/src/Common/CodeCracker.Common/SeverityConfigurations.cs @@ -26,7 +26,7 @@ public class SeverityConfigurations /// /// Stores all the DiagnosticSeverities. /// - private readonly ConcurrentDictionary _diagnosticServerities; + private readonly ConcurrentDictionary _diagnosticSeverities; /// /// Initialize a new instance of . @@ -119,7 +119,7 @@ private SeverityConfigurations() { DiagnosticId.ReadOnlyComplexTypes, DiagnosticSeverity.Warning }, { DiagnosticId.ReplaceWithGetterOnlyAutoProperty, DiagnosticSeverity.Hidden }, }; - _diagnosticServerities = new ConcurrentDictionary(values); + _diagnosticSeverities = new ConcurrentDictionary(values); } /// @@ -128,7 +128,7 @@ private SeverityConfigurations() /// The which you want to get the . /// The of the specified . public DiagnosticSeverity this[DiagnosticId id] - => _diagnosticServerities.TryGetValue(id, out var value) + => _diagnosticSeverities.TryGetValue(id, out var value) ? value : DiagnosticSeverity.Warning; } From bb6895993f47ddf25d72723ca2b32d33329e8a1e Mon Sep 17 00:00:00 2001 From: walterlv Date: Fri, 30 Aug 2019 13:43:13 +0800 Subject: [PATCH 6/6] Make vb and C# severities different. --- .../CodeCracker/Design/CatchEmptyAnalyzer.cs | 2 +- .../Design/EmptyCatchBlockAnalyzer.cs | 2 +- .../Design/MakeMethodStaticAnalyzer.cs | 2 +- .../CodeCracker/Design/NameOfAnalyzer.cs | 4 +- .../StaticConstructorExceptionAnalyzer.cs | 2 +- .../Design/SwitchWithoutDefaultAnalyzer.cs | 2 +- .../UseInvokeMethodToFireEventAnalyzer.cs | 2 +- .../XmlDocumentationAnalyzer.cs | 4 +- .../Performance/EmptyFinalizerAnalyzer.cs | 2 +- ...alVariableConstWhenItIsPossibleAnalyzer.cs | 2 +- .../RemoveWhereWhenItIsPossibleAnalyzer.cs | 2 +- .../Performance/SealedAttributeAnalyzer.cs | 2 +- .../StringBuilderInLoopAnalyzer.cs | 2 +- .../UseStaticRegexIsMatchAnalyzer.cs | 2 +- .../AddBracesToSwitchSectionsAnalyzer.cs | 2 +- .../AllowMembersOrderingAnalyzer.cs | 2 +- .../Refactoring/ChangeAnyToAllAnalyzer.cs | 4 +- .../Refactoring/ComputeExpressionAnalyzer.cs | 2 +- .../IntroduceFieldFromConstructorAnalyzer.cs | 2 +- .../Refactoring/InvertForAnalyzer.cs | 2 +- .../Refactoring/MergeNestedIfAnalyzer.cs | 2 +- .../Refactoring/NumericLiteralAnalyzer.cs | 2 +- .../Refactoring/ParameterRefactoryAnalyzer.cs | 2 +- ...dEventArgsUnnecessaryAllocationAnalyzer.cs | 2 +- ...placeWithGetterOnlyAutoPropertyAnalyzer.cs | 2 +- .../Refactoring/SplitIntoNestedIfAnalyzer.cs | 2 +- .../StringRepresentationAnalyzer.cs | 4 +- .../UseConfigureAwaitFalseAnalyzer.cs | 2 +- .../CodeCracker/Style/AlwaysUseVarAnalyzer.cs | 4 +- .../Style/ConsoleWriteLineAnalyzer.cs | 2 +- ...rtLambdaExpressionToMethodGroupAnalyzer.cs | 2 +- ...ConvertToExpressionBodiedMemberAnalyzer.cs | 2 +- .../Style/ConvertToSwitchAnalyzer.cs | 2 +- .../Style/EmptyObjectInitializerAnalyzer.cs | 2 +- .../Style/ExistenceOperatorAnalyzer.cs | 2 +- .../CodeCracker/Style/ForInArrayAnalyzer.cs | 2 +- .../Style/InterfaceNameAnalyzer.cs | 2 +- .../Style/ObjectInitializerAnalyzer.cs | 4 +- .../Style/PropertyPrivateSetAnalyzer.cs | 2 +- .../Style/RemoveAsyncFromMethodAnalyzer.cs | 2 +- .../Style/RemoveCommentedCodeAnalyzer.cs | 2 +- .../Style/RemoveTrailingWhitespaceAnalyzer.cs | 2 +- .../CodeCracker/Style/StringFormatAnalyzer.cs | 2 +- .../Style/SwitchToAutoPropAnalyzer.cs | 2 +- .../Style/TaskNameAsyncAnalyzer.cs | 2 +- .../Style/TernaryOperatorAnalyzer.cs | 4 +- .../Style/UnnecessaryParenthesisAnalyzer.cs | 2 +- ...ryToStringInStringConcatenationAnalyzer.cs | 2 +- .../Style/UseEmptyStringAnalyzer.cs | 2 +- .../Style/UseStringEmptyAnalyzer.cs | 2 +- ...ctClassShouldNotHavePublicCtorsAnalyzer.cs | 2 +- .../Usage/ArgumentExceptionAnalyzer.cs | 2 +- .../CallExtensionMethodAsExtensionAnalyzer.cs | 2 +- .../DisposableFieldNotDisposedAnalyzer.cs | 4 +- .../DisposableVariableNotDisposedAnalyzer.cs | 2 +- ...ablesShouldCallSuppressFinalizeAnalyzer.cs | 2 +- .../CodeCracker/Usage/IPAddressAnalyzer.cs | 2 +- .../CodeCracker/Usage/IfReturnTrueAnalyzer.cs | 2 +- .../CodeCracker/Usage/JsonNetAnalyzer.cs | 2 +- .../Usage/NoPrivateReadonlyFieldAnalyzer.cs | 2 +- .../Usage/ReadOnlyComplexTypesAnalyzer.cs | 2 +- .../Usage/ReadonlyFieldAnalyzer.cs | 2 +- .../Usage/RedundantFieldAssignmentAnalyzer.cs | 2 +- src/CSharp/CodeCracker/Usage/RegexAnalyzer.cs | 2 +- .../RemovePrivateMethodNeverUsedAnalyzer.cs | 2 +- .../RemoveRedundantElseClauseAnalyzer.cs | 2 +- .../Usage/RethrowExceptionAnalyzer.cs | 2 +- ...lifyRedundantBooleanComparisonsAnalyzer.cs | 2 +- .../Usage/StringFormatArgsAnalyzer.cs | 4 +- .../Usage/UnusedParametersAnalyzer.cs | 2 +- src/CSharp/CodeCracker/Usage/UriAnalyzer.cs | 2 +- .../VirtualMethodOnConstructorAnalyzer.cs | 2 +- .../SeverityConfigurations.cs | 73 ++++++++++++++----- .../CodeCracker/Design/CatchEmptyAnalyzer.vb | 2 +- .../Design/EmptyCatchBlockAnalyzer.vb | 2 +- .../CodeCracker/Design/NameOfAnalyzer.vb | 4 +- .../StaticConstructorExceptionAnalyzer.vb | 2 +- ...eLocalVariableConstWhenPossibleAnalyzer.vb | 2 +- .../RemoveWhereWhenItIsPossibleAnalyzer.vb | 2 +- .../Performance/SealedAttributeAnalyzer.vb | 2 +- .../StringBuilderInLoopAnalyzer.vb | 2 +- .../AllowMembersOrderingAnalyzer.vb | 2 +- .../Refactoring/ChangeAnyToAllAnalyzer.vb | 4 +- .../UseConfigureAwaitFalseAnalyzer.vb | 2 +- .../Style/TernaryOperatorAnalyzer.vb | 6 +- .../Usage/ArgumentExceptionAnalyzer.vb | 2 +- .../DisposableFieldNotDisposedAnalyzer.vb | 4 +- ...ablesShouldCallSuppressFinalizeAnalyzer.vb | 2 +- .../CodeCracker/Usage/IPAddressAnalyzer.vb | 2 +- .../CodeCracker/Usage/JsonNetAnalyzer.vb | 2 +- ...ShouldNotHavePublicConstructorsAnalyzer.vb | 2 +- .../RemovePrivateMethodNeverUsedAnalyzer.vb | 2 +- 92 files changed, 160 insertions(+), 123 deletions(-) diff --git a/src/CSharp/CodeCracker/Design/CatchEmptyAnalyzer.cs b/src/CSharp/CodeCracker/Design/CatchEmptyAnalyzer.cs index 6e5ec175a..16547aed4 100644 --- a/src/CSharp/CodeCracker/Design/CatchEmptyAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/CatchEmptyAnalyzer.cs @@ -18,7 +18,7 @@ public class CatchEmptyAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.CatchEmpty], + SeverityConfigurations.CurrentCS[DiagnosticId.CatchEmpty], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.CatchEmpty)); diff --git a/src/CSharp/CodeCracker/Design/EmptyCatchBlockAnalyzer.cs b/src/CSharp/CodeCracker/Design/EmptyCatchBlockAnalyzer.cs index 03b20c7fb..f63604a98 100644 --- a/src/CSharp/CodeCracker/Design/EmptyCatchBlockAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/EmptyCatchBlockAnalyzer.cs @@ -20,7 +20,7 @@ public class EmptyCatchBlockAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.EmptyCatchBlock], + SeverityConfigurations.CurrentCS[DiagnosticId.EmptyCatchBlock], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.EmptyCatchBlock)); diff --git a/src/CSharp/CodeCracker/Design/MakeMethodStaticAnalyzer.cs b/src/CSharp/CodeCracker/Design/MakeMethodStaticAnalyzer.cs index 2974a4fc9..ca375e682 100644 --- a/src/CSharp/CodeCracker/Design/MakeMethodStaticAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/MakeMethodStaticAnalyzer.cs @@ -24,7 +24,7 @@ public class MakeMethodStaticAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.MakeMethodStatic], + SeverityConfigurations.CurrentCS[DiagnosticId.MakeMethodStatic], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.MakeMethodStatic)); diff --git a/src/CSharp/CodeCracker/Design/NameOfAnalyzer.cs b/src/CSharp/CodeCracker/Design/NameOfAnalyzer.cs index be38c817f..b9e4bb409 100644 --- a/src/CSharp/CodeCracker/Design/NameOfAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/NameOfAnalyzer.cs @@ -22,7 +22,7 @@ public class NameOfAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.NameOf], + SeverityConfigurations.CurrentCS[DiagnosticId.NameOf], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NameOf)); @@ -31,7 +31,7 @@ public class NameOfAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.NameOf_External], + SeverityConfigurations.CurrentCS[DiagnosticId.NameOf_External], isEnabledByDefault: false, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NameOf_External)); diff --git a/src/CSharp/CodeCracker/Design/StaticConstructorExceptionAnalyzer.cs b/src/CSharp/CodeCracker/Design/StaticConstructorExceptionAnalyzer.cs index 550b5eb41..a8f9dc501 100644 --- a/src/CSharp/CodeCracker/Design/StaticConstructorExceptionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/StaticConstructorExceptionAnalyzer.cs @@ -22,7 +22,7 @@ public class StaticConstructorExceptionAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.StaticConstructorException], + SeverityConfigurations.CurrentCS[DiagnosticId.StaticConstructorException], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StaticConstructorException)); diff --git a/src/CSharp/CodeCracker/Design/SwitchWithoutDefaultAnalyzer.cs b/src/CSharp/CodeCracker/Design/SwitchWithoutDefaultAnalyzer.cs index cdc1839cb..d523cde47 100644 --- a/src/CSharp/CodeCracker/Design/SwitchWithoutDefaultAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/SwitchWithoutDefaultAnalyzer.cs @@ -23,7 +23,7 @@ public class SwitchWithoutDefaultAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.SwitchCaseWithoutDefault], + SeverityConfigurations.CurrentCS[DiagnosticId.SwitchCaseWithoutDefault], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SwitchCaseWithoutDefault)); diff --git a/src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs b/src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs index 2b73f2445..221346b54 100644 --- a/src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs +++ b/src/CSharp/CodeCracker/Design/UseInvokeMethodToFireEventAnalyzer.cs @@ -24,7 +24,7 @@ public class UseInvokeMethodToFireEventAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.UseInvokeMethodToFireEvent], + SeverityConfigurations.CurrentCS[DiagnosticId.UseInvokeMethodToFireEvent], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseInvokeMethodToFireEvent)); diff --git a/src/CSharp/CodeCracker/Maintainability/XmlDocumentationAnalyzer.cs b/src/CSharp/CodeCracker/Maintainability/XmlDocumentationAnalyzer.cs index 6919b5991..6da91478a 100644 --- a/src/CSharp/CodeCracker/Maintainability/XmlDocumentationAnalyzer.cs +++ b/src/CSharp/CodeCracker/Maintainability/XmlDocumentationAnalyzer.cs @@ -20,7 +20,7 @@ public sealed class XmlDocumentationAnalyzer : DiagnosticAnalyzer Title, Title, SupportedCategories.Maintainability, - SeverityConfigurations.Current[DiagnosticId.XmlDocumentation_MissingInCSharp], + SeverityConfigurations.CurrentCS[DiagnosticId.XmlDocumentation_MissingInCSharp], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.XmlDocumentation_MissingInCSharp)); @@ -29,7 +29,7 @@ public sealed class XmlDocumentationAnalyzer : DiagnosticAnalyzer Title, Title, SupportedCategories.Maintainability, - SeverityConfigurations.Current[DiagnosticId.XmlDocumentation_MissingInXml], + SeverityConfigurations.CurrentCS[DiagnosticId.XmlDocumentation_MissingInXml], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.XmlDocumentation_MissingInXml)); diff --git a/src/CSharp/CodeCracker/Performance/EmptyFinalizerAnalyzer.cs b/src/CSharp/CodeCracker/Performance/EmptyFinalizerAnalyzer.cs index ee72e991c..d8c44348b 100644 --- a/src/CSharp/CodeCracker/Performance/EmptyFinalizerAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/EmptyFinalizerAnalyzer.cs @@ -23,7 +23,7 @@ public class EmptyFinalizerAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.EmptyFinalizer], + SeverityConfigurations.CurrentCS[DiagnosticId.EmptyFinalizer], true, customTags: WellKnownDiagnosticTags.Unnecessary, description: Description, diff --git a/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs b/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs index 28febb209..9214b369b 100644 --- a/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/MakeLocalVariableConstWhenItIsPossibleAnalyzer.cs @@ -21,7 +21,7 @@ public class MakeLocalVariableConstWhenItIsPossibleAnalyzer : Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.MakeLocalVariableConstWhenItIsPossible], + SeverityConfigurations.CurrentCS[DiagnosticId.MakeLocalVariableConstWhenItIsPossible], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.MakeLocalVariableConstWhenItIsPossible)); diff --git a/src/CSharp/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.cs b/src/CSharp/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.cs index 8b46da0a8..3901b3d9b 100644 --- a/src/CSharp/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.cs @@ -41,7 +41,7 @@ public class RemoveWhereWhenItIsPossibleAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.RemoveWhereWhenItIsPossible], + SeverityConfigurations.CurrentCS[DiagnosticId.RemoveWhereWhenItIsPossible], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveWhereWhenItIsPossible)); diff --git a/src/CSharp/CodeCracker/Performance/SealedAttributeAnalyzer.cs b/src/CSharp/CodeCracker/Performance/SealedAttributeAnalyzer.cs index 6533b01f9..e6a7c49f2 100644 --- a/src/CSharp/CodeCracker/Performance/SealedAttributeAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/SealedAttributeAnalyzer.cs @@ -19,7 +19,7 @@ public class SealedAttributeAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.SealedAttribute], + SeverityConfigurations.CurrentCS[DiagnosticId.SealedAttribute], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SealedAttribute)); diff --git a/src/CSharp/CodeCracker/Performance/StringBuilderInLoopAnalyzer.cs b/src/CSharp/CodeCracker/Performance/StringBuilderInLoopAnalyzer.cs index 6a07b4f3d..d49aac119 100644 --- a/src/CSharp/CodeCracker/Performance/StringBuilderInLoopAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/StringBuilderInLoopAnalyzer.cs @@ -22,7 +22,7 @@ public class StringBuilderInLoopAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.StringBuilderInLoop], + SeverityConfigurations.CurrentCS[DiagnosticId.StringBuilderInLoop], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringBuilderInLoop)); diff --git a/src/CSharp/CodeCracker/Performance/UseStaticRegexIsMatchAnalyzer.cs b/src/CSharp/CodeCracker/Performance/UseStaticRegexIsMatchAnalyzer.cs index a8dcdb5d7..a6c5093dd 100644 --- a/src/CSharp/CodeCracker/Performance/UseStaticRegexIsMatchAnalyzer.cs +++ b/src/CSharp/CodeCracker/Performance/UseStaticRegexIsMatchAnalyzer.cs @@ -20,7 +20,7 @@ public class UseStaticRegexIsMatchAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.UseStaticRegexIsMatch], + SeverityConfigurations.CurrentCS[DiagnosticId.UseStaticRegexIsMatch], true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseStaticRegexIsMatch)); diff --git a/src/CSharp/CodeCracker/Refactoring/AddBracesToSwitchSectionsAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/AddBracesToSwitchSectionsAnalyzer.cs index 857d5cb2e..b02b40354 100644 --- a/src/CSharp/CodeCracker/Refactoring/AddBracesToSwitchSectionsAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/AddBracesToSwitchSectionsAnalyzer.cs @@ -19,7 +19,7 @@ public class AddBracesToSwitchSectionsAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.AddBracesToSwitchSections], + SeverityConfigurations.CurrentCS[DiagnosticId.AddBracesToSwitchSections], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AddBracesToSwitchSections)); diff --git a/src/CSharp/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.cs index a040d71eb..8666aab69 100644 --- a/src/CSharp/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.cs @@ -18,7 +18,7 @@ public class AllowMembersOrderingAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.AllowMembersOrdering], + SeverityConfigurations.CurrentCS[DiagnosticId.AllowMembersOrdering], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AllowMembersOrdering)); diff --git a/src/CSharp/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.cs index 8fe62fc8e..d5aa74ff0 100644 --- a/src/CSharp/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.cs @@ -23,7 +23,7 @@ public class ChangeAnyToAllAnalyzer : DiagnosticAnalyzer TitleAny, MessageAny, Category, - SeverityConfigurations.Current[DiagnosticId.ChangeAnyToAll], + SeverityConfigurations.CurrentCS[DiagnosticId.ChangeAnyToAll], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ChangeAnyToAll)); internal static readonly DiagnosticDescriptor RuleAll = new DiagnosticDescriptor( @@ -31,7 +31,7 @@ public class ChangeAnyToAllAnalyzer : DiagnosticAnalyzer TitleAll, MessageAll, Category, - SeverityConfigurations.Current[DiagnosticId.ChangeAllToAny], + SeverityConfigurations.CurrentCS[DiagnosticId.ChangeAllToAny], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ChangeAllToAny)); diff --git a/src/CSharp/CodeCracker/Refactoring/ComputeExpressionAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/ComputeExpressionAnalyzer.cs index 93c0b6e67..d205ebc06 100644 --- a/src/CSharp/CodeCracker/Refactoring/ComputeExpressionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/ComputeExpressionAnalyzer.cs @@ -21,7 +21,7 @@ public class ComputeExpressionAnalyzer : DiagnosticAnalyzer Title, Message, Category, - SeverityConfigurations.Current[DiagnosticId.ComputeExpression], + SeverityConfigurations.CurrentCS[DiagnosticId.ComputeExpression], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ComputeExpression)); diff --git a/src/CSharp/CodeCracker/Refactoring/IntroduceFieldFromConstructorAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/IntroduceFieldFromConstructorAnalyzer.cs index bb13003a5..ae3a50829 100644 --- a/src/CSharp/CodeCracker/Refactoring/IntroduceFieldFromConstructorAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/IntroduceFieldFromConstructorAnalyzer.cs @@ -23,7 +23,7 @@ public class IntroduceFieldFromConstructorAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.IntroduceFieldFromConstructor], + SeverityConfigurations.CurrentCS[DiagnosticId.IntroduceFieldFromConstructor], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.IntroduceFieldFromConstructor)); diff --git a/src/CSharp/CodeCracker/Refactoring/InvertForAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/InvertForAnalyzer.cs index b3aab8a90..f49fe423b 100644 --- a/src/CSharp/CodeCracker/Refactoring/InvertForAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/InvertForAnalyzer.cs @@ -18,7 +18,7 @@ public class InvertForAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.InvertFor], + SeverityConfigurations.CurrentCS[DiagnosticId.InvertFor], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.InvertFor)); diff --git a/src/CSharp/CodeCracker/Refactoring/MergeNestedIfAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/MergeNestedIfAnalyzer.cs index 5575c5ed7..7f463d0a6 100644 --- a/src/CSharp/CodeCracker/Refactoring/MergeNestedIfAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/MergeNestedIfAnalyzer.cs @@ -18,7 +18,7 @@ public class MergeNestedIfAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.MergeNestedIf], + SeverityConfigurations.CurrentCS[DiagnosticId.MergeNestedIf], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.MergeNestedIf)); diff --git a/src/CSharp/CodeCracker/Refactoring/NumericLiteralAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/NumericLiteralAnalyzer.cs index ee5c2e225..08456407b 100644 --- a/src/CSharp/CodeCracker/Refactoring/NumericLiteralAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/NumericLiteralAnalyzer.cs @@ -18,7 +18,7 @@ public class NumericLiteralAnalyzer : DiagnosticAnalyzer Title, Message, Category, - SeverityConfigurations.Current[DiagnosticId.NumericLiteral], + SeverityConfigurations.CurrentCS[DiagnosticId.NumericLiteral], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NumericLiteral)); diff --git a/src/CSharp/CodeCracker/Refactoring/ParameterRefactoryAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/ParameterRefactoryAnalyzer.cs index 7ca6af87e..256f56855 100644 --- a/src/CSharp/CodeCracker/Refactoring/ParameterRefactoryAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/ParameterRefactoryAnalyzer.cs @@ -20,7 +20,7 @@ public class ParameterRefactoryAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.ParameterRefactory], + SeverityConfigurations.CurrentCS[DiagnosticId.ParameterRefactory], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ParameterRefactory)); diff --git a/src/CSharp/CodeCracker/Refactoring/PropertyChangedEventArgsUnnecessaryAllocationAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/PropertyChangedEventArgsUnnecessaryAllocationAnalyzer.cs index 90f782a4f..65b15223e 100644 --- a/src/CSharp/CodeCracker/Refactoring/PropertyChangedEventArgsUnnecessaryAllocationAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/PropertyChangedEventArgsUnnecessaryAllocationAnalyzer.cs @@ -34,7 +34,7 @@ public sealed class PropertyChangedEventArgsUnnecessaryAllocationAnalyzer : Diag Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.PropertyChangedEventArgsUnnecessaryAllocation], + SeverityConfigurations.CurrentCS[DiagnosticId.PropertyChangedEventArgsUnnecessaryAllocation], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.PropertyChangedEventArgsUnnecessaryAllocation)); diff --git a/src/CSharp/CodeCracker/Refactoring/ReplaceWithGetterOnlyAutoPropertyAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/ReplaceWithGetterOnlyAutoPropertyAnalyzer.cs index 9e9f145f0..09f536fad 100644 --- a/src/CSharp/CodeCracker/Refactoring/ReplaceWithGetterOnlyAutoPropertyAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/ReplaceWithGetterOnlyAutoPropertyAnalyzer.cs @@ -22,7 +22,7 @@ public class ReplaceWithGetterOnlyAutoPropertyAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.ReplaceWithGetterOnlyAutoProperty], + SeverityConfigurations.CurrentCS[DiagnosticId.ReplaceWithGetterOnlyAutoProperty], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ReplaceWithGetterOnlyAutoProperty)); diff --git a/src/CSharp/CodeCracker/Refactoring/SplitIntoNestedIfAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/SplitIntoNestedIfAnalyzer.cs index 60f57bdb2..2af7eda33 100644 --- a/src/CSharp/CodeCracker/Refactoring/SplitIntoNestedIfAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/SplitIntoNestedIfAnalyzer.cs @@ -18,7 +18,7 @@ public class SplitIntoNestedIfAnalyzer : DiagnosticAnalyzer Title, Message, Category, - SeverityConfigurations.Current[DiagnosticId.SplitIntoNestedIf], + SeverityConfigurations.CurrentCS[DiagnosticId.SplitIntoNestedIf], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SplitIntoNestedIf)); diff --git a/src/CSharp/CodeCracker/Refactoring/StringRepresentationAnalyzer.cs b/src/CSharp/CodeCracker/Refactoring/StringRepresentationAnalyzer.cs index ce6cabe46..3e356a34a 100644 --- a/src/CSharp/CodeCracker/Refactoring/StringRepresentationAnalyzer.cs +++ b/src/CSharp/CodeCracker/Refactoring/StringRepresentationAnalyzer.cs @@ -16,7 +16,7 @@ public class StringRepresentationAnalyzer : DiagnosticAnalyzer "Regular string", "Change to regular string", SupportedCategories.Refactoring, - SeverityConfigurations.Current[DiagnosticId.StringRepresentation_RegularString], + SeverityConfigurations.CurrentCS[DiagnosticId.StringRepresentation_RegularString], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringRepresentation_RegularString)); @@ -25,7 +25,7 @@ public class StringRepresentationAnalyzer : DiagnosticAnalyzer "Verbatim string", "Change to verbatim string", SupportedCategories.Refactoring, - SeverityConfigurations.Current[DiagnosticId.StringRepresentation_VerbatimString], + SeverityConfigurations.CurrentCS[DiagnosticId.StringRepresentation_VerbatimString], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringRepresentation_VerbatimString)); diff --git a/src/CSharp/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.cs b/src/CSharp/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.cs index ae6f27d6d..2fc5fc8c3 100644 --- a/src/CSharp/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.cs +++ b/src/CSharp/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.cs @@ -18,7 +18,7 @@ public class UseConfigureAwaitFalseAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.UseConfigureAwaitFalse], + SeverityConfigurations.CurrentCS[DiagnosticId.UseConfigureAwaitFalse], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseConfigureAwaitFalse)); diff --git a/src/CSharp/CodeCracker/Style/AlwaysUseVarAnalyzer.cs b/src/CSharp/CodeCracker/Style/AlwaysUseVarAnalyzer.cs index f0a33bb05..d034922c7 100644 --- a/src/CSharp/CodeCracker/Style/AlwaysUseVarAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/AlwaysUseVarAnalyzer.cs @@ -21,7 +21,7 @@ public class AlwaysUseVarAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.AlwaysUseVar], + SeverityConfigurations.CurrentCS[DiagnosticId.AlwaysUseVar], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AlwaysUseVar)); @@ -31,7 +31,7 @@ public class AlwaysUseVarAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.AlwaysUseVarOnPrimitives], + SeverityConfigurations.CurrentCS[DiagnosticId.AlwaysUseVarOnPrimitives], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AlwaysUseVarOnPrimitives)); diff --git a/src/CSharp/CodeCracker/Style/ConsoleWriteLineAnalyzer.cs b/src/CSharp/CodeCracker/Style/ConsoleWriteLineAnalyzer.cs index bf0f08903..15769bf57 100644 --- a/src/CSharp/CodeCracker/Style/ConsoleWriteLineAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ConsoleWriteLineAnalyzer.cs @@ -19,7 +19,7 @@ public class ConsoleWriteLineAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.ConsoleWriteLine], + SeverityConfigurations.CurrentCS[DiagnosticId.ConsoleWriteLine], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ConsoleWriteLine)); diff --git a/src/CSharp/CodeCracker/Style/ConvertLambdaExpressionToMethodGroupAnalyzer.cs b/src/CSharp/CodeCracker/Style/ConvertLambdaExpressionToMethodGroupAnalyzer.cs index e1b068be6..dc3245751 100644 --- a/src/CSharp/CodeCracker/Style/ConvertLambdaExpressionToMethodGroupAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ConvertLambdaExpressionToMethodGroupAnalyzer.cs @@ -20,7 +20,7 @@ public class ConvertLambdaExpressionToMethodGroupAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.ConvertLambdaExpressionToMethodGroup], + SeverityConfigurations.CurrentCS[DiagnosticId.ConvertLambdaExpressionToMethodGroup], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ConvertLambdaExpressionToMethodGroup)); diff --git a/src/CSharp/CodeCracker/Style/ConvertToExpressionBodiedMemberAnalyzer.cs b/src/CSharp/CodeCracker/Style/ConvertToExpressionBodiedMemberAnalyzer.cs index 67efa64bd..31b933230 100644 --- a/src/CSharp/CodeCracker/Style/ConvertToExpressionBodiedMemberAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ConvertToExpressionBodiedMemberAnalyzer.cs @@ -19,7 +19,7 @@ public class ConvertToExpressionBodiedMemberAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.ConvertToExpressionBodiedMember], + SeverityConfigurations.CurrentCS[DiagnosticId.ConvertToExpressionBodiedMember], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ConvertToExpressionBodiedMember)); diff --git a/src/CSharp/CodeCracker/Style/ConvertToSwitchAnalyzer.cs b/src/CSharp/CodeCracker/Style/ConvertToSwitchAnalyzer.cs index 9594b378f..73cad2fa4 100644 --- a/src/CSharp/CodeCracker/Style/ConvertToSwitchAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ConvertToSwitchAnalyzer.cs @@ -22,7 +22,7 @@ public class ConvertToSwitchAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.ConvertToSwitch], + SeverityConfigurations.CurrentCS[DiagnosticId.ConvertToSwitch], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ConvertToSwitch)); diff --git a/src/CSharp/CodeCracker/Style/EmptyObjectInitializerAnalyzer.cs b/src/CSharp/CodeCracker/Style/EmptyObjectInitializerAnalyzer.cs index d85d89fb3..f60a4b8bd 100644 --- a/src/CSharp/CodeCracker/Style/EmptyObjectInitializerAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/EmptyObjectInitializerAnalyzer.cs @@ -19,7 +19,7 @@ public class EmptyObjectInitializerAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.EmptyObjectInitializer], + SeverityConfigurations.CurrentCS[DiagnosticId.EmptyObjectInitializer], isEnabledByDefault: true, customTags: WellKnownDiagnosticTags.Unnecessary, description: Description, diff --git a/src/CSharp/CodeCracker/Style/ExistenceOperatorAnalyzer.cs b/src/CSharp/CodeCracker/Style/ExistenceOperatorAnalyzer.cs index 21c291203..52b93fcca 100644 --- a/src/CSharp/CodeCracker/Style/ExistenceOperatorAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ExistenceOperatorAnalyzer.cs @@ -18,7 +18,7 @@ public class ExistenceOperatorAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.ExistenceOperator], + SeverityConfigurations.CurrentCS[DiagnosticId.ExistenceOperator], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ExistenceOperator)); diff --git a/src/CSharp/CodeCracker/Style/ForInArrayAnalyzer.cs b/src/CSharp/CodeCracker/Style/ForInArrayAnalyzer.cs index 6277675fb..8f36dc842 100644 --- a/src/CSharp/CodeCracker/Style/ForInArrayAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ForInArrayAnalyzer.cs @@ -22,7 +22,7 @@ public class ForInArrayAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.ForInArray], + SeverityConfigurations.CurrentCS[DiagnosticId.ForInArray], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ForInArray)); diff --git a/src/CSharp/CodeCracker/Style/InterfaceNameAnalyzer.cs b/src/CSharp/CodeCracker/Style/InterfaceNameAnalyzer.cs index e343ba19c..e2ba23e44 100644 --- a/src/CSharp/CodeCracker/Style/InterfaceNameAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/InterfaceNameAnalyzer.cs @@ -19,7 +19,7 @@ public class InterfaceNameAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.InterfaceName], + SeverityConfigurations.CurrentCS[DiagnosticId.InterfaceName], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.InterfaceName)); diff --git a/src/CSharp/CodeCracker/Style/ObjectInitializerAnalyzer.cs b/src/CSharp/CodeCracker/Style/ObjectInitializerAnalyzer.cs index 76118d566..132339cb3 100644 --- a/src/CSharp/CodeCracker/Style/ObjectInitializerAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/ObjectInitializerAnalyzer.cs @@ -24,7 +24,7 @@ public class ObjectInitializerAnalyzer : DiagnosticAnalyzer TitleLocalDeclaration, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.ObjectInitializer_Assignment], + SeverityConfigurations.CurrentCS[DiagnosticId.ObjectInitializer_Assignment], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ObjectInitializer_Assignment)); @@ -34,7 +34,7 @@ public class ObjectInitializerAnalyzer : DiagnosticAnalyzer TitleLocalDeclaration, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.ObjectInitializer_LocalDeclaration], + SeverityConfigurations.CurrentCS[DiagnosticId.ObjectInitializer_LocalDeclaration], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ObjectInitializer_LocalDeclaration)); diff --git a/src/CSharp/CodeCracker/Style/PropertyPrivateSetAnalyzer.cs b/src/CSharp/CodeCracker/Style/PropertyPrivateSetAnalyzer.cs index a728b7f38..2a9ca361a 100644 --- a/src/CSharp/CodeCracker/Style/PropertyPrivateSetAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/PropertyPrivateSetAnalyzer.cs @@ -20,7 +20,7 @@ public class PropertyPrivateSetAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.PropertyPrivateSet], + SeverityConfigurations.CurrentCS[DiagnosticId.PropertyPrivateSet], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.PropertyPrivateSet)); diff --git a/src/CSharp/CodeCracker/Style/RemoveAsyncFromMethodAnalyzer.cs b/src/CSharp/CodeCracker/Style/RemoveAsyncFromMethodAnalyzer.cs index 0f6e4634c..b9ce6621a 100644 --- a/src/CSharp/CodeCracker/Style/RemoveAsyncFromMethodAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/RemoveAsyncFromMethodAnalyzer.cs @@ -21,7 +21,7 @@ public class RemoveAsyncFromMethodAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.RemoveAsyncFromMethod], + SeverityConfigurations.CurrentCS[DiagnosticId.RemoveAsyncFromMethod], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveAsyncFromMethod)); diff --git a/src/CSharp/CodeCracker/Style/RemoveCommentedCodeAnalyzer.cs b/src/CSharp/CodeCracker/Style/RemoveCommentedCodeAnalyzer.cs index 838795de7..ed108038b 100644 --- a/src/CSharp/CodeCracker/Style/RemoveCommentedCodeAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/RemoveCommentedCodeAnalyzer.cs @@ -19,7 +19,7 @@ public class RemoveCommentedCodeAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.RemoveCommentedCode], + SeverityConfigurations.CurrentCS[DiagnosticId.RemoveCommentedCode], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveCommentedCode)); diff --git a/src/CSharp/CodeCracker/Style/RemoveTrailingWhitespaceAnalyzer.cs b/src/CSharp/CodeCracker/Style/RemoveTrailingWhitespaceAnalyzer.cs index f7dbf1028..c527a8a98 100644 --- a/src/CSharp/CodeCracker/Style/RemoveTrailingWhitespaceAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/RemoveTrailingWhitespaceAnalyzer.cs @@ -21,7 +21,7 @@ public class RemoveTrailingWhitespaceAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.RemoveTrailingWhitespace], + SeverityConfigurations.CurrentCS[DiagnosticId.RemoveTrailingWhitespace], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveTrailingWhitespace)); diff --git a/src/CSharp/CodeCracker/Style/StringFormatAnalyzer.cs b/src/CSharp/CodeCracker/Style/StringFormatAnalyzer.cs index dba6b5a16..3a67e0705 100644 --- a/src/CSharp/CodeCracker/Style/StringFormatAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/StringFormatAnalyzer.cs @@ -23,7 +23,7 @@ public class StringFormatAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.StringFormat], + SeverityConfigurations.CurrentCS[DiagnosticId.StringFormat], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringFormat)); diff --git a/src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs b/src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs index 02fac7075..de3c5369d 100644 --- a/src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/SwitchToAutoPropAnalyzer.cs @@ -23,7 +23,7 @@ public class SwitchToAutoPropAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.SwitchToAutoProp], + SeverityConfigurations.CurrentCS[DiagnosticId.SwitchToAutoProp], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SwitchToAutoProp)); diff --git a/src/CSharp/CodeCracker/Style/TaskNameAsyncAnalyzer.cs b/src/CSharp/CodeCracker/Style/TaskNameAsyncAnalyzer.cs index 7c27fbc39..3bf838f3e 100644 --- a/src/CSharp/CodeCracker/Style/TaskNameAsyncAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/TaskNameAsyncAnalyzer.cs @@ -21,7 +21,7 @@ public class TaskNameAsyncAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.TaskNameAsync], + SeverityConfigurations.CurrentCS[DiagnosticId.TaskNameAsync], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.TaskNameAsync)); diff --git a/src/CSharp/CodeCracker/Style/TernaryOperatorAnalyzer.cs b/src/CSharp/CodeCracker/Style/TernaryOperatorAnalyzer.cs index b5aaebf25..6607ad2a2 100644 --- a/src/CSharp/CodeCracker/Style/TernaryOperatorAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/TernaryOperatorAnalyzer.cs @@ -20,7 +20,7 @@ public class TernaryOperatorAnalyzer : DiagnosticAnalyzer Title, MessageFormatForIfWithReturn, Category, - SeverityConfigurations.Current[DiagnosticId.TernaryOperator_Return], + SeverityConfigurations.CurrentCS[DiagnosticId.TernaryOperator_Return], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Return)); @@ -29,7 +29,7 @@ public class TernaryOperatorAnalyzer : DiagnosticAnalyzer Title, MessageFormatForIfWithAssignment, Category, - SeverityConfigurations.Current[DiagnosticId.TernaryOperator_Assignment], + SeverityConfigurations.CurrentCS[DiagnosticId.TernaryOperator_Assignment], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Assignment)); diff --git a/src/CSharp/CodeCracker/Style/UnnecessaryParenthesisAnalyzer.cs b/src/CSharp/CodeCracker/Style/UnnecessaryParenthesisAnalyzer.cs index 3a03cd0de..37f24df52 100644 --- a/src/CSharp/CodeCracker/Style/UnnecessaryParenthesisAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/UnnecessaryParenthesisAnalyzer.cs @@ -20,7 +20,7 @@ public class UnnecessaryParenthesisAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.UnnecessaryParenthesis], + SeverityConfigurations.CurrentCS[DiagnosticId.UnnecessaryParenthesis], customTags: WellKnownDiagnosticTags.Unnecessary, isEnabledByDefault: true, description: Description, diff --git a/src/CSharp/CodeCracker/Style/UnnecessaryToStringInStringConcatenationAnalyzer.cs b/src/CSharp/CodeCracker/Style/UnnecessaryToStringInStringConcatenationAnalyzer.cs index dd59fedc6..e17201734 100644 --- a/src/CSharp/CodeCracker/Style/UnnecessaryToStringInStringConcatenationAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/UnnecessaryToStringInStringConcatenationAnalyzer.cs @@ -26,7 +26,7 @@ public class UnnecessaryToStringInStringConcatenationAnalyzer : DiagnosticAnalyz Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.UnnecessaryToStringInStringConcatenation], + SeverityConfigurations.CurrentCS[DiagnosticId.UnnecessaryToStringInStringConcatenation], customTags: WellKnownDiagnosticTags.Unnecessary, isEnabledByDefault: true, description: Description, diff --git a/src/CSharp/CodeCracker/Style/UseEmptyStringAnalyzer.cs b/src/CSharp/CodeCracker/Style/UseEmptyStringAnalyzer.cs index c4c9326f3..44de0bb37 100644 --- a/src/CSharp/CodeCracker/Style/UseEmptyStringAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/UseEmptyStringAnalyzer.cs @@ -24,7 +24,7 @@ public class UseEmptyStringAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.UseEmptyString], + SeverityConfigurations.CurrentCS[DiagnosticId.UseEmptyString], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseEmptyString)); diff --git a/src/CSharp/CodeCracker/Style/UseStringEmptyAnalyzer.cs b/src/CSharp/CodeCracker/Style/UseStringEmptyAnalyzer.cs index 0c73c25c3..3cb86722f 100644 --- a/src/CSharp/CodeCracker/Style/UseStringEmptyAnalyzer.cs +++ b/src/CSharp/CodeCracker/Style/UseStringEmptyAnalyzer.cs @@ -20,7 +20,7 @@ public class UseStringEmptyAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.UseStringEmpty], + SeverityConfigurations.CurrentCS[DiagnosticId.UseStringEmpty], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.UseStringEmpty)); diff --git a/src/CSharp/CodeCracker/Usage/AbstractClassShouldNotHavePublicCtorsAnalyzer.cs b/src/CSharp/CodeCracker/Usage/AbstractClassShouldNotHavePublicCtorsAnalyzer.cs index 93170d37f..e3001b217 100644 --- a/src/CSharp/CodeCracker/Usage/AbstractClassShouldNotHavePublicCtorsAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/AbstractClassShouldNotHavePublicCtorsAnalyzer.cs @@ -20,7 +20,7 @@ public class AbstractClassShouldNotHavePublicCtorsAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.AbstractClassShouldNotHavePublicCtors], + SeverityConfigurations.CurrentCS[DiagnosticId.AbstractClassShouldNotHavePublicCtors], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.AbstractClassShouldNotHavePublicCtors)); diff --git a/src/CSharp/CodeCracker/Usage/ArgumentExceptionAnalyzer.cs b/src/CSharp/CodeCracker/Usage/ArgumentExceptionAnalyzer.cs index ebacc8642..e850bb046 100644 --- a/src/CSharp/CodeCracker/Usage/ArgumentExceptionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/ArgumentExceptionAnalyzer.cs @@ -22,7 +22,7 @@ public class ArgumentExceptionAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.ArgumentException], + SeverityConfigurations.CurrentCS[DiagnosticId.ArgumentException], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ArgumentException)); diff --git a/src/CSharp/CodeCracker/Usage/CallExtensionMethodAsExtensionAnalyzer.cs b/src/CSharp/CodeCracker/Usage/CallExtensionMethodAsExtensionAnalyzer.cs index e7ff75e7f..a744ad81a 100644 --- a/src/CSharp/CodeCracker/Usage/CallExtensionMethodAsExtensionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/CallExtensionMethodAsExtensionAnalyzer.cs @@ -22,7 +22,7 @@ public class CallExtensionMethodAsExtensionAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.CallExtensionMethodAsExtension], + SeverityConfigurations.CurrentCS[DiagnosticId.CallExtensionMethodAsExtension], isEnabledByDefault: true, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.CallExtensionMethodAsExtension)); diff --git a/src/CSharp/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.cs b/src/CSharp/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.cs index e1a9a1fd2..2e2929bf9 100644 --- a/src/CSharp/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.cs @@ -22,7 +22,7 @@ public class DisposableFieldNotDisposedAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.DisposableFieldNotDisposed_Returned], + SeverityConfigurations.CurrentCS[DiagnosticId.DisposableFieldNotDisposed_Returned], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.DisposableFieldNotDisposed_Returned)); @@ -31,7 +31,7 @@ public class DisposableFieldNotDisposedAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.DisposableFieldNotDisposed_Created], + SeverityConfigurations.CurrentCS[DiagnosticId.DisposableFieldNotDisposed_Created], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.DisposableFieldNotDisposed_Created)); diff --git a/src/CSharp/CodeCracker/Usage/DisposableVariableNotDisposedAnalyzer.cs b/src/CSharp/CodeCracker/Usage/DisposableVariableNotDisposedAnalyzer.cs index b39eb9544..8cd76c3e7 100644 --- a/src/CSharp/CodeCracker/Usage/DisposableVariableNotDisposedAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/DisposableVariableNotDisposedAnalyzer.cs @@ -23,7 +23,7 @@ public class DisposableVariableNotDisposedAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.DisposableVariableNotDisposed], + SeverityConfigurations.CurrentCS[DiagnosticId.DisposableVariableNotDisposed], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.DisposableVariableNotDisposed)); diff --git a/src/CSharp/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.cs b/src/CSharp/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.cs index b89397295..0dcbc95af 100644 --- a/src/CSharp/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.cs @@ -23,7 +23,7 @@ public class DisposablesShouldCallSuppressFinalizeAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.DisposablesShouldCallSuppressFinalize], + SeverityConfigurations.CurrentCS[DiagnosticId.DisposablesShouldCallSuppressFinalize], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.DisposablesShouldCallSuppressFinalize)); diff --git a/src/CSharp/CodeCracker/Usage/IPAddressAnalyzer.cs b/src/CSharp/CodeCracker/Usage/IPAddressAnalyzer.cs index 27d4a6329..9f121c65b 100644 --- a/src/CSharp/CodeCracker/Usage/IPAddressAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/IPAddressAnalyzer.cs @@ -23,7 +23,7 @@ public class IPAddressAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.IPAddress], + SeverityConfigurations.CurrentCS[DiagnosticId.IPAddress], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.IPAddress)); diff --git a/src/CSharp/CodeCracker/Usage/IfReturnTrueAnalyzer.cs b/src/CSharp/CodeCracker/Usage/IfReturnTrueAnalyzer.cs index c62462f7d..edad491cd 100644 --- a/src/CSharp/CodeCracker/Usage/IfReturnTrueAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/IfReturnTrueAnalyzer.cs @@ -19,7 +19,7 @@ public class IfReturnTrueAnalyzer : DiagnosticAnalyzer Title, Message, Category, - SeverityConfigurations.Current[DiagnosticId.IfReturnTrue], + SeverityConfigurations.CurrentCS[DiagnosticId.IfReturnTrue], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.IfReturnTrue)); diff --git a/src/CSharp/CodeCracker/Usage/JsonNetAnalyzer.cs b/src/CSharp/CodeCracker/Usage/JsonNetAnalyzer.cs index 925b88aec..5aa1e9402 100644 --- a/src/CSharp/CodeCracker/Usage/JsonNetAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/JsonNetAnalyzer.cs @@ -22,7 +22,7 @@ public class JsonNetAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.JsonNet], + SeverityConfigurations.CurrentCS[DiagnosticId.JsonNet], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.JsonNet)); diff --git a/src/CSharp/CodeCracker/Usage/NoPrivateReadonlyFieldAnalyzer.cs b/src/CSharp/CodeCracker/Usage/NoPrivateReadonlyFieldAnalyzer.cs index 5911228b0..306fc77e3 100644 --- a/src/CSharp/CodeCracker/Usage/NoPrivateReadonlyFieldAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/NoPrivateReadonlyFieldAnalyzer.cs @@ -22,7 +22,7 @@ public class NoPrivateReadonlyFieldAnalyzer : DiagnosticAnalyzer Title, Message, Category, - SeverityConfigurations.Current[DiagnosticId.NoPrivateReadonlyField], + SeverityConfigurations.CurrentCS[DiagnosticId.NoPrivateReadonlyField], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.NoPrivateReadonlyField)); diff --git a/src/CSharp/CodeCracker/Usage/ReadOnlyComplexTypesAnalyzer.cs b/src/CSharp/CodeCracker/Usage/ReadOnlyComplexTypesAnalyzer.cs index 0a0835cad..43c494497 100644 --- a/src/CSharp/CodeCracker/Usage/ReadOnlyComplexTypesAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/ReadOnlyComplexTypesAnalyzer.cs @@ -22,7 +22,7 @@ public class ReadOnlyComplexTypesAnalyzer : DiagnosticAnalyzer Title, Message, Category, - SeverityConfigurations.Current[DiagnosticId.ReadOnlyComplexTypes], + SeverityConfigurations.CurrentCS[DiagnosticId.ReadOnlyComplexTypes], isEnabledByDefault: false, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ReadOnlyComplexTypes)); diff --git a/src/CSharp/CodeCracker/Usage/ReadonlyFieldAnalyzer.cs b/src/CSharp/CodeCracker/Usage/ReadonlyFieldAnalyzer.cs index 60c9acf4a..4835a802f 100644 --- a/src/CSharp/CodeCracker/Usage/ReadonlyFieldAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/ReadonlyFieldAnalyzer.cs @@ -22,7 +22,7 @@ public class ReadonlyFieldAnalyzer : DiagnosticAnalyzer Title, Message, Category, - SeverityConfigurations.Current[DiagnosticId.ReadonlyField], + SeverityConfigurations.CurrentCS[DiagnosticId.ReadonlyField], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.ReadonlyField)); diff --git a/src/CSharp/CodeCracker/Usage/RedundantFieldAssignmentAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RedundantFieldAssignmentAnalyzer.cs index 780858873..962616dbd 100644 --- a/src/CSharp/CodeCracker/Usage/RedundantFieldAssignmentAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RedundantFieldAssignmentAnalyzer.cs @@ -22,7 +22,7 @@ public class RedundantFieldAssignmentAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.RedundantFieldAssignment], + SeverityConfigurations.CurrentCS[DiagnosticId.RedundantFieldAssignment], isEnabledByDefault: true, customTags: WellKnownDiagnosticTags.Unnecessary, description: Description, diff --git a/src/CSharp/CodeCracker/Usage/RegexAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RegexAnalyzer.cs index f9ab98f87..1f869aece 100644 --- a/src/CSharp/CodeCracker/Usage/RegexAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RegexAnalyzer.cs @@ -20,7 +20,7 @@ public class RegexAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.Regex], + SeverityConfigurations.CurrentCS[DiagnosticId.Regex], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.Regex)); diff --git a/src/CSharp/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.cs index fc15aa3f9..99db4b28c 100644 --- a/src/CSharp/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.cs @@ -24,7 +24,7 @@ public class RemovePrivateMethodNeverUsedAnalyzer : DiagnosticAnalyzer Title, Message, Category, - SeverityConfigurations.Current[DiagnosticId.RemovePrivateMethodNeverUsed], + SeverityConfigurations.CurrentCS[DiagnosticId.RemovePrivateMethodNeverUsed], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemovePrivateMethodNeverUsed)); diff --git a/src/CSharp/CodeCracker/Usage/RemoveRedundantElseClauseAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RemoveRedundantElseClauseAnalyzer.cs index 6573a22c7..1f4bcf811 100644 --- a/src/CSharp/CodeCracker/Usage/RemoveRedundantElseClauseAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RemoveRedundantElseClauseAnalyzer.cs @@ -19,7 +19,7 @@ public class RemoveRedundantElseClauseAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.RemoveRedundantElseClause], + SeverityConfigurations.CurrentCS[DiagnosticId.RemoveRedundantElseClause], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RemoveRedundantElseClause)); diff --git a/src/CSharp/CodeCracker/Usage/RethrowExceptionAnalyzer.cs b/src/CSharp/CodeCracker/Usage/RethrowExceptionAnalyzer.cs index 086fc30dd..8d1b35508 100644 --- a/src/CSharp/CodeCracker/Usage/RethrowExceptionAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/RethrowExceptionAnalyzer.cs @@ -21,7 +21,7 @@ public class RethrowExceptionAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.RethrowException], + SeverityConfigurations.CurrentCS[DiagnosticId.RethrowException], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.RethrowException)); diff --git a/src/CSharp/CodeCracker/Usage/SimplifyRedundantBooleanComparisonsAnalyzer.cs b/src/CSharp/CodeCracker/Usage/SimplifyRedundantBooleanComparisonsAnalyzer.cs index d0c7b44e6..492c56b6e 100644 --- a/src/CSharp/CodeCracker/Usage/SimplifyRedundantBooleanComparisonsAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/SimplifyRedundantBooleanComparisonsAnalyzer.cs @@ -18,7 +18,7 @@ public class SimplifyRedundantBooleanComparisonsAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.SimplifyRedundantBooleanComparisons], + SeverityConfigurations.CurrentCS[DiagnosticId.SimplifyRedundantBooleanComparisons], isEnabledByDefault: true, customTags: WellKnownDiagnosticTags.Unnecessary, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.SimplifyRedundantBooleanComparisons)); diff --git a/src/CSharp/CodeCracker/Usage/StringFormatArgsAnalyzer.cs b/src/CSharp/CodeCracker/Usage/StringFormatArgsAnalyzer.cs index 36aec816e..7aa3053df 100644 --- a/src/CSharp/CodeCracker/Usage/StringFormatArgsAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/StringFormatArgsAnalyzer.cs @@ -23,7 +23,7 @@ public class StringFormatArgsAnalyzer : DiagnosticAnalyzer Title, IncorrectNumberOfArgsMessage, Category, - SeverityConfigurations.Current[DiagnosticId.StringFormatArgs_ExtraArgs], + SeverityConfigurations.CurrentCS[DiagnosticId.StringFormatArgs_ExtraArgs], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringFormatArgs_ExtraArgs)); @@ -33,7 +33,7 @@ public class StringFormatArgsAnalyzer : DiagnosticAnalyzer Title, InvalidArgsReferenceMessage, Category, - SeverityConfigurations.Current[DiagnosticId.StringFormatArgs_InvalidArgs], + SeverityConfigurations.CurrentCS[DiagnosticId.StringFormatArgs_InvalidArgs], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.StringFormatArgs_InvalidArgs)); diff --git a/src/CSharp/CodeCracker/Usage/UnusedParametersAnalyzer.cs b/src/CSharp/CodeCracker/Usage/UnusedParametersAnalyzer.cs index 49236df09..bee655b2c 100644 --- a/src/CSharp/CodeCracker/Usage/UnusedParametersAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/UnusedParametersAnalyzer.cs @@ -22,7 +22,7 @@ public class UnusedParametersAnalyzer : DiagnosticAnalyzer Title, Message, Category, - SeverityConfigurations.Current[DiagnosticId.UnusedParameters], + SeverityConfigurations.CurrentCS[DiagnosticId.UnusedParameters], isEnabledByDefault: true, description: Description, customTags: WellKnownDiagnosticTags.Unnecessary, diff --git a/src/CSharp/CodeCracker/Usage/UriAnalyzer.cs b/src/CSharp/CodeCracker/Usage/UriAnalyzer.cs index b3e5e0049..24c766c87 100644 --- a/src/CSharp/CodeCracker/Usage/UriAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/UriAnalyzer.cs @@ -22,7 +22,7 @@ public class UriAnalyzer : DiagnosticAnalyzer Title, MessageFormat, Category, - SeverityConfigurations.Current[DiagnosticId.Uri], + SeverityConfigurations.CurrentCS[DiagnosticId.Uri], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.Uri)); diff --git a/src/CSharp/CodeCracker/Usage/VirtualMethodOnConstructorAnalyzer.cs b/src/CSharp/CodeCracker/Usage/VirtualMethodOnConstructorAnalyzer.cs index b1283e7e0..adfd9334e 100644 --- a/src/CSharp/CodeCracker/Usage/VirtualMethodOnConstructorAnalyzer.cs +++ b/src/CSharp/CodeCracker/Usage/VirtualMethodOnConstructorAnalyzer.cs @@ -23,7 +23,7 @@ public class VirtualMethodOnConstructorAnalyzer : DiagnosticAnalyzer Title, Message, Category, - SeverityConfigurations.Current[DiagnosticId.VirtualMethodOnConstructor], + SeverityConfigurations.CurrentCS[DiagnosticId.VirtualMethodOnConstructor], isEnabledByDefault: true, description: Description, helpLinkUri: HelpLink.ForDiagnostic(DiagnosticId.VirtualMethodOnConstructor)); diff --git a/src/Common/CodeCracker.Common/SeverityConfigurations.cs b/src/Common/CodeCracker.Common/SeverityConfigurations.cs index e67a2e592..0dedbc486 100644 --- a/src/Common/CodeCracker.Common/SeverityConfigurations.cs +++ b/src/Common/CodeCracker.Common/SeverityConfigurations.cs @@ -1,9 +1,11 @@ using Microsoft.CodeAnalysis; using System; +using System.Collections; using System.Collections.Concurrent; using System.Collections.Generic; using System.Linq; using System.Text; +using System.Threading; using System.Threading.Tasks; namespace CodeCracker @@ -14,26 +16,50 @@ namespace CodeCracker public class SeverityConfigurations { /// - /// Gets the DiagnosticSeverities that is configured by the user. + /// Gets the DiagnosticSeverities that is configured by the user in VB language. /// - public static SeverityConfigurations Current { get; } = new SeverityConfigurations(); + public static SeverityConfigurations CurrentVB => _vbDefault.Value; /// - /// Gets the default DiagnosticSeverities of all DiagnosticIds. + /// Gets the DiagnosticSeverities that is configured by the user in C# language. /// - public static SeverityConfigurations Default { get; } = new SeverityConfigurations(); + public static SeverityConfigurations CurrentCS => _csDefault.Value; /// - /// Stores all the DiagnosticSeverities. + /// Gets the default DiagnosticSeverities of all DiagnosticIds. /// - private readonly ConcurrentDictionary _diagnosticSeverities; + public static SeverityConfigurations Default => _default.Value; /// /// Initialize a new instance of . /// - private SeverityConfigurations() + /// The differential to the default values. + private SeverityConfigurations(IDictionary additional = null) { - var values = new Dictionary + if (additional != null) + { + foreach (var pair in additional) + { + _diagnosticSeverities[pair.Key] = pair.Value; + } + } + } + + /// + /// Gets the of the specified . + /// + /// The which you want to get the . + /// The of the specified . + public DiagnosticSeverity this[DiagnosticId id] + => _diagnosticSeverities.TryGetValue(id, out var value) + ? value + : DiagnosticSeverity.Warning; + + /// + /// Stores all the DiagnosticSeverities. + /// + private readonly ConcurrentDictionary _diagnosticSeverities + = new ConcurrentDictionary(new Dictionary { { DiagnosticId.None, DiagnosticSeverity.Hidden }, { DiagnosticId.AlwaysUseVar, DiagnosticSeverity.Warning }, @@ -118,18 +144,29 @@ private SeverityConfigurations() { DiagnosticId.SwitchCaseWithoutDefault, DiagnosticSeverity.Warning }, { DiagnosticId.ReadOnlyComplexTypes, DiagnosticSeverity.Warning }, { DiagnosticId.ReplaceWithGetterOnlyAutoProperty, DiagnosticSeverity.Hidden }, - }; - _diagnosticSeverities = new ConcurrentDictionary(values); - } + }); /// - /// Gets the of the specified . + /// Lazy initialize value for . /// - /// The which you want to get the . - /// The of the specified . - public DiagnosticSeverity this[DiagnosticId id] - => _diagnosticSeverities.TryGetValue(id, out var value) - ? value - : DiagnosticSeverity.Warning; + private static readonly Lazy _vbDefault = new Lazy(() + => new SeverityConfigurations(new Dictionary + { + // These are the differantials to the C# version. + { DiagnosticId.TernaryOperator_Assignment, DiagnosticSeverity.Warning }, + { DiagnosticId.TernaryOperator_Return, DiagnosticSeverity.Warning }, + }), LazyThreadSafetyMode.ExecutionAndPublication); + + /// + /// Lazy initialize value for . + /// + private static readonly Lazy _csDefault = new Lazy(() + => new SeverityConfigurations(), LazyThreadSafetyMode.ExecutionAndPublication); + + /// + /// Lazy initialize value for default. + /// + private static readonly Lazy _default = new Lazy(() + => new SeverityConfigurations(), LazyThreadSafetyMode.ExecutionAndPublication); } } diff --git a/src/VisualBasic/CodeCracker/Design/CatchEmptyAnalyzer.vb b/src/VisualBasic/CodeCracker/Design/CatchEmptyAnalyzer.vb index c3282e01c..f5a7f288c 100644 --- a/src/VisualBasic/CodeCracker/Design/CatchEmptyAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Design/CatchEmptyAnalyzer.vb @@ -17,7 +17,7 @@ Namespace Design Title, MessageFormat, Category, - SeverityConfigurations.Current(DiagnosticId.CatchEmpty), + SeverityConfigurations.CurrentVB(DiagnosticId.CatchEmpty), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.CatchEmpty)) diff --git a/src/VisualBasic/CodeCracker/Design/EmptyCatchBlockAnalyzer.vb b/src/VisualBasic/CodeCracker/Design/EmptyCatchBlockAnalyzer.vb index 3383c37be..62068cd6a 100644 --- a/src/VisualBasic/CodeCracker/Design/EmptyCatchBlockAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Design/EmptyCatchBlockAnalyzer.vb @@ -20,7 +20,7 @@ If the error is expected, consider logging it or changing the control flow such Title, MessageFormat, Category, - SeverityConfigurations.Current(DiagnosticId.EmptyCatchBlock), + SeverityConfigurations.CurrentVB(DiagnosticId.EmptyCatchBlock), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.EmptyCatchBlock)) diff --git a/src/VisualBasic/CodeCracker/Design/NameOfAnalyzer.vb b/src/VisualBasic/CodeCracker/Design/NameOfAnalyzer.vb index cbe6a24a6..1854d8318 100644 --- a/src/VisualBasic/CodeCracker/Design/NameOfAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Design/NameOfAnalyzer.vb @@ -20,7 +20,7 @@ Namespace Design Title, MessageFormat, Category, - SeverityConfigurations.Current(DiagnosticId.NameOf), + SeverityConfigurations.CurrentVB(DiagnosticId.NameOf), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.NameOf)) @@ -29,7 +29,7 @@ Namespace Design Title, MessageFormat, Category, - SeverityConfigurations.Current(DiagnosticId.NameOf_External), + SeverityConfigurations.CurrentVB(DiagnosticId.NameOf_External), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.NameOf_External)) diff --git a/src/VisualBasic/CodeCracker/Design/StaticConstructorExceptionAnalyzer.vb b/src/VisualBasic/CodeCracker/Design/StaticConstructorExceptionAnalyzer.vb index df103982a..3bfb359b7 100644 --- a/src/VisualBasic/CodeCracker/Design/StaticConstructorExceptionAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Design/StaticConstructorExceptionAnalyzer.vb @@ -19,7 +19,7 @@ Namespace Design Title, MessageFormat, Category, - SeverityConfigurations.Current(DiagnosticId.StaticConstructorException), + SeverityConfigurations.CurrentVB(DiagnosticId.StaticConstructorException), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.StaticConstructorException)) diff --git a/src/VisualBasic/CodeCracker/Performance/MakeLocalVariableConstWhenPossibleAnalyzer.vb b/src/VisualBasic/CodeCracker/Performance/MakeLocalVariableConstWhenPossibleAnalyzer.vb index 46901c1a5..01c818015 100644 --- a/src/VisualBasic/CodeCracker/Performance/MakeLocalVariableConstWhenPossibleAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Performance/MakeLocalVariableConstWhenPossibleAnalyzer.vb @@ -19,7 +19,7 @@ Namespace Performance Title, MessageFormat, Category, - SeverityConfigurations.Current(DiagnosticId.MakeLocalVariableConstWhenItIsPossible), + SeverityConfigurations.CurrentVB(DiagnosticId.MakeLocalVariableConstWhenItIsPossible), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.MakeLocalVariableConstWhenItIsPossible)) diff --git a/src/VisualBasic/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.vb b/src/VisualBasic/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.vb index b2e9db4ae..28c5ac103 100644 --- a/src/VisualBasic/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Performance/RemoveWhereWhenItIsPossibleAnalyzer.vb @@ -19,7 +19,7 @@ Namespace Performance Title, MessageFormat, Category, - SeverityConfigurations.Current(DiagnosticId.RemoveWhereWhenItIsPossible), + SeverityConfigurations.CurrentVB(DiagnosticId.RemoveWhereWhenItIsPossible), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.RemoveWhereWhenItIsPossible)) diff --git a/src/VisualBasic/CodeCracker/Performance/SealedAttributeAnalyzer.vb b/src/VisualBasic/CodeCracker/Performance/SealedAttributeAnalyzer.vb index cc772307e..fd7a0573a 100644 --- a/src/VisualBasic/CodeCracker/Performance/SealedAttributeAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Performance/SealedAttributeAnalyzer.vb @@ -17,7 +17,7 @@ Namespace Performance Title, MessageFormat, Category, - SeverityConfigurations.Current(DiagnosticId.SealedAttribute), + SeverityConfigurations.CurrentVB(DiagnosticId.SealedAttribute), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.SealedAttribute)) diff --git a/src/VisualBasic/CodeCracker/Performance/StringBuilderInLoopAnalyzer.vb b/src/VisualBasic/CodeCracker/Performance/StringBuilderInLoopAnalyzer.vb index 8e22e84e0..676684327 100644 --- a/src/VisualBasic/CodeCracker/Performance/StringBuilderInLoopAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Performance/StringBuilderInLoopAnalyzer.vb @@ -19,7 +19,7 @@ Namespace Performance Title, MessageFormat, Category, - SeverityConfigurations.Current(DiagnosticId.StringBuilderInLoop), + SeverityConfigurations.CurrentVB(DiagnosticId.StringBuilderInLoop), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.StringBuilderInLoop)) diff --git a/src/VisualBasic/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.vb b/src/VisualBasic/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.vb index 909bfcabb..c3742351d 100644 --- a/src/VisualBasic/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Refactoring/AllowMembersOrderingAnalyzer.vb @@ -19,7 +19,7 @@ Namespace Refactoring Title, MessageFormat, Category, - SeverityConfigurations.Current(DiagnosticId.AllowMembersOrdering), + SeverityConfigurations.CurrentVB(DiagnosticId.AllowMembersOrdering), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.AllowMembersOrdering)) diff --git a/src/VisualBasic/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.vb b/src/VisualBasic/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.vb index 5d30a6517..607b7edb0 100644 --- a/src/VisualBasic/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Refactoring/ChangeAnyToAllAnalyzer.vb @@ -20,7 +20,7 @@ Namespace Refactoring TitleAny, MessageAny, Category, - SeverityConfigurations.Current(DiagnosticId.ChangeAnyToAll), + SeverityConfigurations.CurrentVB(DiagnosticId.ChangeAnyToAll), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.ChangeAnyToAll)) Friend Shared RuleAll As New DiagnosticDescriptor( @@ -28,7 +28,7 @@ Namespace Refactoring TitleAll, MessageAll, Category, - SeverityConfigurations.Current(DiagnosticId.ChangeAllToAny), + SeverityConfigurations.CurrentVB(DiagnosticId.ChangeAllToAny), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.ChangeAllToAny)) diff --git a/src/VisualBasic/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.vb b/src/VisualBasic/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.vb index f2ce229f5..ec39234ce 100644 --- a/src/VisualBasic/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Reliability/UseConfigureAwaitFalseAnalyzer.vb @@ -20,7 +20,7 @@ Namespace Reliability Title, MessageFormat, Category, - SeverityConfigurations.Current(DiagnosticId.UseConfigureAwaitFalse), + SeverityConfigurations.CurrentVB(DiagnosticId.UseConfigureAwaitFalse), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.UseConfigureAwaitFalse)) diff --git a/src/VisualBasic/CodeCracker/Style/TernaryOperatorAnalyzer.vb b/src/VisualBasic/CodeCracker/Style/TernaryOperatorAnalyzer.vb index 07eece8ee..097b88c12 100644 --- a/src/VisualBasic/CodeCracker/Style/TernaryOperatorAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Style/TernaryOperatorAnalyzer.vb @@ -17,7 +17,7 @@ Namespace Style Title, MessageFormat, SupportedCategories.Style, - SeverityConfigurations.Current(DiagnosticId.TernaryOperator_Return), + SeverityConfigurations.CurrentVB(DiagnosticId.TernaryOperator_Return), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Return)) @@ -26,7 +26,7 @@ Namespace Style Title, MessageFormat, SupportedCategories.Style, - SeverityConfigurations.Current(DiagnosticId.TernaryOperator_Assignment), + SeverityConfigurations.CurrentVB(DiagnosticId.TernaryOperator_Assignment), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Assignment)) @@ -35,7 +35,7 @@ Namespace Style Title, MessageFormat, SupportedCategories.Style, - SeverityConfigurations.Current(DiagnosticId.TernaryOperator_Iif), + SeverityConfigurations.CurrentVB(DiagnosticId.TernaryOperator_Iif), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.TernaryOperator_Iif)) diff --git a/src/VisualBasic/CodeCracker/Usage/ArgumentExceptionAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/ArgumentExceptionAnalyzer.vb index d9cfcc062..803648820 100644 --- a/src/VisualBasic/CodeCracker/Usage/ArgumentExceptionAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/ArgumentExceptionAnalyzer.vb @@ -18,7 +18,7 @@ It can be either specified directly or using nameof() (VB 14 and above only)." Title, MessageFormat, SupportedCategories.Naming, - SeverityConfigurations.Current(DiagnosticId.ArgumentException), + SeverityConfigurations.CurrentVB(DiagnosticId.ArgumentException), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.ArgumentException)) diff --git a/src/VisualBasic/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.vb index adb3a4642..6f0a69c66 100644 --- a/src/VisualBasic/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/DisposableFieldNotDisposedAnalyzer.vb @@ -18,7 +18,7 @@ Namespace Usage Title, MessageFormat, SupportedCategories.Usage, - SeverityConfigurations.Current(DiagnosticId.DisposableFieldNotDisposed_Returned), + SeverityConfigurations.CurrentVB(DiagnosticId.DisposableFieldNotDisposed_Returned), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.DisposableFieldNotDisposed_Returned)) @@ -28,7 +28,7 @@ Namespace Usage Title, MessageFormat, SupportedCategories.Usage, - SeverityConfigurations.Current(DiagnosticId.DisposableFieldNotDisposed_Created), + SeverityConfigurations.CurrentVB(DiagnosticId.DisposableFieldNotDisposed_Created), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.DisposableFieldNotDisposed_Created)) diff --git a/src/VisualBasic/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.vb index 9a0009272..654a84788 100644 --- a/src/VisualBasic/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/DisposablesShouldCallSuppressFinalizeAnalyzer.vb @@ -20,7 +20,7 @@ This rule should be followed even if the class doesn't have a finalizer in a der Title, MessageFormat, SupportedCategories.Naming, - SeverityConfigurations.Current(DiagnosticId.DisposablesShouldCallSuppressFinalize), + SeverityConfigurations.CurrentVB(DiagnosticId.DisposablesShouldCallSuppressFinalize), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.DisposablesShouldCallSuppressFinalize)) diff --git a/src/VisualBasic/CodeCracker/Usage/IPAddressAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/IPAddressAnalyzer.vb index 8191d2ea2..621bb883b 100644 --- a/src/VisualBasic/CodeCracker/Usage/IPAddressAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/IPAddressAnalyzer.vb @@ -18,7 +18,7 @@ Public Class IPAddressAnalyzer Title, MessageFormat, SupportedCategories.Usage, - SeverityConfigurations.Current(DiagnosticId.IPAddress), + SeverityConfigurations.CurrentVB(DiagnosticId.IPAddress), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.IPAddress)) diff --git a/src/VisualBasic/CodeCracker/Usage/JsonNetAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/JsonNetAnalyzer.vb index 3783073d1..5689dfac4 100644 --- a/src/VisualBasic/CodeCracker/Usage/JsonNetAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/JsonNetAnalyzer.vb @@ -19,7 +19,7 @@ Namespace Usage Title, MessageFormat, SupportedCategories.Usage, - SeverityConfigurations.Current(DiagnosticId.JsonNet), + SeverityConfigurations.CurrentVB(DiagnosticId.JsonNet), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.JsonNet)) diff --git a/src/VisualBasic/CodeCracker/Usage/MustInheritClassShouldNotHavePublicConstructorsAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/MustInheritClassShouldNotHavePublicConstructorsAnalyzer.vb index b76d30a2f..d931fea4d 100644 --- a/src/VisualBasic/CodeCracker/Usage/MustInheritClassShouldNotHavePublicConstructorsAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/MustInheritClassShouldNotHavePublicConstructorsAnalyzer.vb @@ -17,7 +17,7 @@ Namespace Usage Title, MessageFormat, SupportedCategories.Usage, - SeverityConfigurations.Current(DiagnosticId.AbstractClassShouldNotHavePublicCtors), + SeverityConfigurations.CurrentVB(DiagnosticId.AbstractClassShouldNotHavePublicCtors), isEnabledByDefault:=True, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.AbstractClassShouldNotHavePublicCtors)) diff --git a/src/VisualBasic/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.vb b/src/VisualBasic/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.vb index f372c1518..fc6efd46a 100644 --- a/src/VisualBasic/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.vb +++ b/src/VisualBasic/CodeCracker/Usage/RemovePrivateMethodNeverUsedAnalyzer.vb @@ -18,7 +18,7 @@ Namespace Usage Title, Message, SupportedCategories.Usage, - SeverityConfigurations.Current(DiagnosticId.RemovePrivateMethodNeverUsed), + SeverityConfigurations.CurrentVB(DiagnosticId.RemovePrivateMethodNeverUsed), isEnabledByDefault:=True, description:=Description, helpLinkUri:=HelpLink.ForDiagnostic(DiagnosticId.RemovePrivateMethodNeverUsed))