fix a memleak in tiff pyr to memory

jcupitt · jcupitt · commit dc16f1253a62 · 2019-06-06T10:20:14.000+01:00
we were not freeing layers other than the top layer
diff --git a/ChangeLog b/ChangeLog
@@ -3,6 +3,7 @@
 - better magickload error messages
 - more consistent behaviour for page-height metadata
 - fix for composite with many small images and some combinations of blend modes
+- fix memleak in tiff pyr save to memory [scossu]
 
 21/9/18 started 8.8.0
 - much faster smartcrop [lovell]
diff --git a/libvips/foreign/tiff.c b/libvips/foreign/tiff.c
@@ -418,6 +418,9 @@ vips__tiff_openout_buffer( VipsImage *image,
 	printf( "vips__tiff_openout_buffer:\n" );
 #endif /*DEBUG*/
 
+	g_assert( out_data );
+	g_assert( out_length );
+
 	buffer = VIPS_NEW( image, VipsTiffOpenoutBuffer );
 	vips_dbuf_init( &buffer->dbuf );
 	buffer->out_data = out_data;
diff --git a/libvips/foreign/vips2tiff.c b/libvips/foreign/vips2tiff.c
@@ -835,6 +835,7 @@ layer_free( Layer *layer )
 	VIPS_UNREF( layer->strip );
 	VIPS_UNREF( layer->copy );
 	VIPS_UNREF( layer->image );
+	VIPS_FREE( layer->buf );
 	VIPS_FREEF( TIFFClose, layer->tif );
 }
 

Original file line number	Diff line number	Diff line change
`@@ -835,6 +835,7 @@ layer_free( Layer *layer )`
`835`	`835`	`VIPS_UNREF( layer->strip );`
`836`	`836`	`VIPS_UNREF( layer->copy );`
`837`	`837`	`VIPS_UNREF( layer->image );`
	`838`	`+ VIPS_FREE( layer->buf );`
`838`	`839`	`VIPS_FREEF( TIFFClose, layer->tif );`
`839`	`840`	`}`
`840`	`841`