From 3e6415cec8b281f69c68e47c57a2ad84acda3eec Mon Sep 17 00:00:00 2001 From: kobenguyent <7845001+kobenguyent@users.noreply.github.com> Date: Wed, 11 Dec 2024 10:35:00 +0100 Subject: [PATCH 1/2] fix(cli): missing failure counts when there is failedHooks (#4633) --- lib/cli.js | 1 - test/runner/before_failure_test.js | 4 ++-- test/runner/run_workers_test.js | 3 ++- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/cli.js b/lib/cli.js index 0d02c7765..410f8f89e 100644 --- a/lib/cli.js +++ b/lib/cli.js @@ -219,7 +219,6 @@ class Cli extends Base { this.failures.forEach((failure) => { if (failure.constructor.name === 'Hook') { - stats.failures -= stats.failures stats.failedHooks += 1 } }) diff --git a/test/runner/before_failure_test.js b/test/runner/before_failure_test.js index 6c54ecb33..6e5912589 100644 --- a/test/runner/before_failure_test.js +++ b/test/runner/before_failure_test.js @@ -12,7 +12,7 @@ describe('Failure in before', function () { stdout.should.include('First test will be passed @grep') stdout.should.include('Third test will be skipped @grep') stdout.should.include('Fourth test will be skipped') - stdout.should.include('1 passed, 1 failedHooks, 2 skipped') + stdout.should.include('1 passed, 1 failed, 1 failedHooks, 2 skipped') err.code.should.eql(1) done() }) @@ -22,7 +22,7 @@ describe('Failure in before', function () { exec(`${codecept_run} --grep @grep`, (err, stdout) => { stdout.should.include('First test will be passed @grep') stdout.should.include('Third test will be skipped @grep') - stdout.should.include('1 passed, 1 failedHooks, 1 skipped') + stdout.should.include('1 passed, 1 failed, 1 failedHooks, 1 skipped') err.code.should.eql(1) done() }) diff --git a/test/runner/run_workers_test.js b/test/runner/run_workers_test.js index 7bbfa6b4c..89f121ffd 100644 --- a/test/runner/run_workers_test.js +++ b/test/runner/run_workers_test.js @@ -44,7 +44,8 @@ describe('CodeceptJS Workers Runner', function () { expect(stdout).not.toContain('this is running inside worker') expect(stdout).toContain('failed') expect(stdout).toContain('File notafile not found') - expect(stdout).toContain('5 passed, 1 failed, 1 failedHooks') + expect(stdout).toContain('Scenario Steps:') + expect(stdout).toContain('5 passed, 2 failed, 1 failedHooks') // We are not testing order in logs, because it depends on race condition between workers expect(stdout).toContain(') Workers Failing\n') // first fail log expect(stdout).toContain(') Workers\n') // second fail log From 5abda109da22b90ad9df003274bd511e45002543 Mon Sep 17 00:00:00 2001 From: kobenguyent <7845001+kobenguyent@users.noreply.github.com> Date: Wed, 11 Dec 2024 10:38:58 +0100 Subject: [PATCH 2/2] release 3.6.10 (#4635) --- CHANGELOG.md | 14 ++++++++++++++ package.json | 4 ++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7c769257c..5fc27f979 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,17 @@ +## 3.6.10 + +❤️ Thanks all to those who contributed to make this release! ❤️ + +🐛 *Bug Fixes* +fix(cli): missing failure counts when there is failedHooks (#4633) - by @kobenguyent + +## 3.6.9 + +❤️ Thanks all to those who contributed to make this release! ❤️ + +🐛 *Hot Fixes* +fix: could not run tests due to missing `invisi-data` lib - by @kobenguyent + ## 3.6.8 ❤️ Thanks all to those who contributed to make this release! ❤️ diff --git a/package.json b/package.json index a3fc44c48..e161753ef 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "codeceptjs", - "version": "3.6.9", + "version": "3.6.10", "description": "Supercharged End 2 End Testing Framework for NodeJS", "keywords": [ "acceptance", @@ -184,4 +184,4 @@ "strict": false } } -} +} \ No newline at end of file