Add missing return type hints to the methods of the SentryExtension class (getsentry#563)

eerison · Jean85 · ste93cry · web-flow · commit be9b0653313c · 2021-10-05T09:38:33.000+02:00
* maintenance/add-type-hin-in-sentry-extension

* Update CHANGELOG.md

Co-authored-by: Alessandro Lai &lt;alessandro.lai85@gmail.com&gt;

* Update CHANGELOG.md

Co-authored-by: Stefano Arlandini &lt;sarlandini@alice.it&gt;

Co-authored-by: Alessandro Lai &lt;alessandro.lai85@gmail.com&gt;
Co-authored-by: Stefano Arlandini &lt;sarlandini@alice.it&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- Add return typehints to the methods of the `SentryExtension` class to prepare for Symfony 6 (#563)
+
 ## 4.2.3 (2021-09-21)
 
 - Fix: Test if `TracingStatement` exists before attempting to create the class alias, otherwise it breaks when opcache is enabled. (#552)
diff --git a/src/DependencyInjection/SentryExtension.php b/src/DependencyInjection/SentryExtension.php
@@ -43,15 +43,15 @@ final class SentryExtension extends ConfigurableExtension
     /**
      * {@inheritdoc}
      */
-    public function getXsdValidationBasePath()
+    public function getXsdValidationBasePath(): string
     {
         return __DIR__ . '/../Resources/config/schema';
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getNamespace()
+    public function getNamespace(): string
     {
         return 'https://sentry.io/schema/dic/sentry-symfony';
     }

Original file line number	Diff line number	Diff line change
`@@ -43,15 +43,15 @@ final class SentryExtension extends ConfigurableExtension`
`43`	`43`	`/**`
`44`	`44`	`* {@inheritdoc}`
`45`	`45`	`*/`
`46`		`- public function getXsdValidationBasePath()`
	`46`	`+ public function getXsdValidationBasePath(): string`
`47`	`47`	`{`
`48`	`48`	`return __DIR__ . '/../Resources/config/schema';`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`/**`
`52`	`52`	`* {@inheritdoc}`
`53`	`53`	`*/`
`54`		`- public function getNamespace()`
	`54`	`+ public function getNamespace(): string`
`55`	`55`	`{`
`56`	`56`	`return 'https://sentry.io/schema/dic/sentry-symfony';`
`57`	`57`	`}`