Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 31, 2020. It is now read-only.

Commit 29dcbde

Browse files
hgallopSchaeStewart
authored andcommitted
Accessibility Improvements (#67)
* Replace Favicon. Add alt Attribute to logo. Add target attribute to footer link and Join page links. Replace favicon and add touch icon. Add alt attribute to img tag for logo to improve accessibility. Add target attribute with value of blank on link to github, meetup and slack. Add padding to slack and meetup logos. * Repair page overflowing container. Remove duplicate H1. Remove the combination of hard-coded heights and margins to allow page to flow naturally. Remove unused H1 tag from page.js to improve SEO performance and accessibility. Format links in join.js to match. * Accessibility Improvements Adjust nav/header color to improve contrast for accessibility. Convert h5 tags in About page to p tags with a class of content-heading to improve accessibility. Convert Leadership heading to an h2 tag to imrove SEO and accessibility.
1 parent 502d835 commit 29dcbde

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

pages/about.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const About = () => (
2626
through technology.
2727
</p>
2828

29-
<h5>For Example</h5>
29+
<p className="content-heading">For Example</p>
3030

3131
<p>
3232
What sorts of projects do we do? Mapping and recording the
@@ -38,7 +38,7 @@ const About = () => (
3838
an entire city — can sometimes be forgotten.
3939
</p>
4040

41-
<h5>Is This Just For Coders?</h5>
41+
<p className="content-heading">Is This Just For Coders?</p>
4242

4343
<p>
4444
The short answer is, {'"'}nope{'"'}. We need people from all
@@ -51,7 +51,7 @@ const About = () => (
5151
we need the <em>community</em>.
5252
</p>
5353

54-
<h5>What goes on at our meetups?</h5>
54+
<p className="content-heading">What goes on at our meetups?</p>
5555

5656
<p>
5757
We start every meetup with introductions and a welcome to
@@ -85,7 +85,7 @@ const About = () => (
8585
</p>
8686
</div>
8787
</div>
88-
<h1 className="subtitle is-2 content">LeaderShip</h1>
88+
<h2 className="subtitle is-2 content">Leadership</h2>
8989
<div className="content container">add content</div>
9090
<h2 className="subtitle is-2">Sponsors</h2>
9191
<div className="content container">add content</div>

styles.scss

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
// app colors
44
$red: hsl(9, 69%, 49%);
5-
$green: hsl(180, 76%, 31%);
5+
$green: hsl(180, 76%, 29%);
66
$lightgreen: hsl(180, 76%, 40%);
77
$text-white: hsl(0, 0%, 100%);
88
$text-black: hsl(3, 0%, 0%);
@@ -163,6 +163,14 @@ footer a:hover {
163163
object-position: 100% 25%;
164164
}
165165

166+
.content-heading {
167+
color: #363636;
168+
font-weight: 600;
169+
line-height: 1.125;
170+
font-size: 1.125em;
171+
margin-bottom: 0.8888em;
172+
}
173+
166174
.home .hero-image img {
167175
object-position: 0% 40%;
168176
}

0 commit comments

Comments
 (0)