Fix port parseInt error handling

code-asher · code-asher · commit 9bd3b83ef56c · 2025-05-08T14:21:17.000-08:00
parseInt returns NaN rather than throwing.
diff --git a/src/node/routes/pathProxy.ts b/src/node/routes/pathProxy.ts
@@ -13,10 +13,8 @@ const getProxyTarget = (
 ): string => {
   // If there is a base path, strip it out.
   const base = (req as any).base || ""
-  let port: number
-  try {
-    port = parseInt(req.params.port, 10)
-  } catch (err) {
+  const port = parseInt(req.params.port, 10)
+  if (isNaN(port)) {
     throw new HttpError("Invalid port", HttpCode.BadRequest)
   }
   return `http://0.0.0.0:${port}${opts?.proxyBasePath || ""}/${req.originalUrl.slice(base.length)}`
