Fix destroying response in update again

code-asher · code-asher · commit ef7ce56c0d11 · 2020-11-05T15:03:50.000-06:00
I added another reject that doesn't destroy the response.
diff --git a/src/node/update.ts b/src/node/update.ts
@@ -111,14 +111,13 @@ export class UpdateProvider {
 
           if (response.statusCode >= 300) {
             ++redirects
+            response.destroy()
             if (redirects > maxRedirects) {
-              response.destroy()
               return reject(new Error("reached max redirects"))
             }
             if (!response.headers.location) {
               return reject(new Error("received redirect with no location header"))
             }
-            response.destroy()
             return request(url.resolve(uri, response.headers.location))
           }
 

Original file line number	Diff line number	Diff line change
`@@ -111,14 +111,13 @@ export class UpdateProvider {`
`111`	`111`
`112`	`112`	`if (response.statusCode >= 300) {`
`113`	`113`	`++redirects`
	`114`	`+ response.destroy()`
`114`	`115`	`if (redirects > maxRedirects) {`
`115`		`- response.destroy()`
`116`	`116`	`return reject(new Error("reached max redirects"))`
`117`	`117`	`}`
`118`	`118`	`if (!response.headers.location) {`
`119`	`119`	`return reject(new Error("received redirect with no location header"))`
`120`	`120`	`}`
`121`		`- response.destroy()`
`122`	`121`	`return request(url.resolve(uri, response.headers.location))`
`123`	`122`	`}`
`124`	`123`