Thanks to visit codestin.com
Credit goes to github.com

Skip to content

vscode-workspace-switcher extension issue #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xcke opened this issue Oct 28, 2019 · 9 comments
Closed

vscode-workspace-switcher extension issue #1121

xcke opened this issue Oct 28, 2019 · 9 comments
Assignees
@code-asher
Labels
bug Something isn't working

Comments

@xcke
Copy link

xcke commented Oct 28, 2019

Hi All,

I am wondering if this feature should work? Currently having this issue. What should be the path to "vs code binary"? Path to the executable file for VS Code. For Example with code-server I got this error with the extension:

`Command failed: code-server -r "/config/workspace/ansible-napalm-samples.code-workspace"
/config/workspace/ansible-napalm-samples.code-workspace:1
(function (exports, require, module, __filename, __dirname) { {"folders":[{"path":"/config/ansible-napalm-samples"}],"settings":{}}
^

SyntaxError: Unexpected token :
at new Script (vm.js:79:7)
at createScript (vm.js:251:10)
at Object.runInThisContext (vm.js:303:10)
at Module._compile (internal/modules/cjs/loader.js:669:28)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:717:10)
at Module.load (internal/modules/cjs/loader.js:611:32)
at tryModuleLoad (internal/modules/cjs/loader.js:550:12)
at Function.Module._load (internal/modules/cjs/loader.js:542:3)
at Module.require (internal/modules/cjs/loader.js:649:17)
at Module._preloadModules (internal/modules/cjs/loader.js:848:12)
`

Best Regards,
Gabor
@xcke xcke added the question label Oct 28, 2019
code-asher added a commit that referenced this issue Oct 28, 2019
@code-asher
Strip internal env vars when spawning the shell
197d0b6 
This should fix all those reports of code-server dropping straight to
Node and things like #1121.
code-asher added a commit that referenced this issue Oct 28, 2019
@code-asher
Support opening workspaces from command line
e229649 
Partly addresses #1121.
@code-asher
Copy link
Member

I believe I've fixed this particular error but the vscode-workspace-switcher extension still doesn't work so we'll need to look into that further.

code-server doesn't support the -r flag yet: #164.

@code-asher code-asher added bug Something isn't working and removed question labels Oct 28, 2019
@xcke
Copy link
Author

xcke commented Nov 11, 2019 via email

@code-asher
Copy link
Member

code-asher commented Nov 14, 2019 via email

@nhooyr
Copy link
Contributor

nhooyr commented Jan 29, 2020

It seems to be broken in VS Code as well so its a problem with the extension.

@nhooyr nhooyr closed this as completed Jan 29, 2020
@nhooyr
Copy link
Contributor

nhooyr commented Jan 29, 2020

Actually it is broken.

image

Assigning to @code-asher

@nhooyr nhooyr reopened this Jan 29, 2020
@xcke
Copy link
Author

xcke commented Feb 28, 2020

Hi All, this is solved?

@code-asher
Copy link
Member

Not yet. The extension is manually spawning code, so I think the best fix would be to submit a PR to the extension to use the VS Code API instead of doing that.

@nhooyr
Copy link
Contributor

nhooyr commented Apr 17, 2020

Let's close this then. I'll open an issue on their repo.

@nhooyr nhooyr mentioned this issue Apr 17, 2020
Closed
@nhooyr
Copy link
Contributor

nhooyr commented Apr 17, 2020

sadesyllas/vscode-workspace-switcher#28

@nhooyr nhooyr closed this as completed Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@code-asher code-asher

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nhooyr @xcke @code-asher