-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Expand file tree
/
Copy pathai_providers_backfill_test.go
More file actions
249 lines (207 loc) · 8.66 KB
/
Copy pathai_providers_backfill_test.go
File metadata and controls
249 lines (207 loc) · 8.66 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
package coderd_test
import (
"database/sql"
"testing"
"github.com/stretchr/testify/require"
"go.uber.org/mock/gomock"
"cdr.dev/slog/v3/sloggers/slogtest"
"github.com/coder/coder/v2/coderd"
"github.com/coder/coder/v2/coderd/database"
"github.com/coder/coder/v2/coderd/database/dbgen"
"github.com/coder/coder/v2/coderd/database/dbmock"
"github.com/coder/coder/v2/coderd/database/dbtestutil"
"github.com/coder/coder/v2/testutil"
)
// TestBackfillBedrockProviderType runs all DB-backed cases against a single
// database instance. Subtests are intentionally sequential so that each one
// builds on the state left by the previous, which proves idempotency without
// extra setup: a second backfill call on an already-promoted DB must be a
// no-op. Failure-path tests use a mock and stay parallel.
func TestBackfillBedrockProviderType(t *testing.T) {
t.Parallel()
bedrockSettings := sql.NullString{
String: `{"_type":"bedrock","_version":1,"region":"us-east-1"}`,
Valid: true,
}
// All DB subtests share one database instance and run sequentially.
t.Run("DB", func(t *testing.T) {
t.Parallel()
db, _ := dbtestutil.NewDB(t)
ctx := testutil.Context(t, testutil.WaitMedium)
logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true})
t.Run("NoLegacyRows", func(t *testing.T) {
coderd.BackfillBedrockProviderType(ctx, db, logger)
all, err := db.GetAIProviders(ctx, database.GetAIProvidersParams{
IncludeDeleted: true,
IncludeDisabled: true,
})
require.NoError(t, err)
require.Empty(t, all)
})
t.Run("PromotesLegacyRow", func(t *testing.T) {
legacy := dbgen.AIProvider(t, db, database.AIProvider{
Type: database.AIProviderTypeAnthropic,
Settings: bedrockSettings,
})
require.Equal(t, database.AIProviderTypeAnthropic, legacy.Type, "pre-condition: row must start as anthropic")
coderd.BackfillBedrockProviderType(ctx, db, logger)
row, err := db.GetAIProviderByName(ctx, legacy.Name)
require.NoError(t, err)
require.Equal(t, database.AIProviderTypeBedrock, row.Type)
})
t.Run("Idempotent", func(t *testing.T) {
// DB already has one bedrock row from the previous subtest.
// A second run must be a no-op: no type changes, no new rows.
before, err := db.GetAIProviders(ctx, database.GetAIProvidersParams{
IncludeDeleted: true,
IncludeDisabled: true,
})
require.NoError(t, err)
for _, r := range before {
require.Equal(t, database.AIProviderTypeBedrock, r.Type,
"pre-condition: all rows must already be promoted before testing idempotency")
}
coderd.BackfillBedrockProviderType(ctx, db, logger)
after, err := db.GetAIProviders(ctx, database.GetAIProvidersParams{
IncludeDeleted: true,
IncludeDisabled: true,
})
require.NoError(t, err)
require.Equal(t, len(before), len(after), "second run must not create rows")
for i := range after {
require.Equal(t, before[i].Type, after[i].Type, "second run must not change types")
}
})
t.Run("PreservesNativeAnthropicRow", func(t *testing.T) {
native := dbgen.AIProvider(t, db, database.AIProvider{
Type: database.AIProviderTypeAnthropic,
})
require.Equal(t, database.AIProviderTypeAnthropic, native.Type, "pre-condition")
coderd.BackfillBedrockProviderType(ctx, db, logger)
row, err := db.GetAIProviderByName(ctx, native.Name)
require.NoError(t, err)
require.Equal(t, database.AIProviderTypeAnthropic, row.Type)
})
t.Run("PreservesNativeBedrockRow", func(t *testing.T) {
native := dbgen.AIProvider(t, db, database.AIProvider{
Type: database.AIProviderTypeBedrock,
Settings: bedrockSettings,
})
require.Equal(t, database.AIProviderTypeBedrock, native.Type, "pre-condition")
coderd.BackfillBedrockProviderType(ctx, db, logger)
row, err := db.GetAIProviderByName(ctx, native.Name)
require.NoError(t, err)
require.Equal(t, database.AIProviderTypeBedrock, row.Type)
})
t.Run("SkipsDeletedRows", func(t *testing.T) {
deleted := dbgen.AIProvider(t, db, database.AIProvider{
Type: database.AIProviderTypeAnthropic,
Settings: bedrockSettings,
})
require.Equal(t, database.AIProviderTypeAnthropic, deleted.Type, "pre-condition")
require.NoError(t, db.DeleteAIProviderByID(ctx, deleted.ID))
coderd.BackfillBedrockProviderType(ctx, db, logger)
row, err := db.GetAIProviders(ctx, database.GetAIProvidersParams{
IncludeDeleted: true,
IncludeDisabled: true,
})
require.NoError(t, err)
var found bool
for _, r := range row {
if r.ID == deleted.ID {
found = true
require.Equal(t, database.AIProviderTypeAnthropic, r.Type, "deleted row must not be promoted")
}
}
require.True(t, found, "deleted row must appear in IncludeDeleted result set")
})
t.Run("IncludesDisabledRows", func(t *testing.T) {
disabled := dbgen.AIProvider(t, db, database.AIProvider{
Type: database.AIProviderTypeAnthropic,
Enabled: false,
Settings: bedrockSettings,
})
require.Equal(t, database.AIProviderTypeAnthropic, disabled.Type, "pre-condition")
coderd.BackfillBedrockProviderType(ctx, db, logger)
row, err := db.GetAIProviderByName(ctx, disabled.Name)
require.NoError(t, err)
require.Equal(t, database.AIProviderTypeBedrock, row.Type, "disabled legacy row must be promoted")
})
t.Run("PreservesAnthropicRowWithNonBedrockSettings", func(t *testing.T) {
// {} has no _type discriminator, so UnmarshalJSON returns an error
// and the row is skipped via the unparsable-settings path, not the
// settings.Bedrock == nil guard. Either way the row must stay anthropic.
nonBedrock := dbgen.AIProvider(t, db, database.AIProvider{
Type: database.AIProviderTypeAnthropic,
Settings: sql.NullString{String: "{}", Valid: true},
})
require.Equal(t, database.AIProviderTypeAnthropic, nonBedrock.Type, "pre-condition")
coderd.BackfillBedrockProviderType(ctx, db, logger)
row, err := db.GetAIProviderByName(ctx, nonBedrock.Name)
require.NoError(t, err)
require.Equal(t, database.AIProviderTypeAnthropic, row.Type, "anthropic row with non-bedrock settings must not be promoted")
})
t.Run("SkipsUnparsableSettings", func(t *testing.T) {
malformed := dbgen.AIProvider(t, db, database.AIProvider{
Type: database.AIProviderTypeAnthropic,
Settings: sql.NullString{String: "{", Valid: true},
})
require.Equal(t, database.AIProviderTypeAnthropic, malformed.Type, "pre-condition")
good := dbgen.AIProvider(t, db, database.AIProvider{
Type: database.AIProviderTypeAnthropic,
Settings: bedrockSettings,
})
require.Equal(t, database.AIProviderTypeAnthropic, good.Type, "pre-condition")
coderd.BackfillBedrockProviderType(ctx, db, logger)
malformedRow, err := db.GetAIProviderByName(ctx, malformed.Name)
require.NoError(t, err)
require.Equal(t, database.AIProviderTypeAnthropic, malformedRow.Type, "row with unparsable settings must not be touched")
goodRow, err := db.GetAIProviderByName(ctx, good.Name)
require.NoError(t, err)
require.Equal(t, database.AIProviderTypeBedrock, goodRow.Type, "valid row alongside unparsable one must still be promoted")
})
})
t.Run("ListFailure", func(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitShort)
ctrl := gomock.NewController(t)
db := dbmock.NewMockStore(ctrl)
db.EXPECT().
GetAIProviders(gomock.Any(), gomock.Any()).
Return(nil, sql.ErrConnDone)
coderd.BackfillBedrockProviderType(ctx, db, slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}))
})
t.Run("UpdateFailure", func(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitShort)
ctrl := gomock.NewController(t)
db := dbmock.NewMockStore(ctrl)
db.EXPECT().
GetAIProviders(gomock.Any(), gomock.Any()).
Return([]database.AIProvider{{
Type: database.AIProviderTypeAnthropic,
Settings: bedrockSettings,
}}, nil)
db.EXPECT().
UpdateAIProvider(gomock.Any(), gomock.Any()).
Return(database.AIProvider{}, sql.ErrConnDone)
coderd.BackfillBedrockProviderType(ctx, db, slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}))
})
t.Run("ProviderDeletedDuringBackfill", func(t *testing.T) {
t.Parallel()
ctx := testutil.Context(t, testutil.WaitShort)
ctrl := gomock.NewController(t)
db := dbmock.NewMockStore(ctrl)
db.EXPECT().
GetAIProviders(gomock.Any(), gomock.Any()).
Return([]database.AIProvider{{
Type: database.AIProviderTypeAnthropic,
Settings: bedrockSettings,
}}, nil)
db.EXPECT().
UpdateAIProvider(gomock.Any(), gomock.Any()).
Return(database.AIProvider{}, sql.ErrNoRows)
// ErrNoRows is benign: provider was deleted between list and update.
coderd.BackfillBedrockProviderType(ctx, db, slogtest.Make(t, &slogtest.Options{IgnoreErrors: true}))
})
}