fix: Fix err check in DialWorkspaceAgentTailnet (#4320)

mafredri · web-flow · commit 00d062067945 · 2022-10-03T16:53:11.000+03:00
diff --git a/codersdk/workspaceagents.go b/codersdk/workspaceagents.go
@@ -331,22 +331,18 @@ func (c *Client) DialWorkspaceAgentTailnet(ctx context.Context, logger slog.Logg
 				// Need to disable compression to avoid a data-race.
 				CompressionMode: websocket.CompressionDisabled,
 			})
-			if errors.Is(err, context.Canceled) {
-				return
-			}
-			if isFirst {
-				if res.StatusCode == http.StatusConflict {
-					first <- readBodyAsError(res)
+			if err != nil {
+				if errors.Is(err, context.Canceled) {
 					return
 				}
-				isFirst = false
-				close(first)
-			}
-			if err != nil {
 				logger.Debug(ctx, "failed to dial", slog.Error(err))
 				continue
 			}
 			if isFirst {
+				if res.StatusCode == http.StatusConflict {
+					first <- readBodyAsError(res)
+					return
+				}
 				isFirst = false
 				close(first)
 			}
