test: test behaviour

DanielleMaywood · DanielleMaywood · commit 0a669151cef2 · 2024-10-23T12:30:49.000Z
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -5623,14 +5623,14 @@ func (q *FakeQuerier) GetUsersWithAccessToTemplateByID(ctx context.Context, id u
 	q.mutex.RLock()
 	defer q.mutex.RUnlock()
 
-	groups := make(map[string]bool, 0)
+	groups := make(map[string]struct{}, 0)
 	for _, template := range q.templates {
 		if template.ID != id {
 			continue
 		}
 
 		for group := range template.GroupACL {
-			groups[group] = true
+			groups[group] = struct{}{}
 		}
 	}
 
diff --git a/enterprise/coderd/templates_test.go b/enterprise/coderd/templates_test.go
@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"net/http"
+	"slices"
 	"testing"
 	"time"
 
@@ -38,17 +39,19 @@ func TestTemplates(t *testing.T) {
 	t.Run("Deprecated", func(t *testing.T) {
 		t.Parallel()
 
+		notifyEnq := &testutil.FakeNotificationsEnqueuer{}
 		owner, user := coderdenttest.New(t, &coderdenttest.Options{
 			Options: &coderdtest.Options{
 				IncludeProvisionerDaemon: true,
+				NotificationsEnqueuer:    notifyEnq,
 			},
 			LicenseOptions: &coderdenttest.LicenseOptions{
 				Features: license.Features{
 					codersdk.FeatureAccessControl: 1,
 				},
 			},
 		})
-		client, _ := coderdtest.CreateAnotherUser(t, owner, user.OrganizationID, rbac.RoleTemplateAdmin())
+		client, anotherUser := coderdtest.CreateAnotherUser(t, owner, user.OrganizationID, rbac.RoleTemplateAdmin())
 		version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil)
 		template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
 		coderdtest.AwaitTemplateVersionJobCompleted(t, client, version.ID)
@@ -65,6 +68,25 @@ func TestTemplates(t *testing.T) {
 		assert.True(t, updated.Deprecated)
 		assert.NotEmpty(t, updated.DeprecationMessage)
 
+		notifs := []*testutil.Notification{}
+		for _, notif := range notifyEnq.Sent {
+			if notif.TemplateID == notifications.TemplateTemplateDeprecated {
+				notifs = append(notifs, notif)
+			}
+		}
+		require.Equal(t, 2, len(notifs))
+
+		expectedSentTo := []string{user.UserID.String(), anotherUser.ID.String()}
+		slices.Sort(expectedSentTo)
+
+		sentTo := []string{}
+		for _, notif := range notifs {
+			sentTo = append(sentTo, notif.UserID.String())
+		}
+		slices.Sort(sentTo)
+
+		assert.Equal(t, expectedSentTo, sentTo)
+
 		_, err = client.CreateWorkspace(ctx, user.OrganizationID, codersdk.Me, codersdk.CreateWorkspaceRequest{
 			TemplateID: template.ID,
 			Name:       "foobar",

Original file line number	Diff line number	Diff line change
`@@ -5623,14 +5623,14 @@ func (q *FakeQuerier) GetUsersWithAccessToTemplateByID(ctx context.Context, id u`
`5623`	`5623`	`q.mutex.RLock()`
`5624`	`5624`	`defer q.mutex.RUnlock()`
`5625`	`5625`
`5626`		`- groups := make(map[string]bool, 0)`
	`5626`	`+ groups := make(map[string]struct{}, 0)`
`5627`	`5627`	`for _, template := range q.templates {`
`5628`	`5628`	`if template.ID != id {`
`5629`	`5629`	`continue`
`5630`	`5630`	`}`
`5631`	`5631`
`5632`	`5632`	`for group := range template.GroupACL {`
`5633`		`- groups[group] = true`
	`5633`	`+ groups[group] = struct{}{}`
`5634`	`5634`	`}`
`5635`	`5635`	`}`
`5636`	`5636`