Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 132a17c

Browse files
aqandrewaqandrew
authored
chore(site): enable consistent-type-imports oxlint rule (#29254)
Moves [consistent-type-imports](https://oxc.rs/docs/guide/usage/linter/rules/typescript/consistent-type-imports.html) out of the Oxlint migration backlog and sets it to `error`. In the 3 affected files, replaces dynamic `import()` syntax with `import type { Whatever } from "...";` Verified with: - `pnpm oxlint --deny-warnings` - `pnpm biome lint --error-on-warnings` - `pnpm tsc -p .`
1 parent c26a6b8 commit 132a17c

4 files changed

Lines changed: 11 additions & 7 deletions

File tree

‎site/.oxlintrc.jsonc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@
122122
// --- style (recommended) ---
123123
"no-array-constructor": "error",
124124
"prefer-exponentiation-operator": "error",
125+
"consistent-type-imports": "error",
125126
"consistent-type-exports": "error",
126127
"prefer-literal-enum-member": "error",
127128
"prefer-node-protocol": "error",
@@ -206,7 +207,6 @@
206207
"no-redeclare": "off", // suspicious/noRedeclare (medium: TS declaration merging)
207208
"no-irregular-whitespace": "off", // suspicious/noIrregularWhitespace (medium)
208209
"no-inferrable-types": "off", // style/noInferrableTypes (medium, coder error rule)
209-
"consistent-type-imports": "off", // style/useImportType (medium)
210210
"jsx-curly-brace-presence": "off", // style/useConsistentCurlyBraces (medium, coder error rule)
211211
"no-fallthrough": "off", // suspicious/noFallthroughSwitchClause (medium)
212212
"click-events-have-key-events": "off", // a11y/useKeyWithClickEvents (small)

‎site/.storybook/main.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import type { StorybookConfig } from "@storybook/react-vite";
2+
13
export default {
24
stories: ["../src/**/*.stories.tsx"],
35

@@ -32,4 +34,4 @@ export default {
3234
};
3335
return config;
3436
},
35-
} satisfies import("@storybook/react-vite").StorybookConfig;
37+
} satisfies StorybookConfig;

‎site/src/pages/AgentsPage/components/ChatConversation/useChatStore.ts‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ import {
2222
} from "#/api/queries/chats";
2323
import type * as TypesGen from "#/api/typesGenerated";
2424
import type { OneWayMessageEvent } from "#/utils/OneWayWebSocket";
25-
import { createReconnectingWebSocket } from "#/utils/reconnectingWebSocket";
25+
import {
26+
createReconnectingWebSocket,
27+
type ReconnectSchedule,
28+
} from "#/utils/reconnectingWebSocket";
2629
import { type ChatDetailError, normalizeChatErrorPayload } from "./chatError";
2730
import {
2831
type ChatStore,
@@ -743,9 +746,7 @@ export const useChatStore = (
743746
historyResetPending = false;
744747
historyReplacementBuf.length = 0;
745748
},
746-
onDisconnect(
747-
reconnectState: import("#/utils/reconnectingWebSocket").ReconnectSchedule,
748-
) {
749+
onDisconnect(reconnectState: ReconnectSchedule) {
749750
// Only surface reconnecting when the disconnect
750751
// interrupted active response work. Idle watcher
751752
// reconnects stay silent.

‎site/src/pages/AgentsPage/components/ChatElements/tools/Tool.stories.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { chatModelKey } from "#/api/queries/chats";
55
import { workspaceBuildLogs } from "#/api/queries/workspaceBuilds";
66
import { workspaceByIdKey } from "#/api/queries/workspaces";
77
import type * as TypesGen from "#/api/typesGenerated";
8+
import type { MCPServerConfig } from "#/api/typesGenerated";
89
import { MockChatModel } from "#/testHelpers/chatModels";
910
import { MockWorkspace, MockWorkspaceBuild } from "#/testHelpers/entities";
1011
import { ChatWorkspaceContext } from "../../../context/ChatWorkspaceContext";
@@ -1364,7 +1365,7 @@ const sampleMCPServers = [
13641365
created_at: "2025-01-01T00:00:00Z",
13651366
updated_at: "2025-01-01T00:00:00Z",
13661367
},
1367-
] satisfies readonly import("#/api/typesGenerated").MCPServerConfig[];
1368+
] satisfies MCPServerConfig[];
13681369

13691370
export const MCPToolRunning: Story = {
13701371
args: {

0 commit comments

Comments
 (0)