Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 1b3b0ea

Browse files
authored
fix: adjust workspace filter query when the path changes (#6539)
Previously, when a status would change the filter wouldn't update. This makes it update if a new value is passed in.
1 parent 9a79983 commit 1b3b0ea

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

site/src/components/SearchBarWithFilter/SearchBarWithFilter.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { makeStyles } from "@material-ui/core/styles"
88
import { Theme } from "@material-ui/core/styles/createTheme"
99
import SearchIcon from "@material-ui/icons/Search"
1010
import debounce from "just-debounce-it"
11-
import { useCallback, useRef, useState } from "react"
11+
import { useCallback, useEffect, useRef, useState } from "react"
1212
import { getValidationErrorMessage } from "../../api/errors"
1313
import { CloseDropdown, OpenDropdown } from "../DropdownArrows/DropdownArrows"
1414
import { Stack } from "../Stack/Stack"
@@ -35,7 +35,10 @@ export const SearchBarWithFilter: React.FC<
3535
> = ({ filter, onFilter, presetFilters, error, docs }) => {
3636
const styles = useStyles({ error: Boolean(error) })
3737
const searchInputRef = useRef<HTMLInputElement>(null)
38-
38+
const [value, setValue] = useState(filter)
39+
useEffect(() => {
40+
setValue(filter)
41+
}, [filter])
3942
// debounce query string entry by user
4043
// we want the dependency array empty here
4144
// as we don't need to redefine the function
@@ -92,10 +95,11 @@ export const SearchBarWithFilter: React.FC<
9295
<OutlinedInput
9396
id="query"
9497
name="query"
95-
defaultValue={filter}
9698
error={Boolean(error)}
99+
value={value}
97100
className={styles.inputStyles}
98101
onChange={(event) => {
102+
setValue(event.currentTarget.value)
99103
debouncedOnFilter(event.currentTarget.value)
100104
}}
101105
inputRef={searchInputRef}

0 commit comments

Comments
 (0)