Apply suggestions from code review

johnstcn · dannykopping · web-flow · commit 1b4b20d4457e · 2025-01-29T12:59:20.000Z
Co-authored-by: Danny Kopping &lt;danny@coder.com&gt;
diff --git a/agent/agentscripts/agentscripts_other.go b/agent/agentscripts/agentscripts_other.go
@@ -18,7 +18,7 @@ func cmdSysProcAttr() *syscall.SysProcAttr {
 
 func cmdCancel(ctx context.Context, logger slog.Logger, cmd *exec.Cmd) func() error {
 	return func() error {
-		logger.Debug(ctx, "cmdCancel: sending SIGHUP to process", slog.F("pid", -cmd.Process.Pid))
+		logger.Debug(ctx, "cmdCancel: sending SIGHUP to process and children", slog.F("pid", cmd.Process.Pid))
 		return syscall.Kill(-cmd.Process.Pid, syscall.SIGHUP)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ func cmdSysProcAttr() *syscall.SysProcAttr {`
`18`	`18`
`19`	`19`	`func cmdCancel(ctx context.Context, logger slog.Logger, cmd *exec.Cmd) func() error {`
`20`	`20`	`return func() error {`
`21`		`- logger.Debug(ctx, "cmdCancel: sending SIGHUP to process", slog.F("pid", -cmd.Process.Pid))`
	`21`	`+ logger.Debug(ctx, "cmdCancel: sending SIGHUP to process and children", slog.F("pid", cmd.Process.Pid))`
`22`	`22`	`return syscall.Kill(-cmd.Process.Pid, syscall.SIGHUP)`
`23`	`23`	`}`
`24`	`24`	`}`