Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 1dda810

Browse files
committed
Extract language
1 parent 272633b commit 1dda810

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

site/src/pages/UsersPage/UsersPage.test.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
import { screen } from "@testing-library/react"
22
import React from "react"
3-
import { render } from "../../test_helpers"
3+
import { MockPager, render } from "../../test_helpers"
44
import { UsersPage } from "./UsersPage"
5+
import { Language } from "./UsersPageView"
56

67
describe("Users Page", () => {
78
it("has a header with the total number of users", async () => {
89
render(<UsersPage />)
910
const total = await screen.findByText(/\d+ total/)
10-
expect(total.innerHTML).toEqual("2 total")
11+
expect(total.innerHTML).toEqual(Language.pageSubtitle(MockPager))
1112
})
1213
it("shows users", async () => {
1314
render(<UsersPage />)

site/src/pages/UsersPage/UsersPageView.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@ import { Pager, UserResponse } from "../../api/types"
44
import { Header } from "../../components/Header"
55
import { UsersTable } from "../../components/UsersTable/UsersTable"
66

7-
const Language = {
7+
export const Language = {
88
pageTitle: "Users",
9+
pageSubtitle: (pager: Pager | undefined) => (pager ? `{pager.total} total` : ""),
910
}
1011

1112
export interface UsersPageViewProps {
@@ -17,7 +18,7 @@ export const UsersPageView: React.FC<UsersPageViewProps> = ({ users, pager }) =>
1718
const styles = useStyles()
1819
return (
1920
<div className={styles.flexColumn}>
20-
<Header title={Language.pageTitle} subTitle={pager ? `${pager.total} total` : ""} />
21+
<Header title={Language.pageTitle} subTitle={Language.pageSubtitle(pager)} />
2122
<UsersTable users={users} />
2223
</div>
2324
)

0 commit comments

Comments
 (0)