refactor: Make navbar and users tab href consistent (#5754)

BrunoQuaresma · web-flow · commit 28b2bbd09529 · 2023-01-17T19:05:54.000-03:00
diff --git a/site/src/components/NavbarView/NavbarView.tsx b/site/src/components/NavbarView/NavbarView.tsx
@@ -13,6 +13,8 @@ import { navHeight } from "../../theme/constants"
 import { combineClasses } from "../../util/combineClasses"
 import { UserDropdown } from "../UserDropdown/UsersDropdown"
 
+export const USERS_LINK = `/users?filter=${encodeURIComponent("status:active")}`
+
 export interface NavbarViewProps {
   logo_url?: string
   user?: TypesGen.User
@@ -59,10 +61,7 @@ const NavItems: React.FC<
         </NavLink>
       </ListItem>
       <ListItem button className={styles.item}>
-        <NavLink
-          className={styles.link}
-          to={`/users?filter=${encodeURIComponent("status:active")}`}
-        >
+        <NavLink className={styles.link} to={USERS_LINK}>
           {Language.users}
         </NavLink>
       </ListItem>
diff --git a/site/src/components/UsersLayout/UsersLayout.tsx b/site/src/components/UsersLayout/UsersLayout.tsx
@@ -3,6 +3,7 @@ import Link from "@material-ui/core/Link"
 import { makeStyles } from "@material-ui/core/styles"
 import GroupAdd from "@material-ui/icons/GroupAddOutlined"
 import PersonAdd from "@material-ui/icons/PersonAddOutlined"
+import { USERS_LINK } from "components/NavbarView/NavbarView"
 import { PageHeader, PageHeaderTitle } from "components/PageHeader/PageHeader"
 import { useFeatureVisibility } from "hooks/useFeatureVisibility"
 import { usePermissions } from "hooks/usePermissions"
@@ -61,7 +62,7 @@ export const UsersLayout: FC = () => {
           <Stack direction="row" spacing={0.25}>
             <NavLink
               end
-              to="/users"
+              to={USERS_LINK}
               className={({ isActive }) =>
                 combineClasses([
                   styles.tabItem,
