Clean up ErrorSummary while I'm here

presleyp · presleyp · commit 30ced2f344b8 · 2022-04-13T19:55:10.000Z
diff --git a/site/src/components/ErrorSummary/index.tsx b/site/src/components/ErrorSummary/index.tsx
@@ -1,5 +1,9 @@
 import React from "react"
 
+const Language = {
+  unknownErrorMessage: "Unknown error"
+}
+
 export interface ErrorSummaryProps {
   error: Error | unknown
 }
@@ -8,8 +12,8 @@ export const ErrorSummary: React.FC<ErrorSummaryProps> = ({ error }) => {
   // TODO: More interesting error page
 
   if (!(error instanceof Error)) {
-    return <div>{"Unknown error"}</div>
+    return <div>{Language.unknownErrorMessage}</div>
+  } else {
+    return <div>{error.toString()}</div>
   }
-
-  return <div>{error.toString()}</div>
 }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,9 @@`
`1`	`1`	`import React from "react"`
`2`	`2`
	`3`	`+const Language = {`
	`4`	`+ unknownErrorMessage: "Unknown error"`
	`5`	`+}`
	`6`	`+`
`3`	`7`	`export interface ErrorSummaryProps {`
`4`	`8`	`error: Error \| unknown`
`5`	`9`	`}`
`@@ -8,8 +12,8 @@ export const ErrorSummary: React.FC<ErrorSummaryProps> = ({ error }) => {`
`8`	`12`	`// TODO: More interesting error page`
`9`	`13`
`10`	`14`	`if (!(error instanceof Error)) {`
`11`		`- return <div>{"Unknown error"}</div>`
	`15`	`+ return <div>{Language.unknownErrorMessage}</div>`
	`16`	`+ } else {`
	`17`	`+ return <div>{error.toString()}</div>`
`12`	`18`	`}`
`13`		`-`
`14`		`- return <div>{error.toString()}</div>`
`15`	`19`	`}`