Block on sending stat updates

kylecarbs · kylecarbs · commit 37ad03fd8964 · 2023-03-07T19:02:01.000Z
diff --git a/agent/agent.go b/agent/agent.go
@@ -1272,14 +1272,11 @@ func (a *agent) startReportingConnectionStats(ctx context.Context) {
 			a.logger.Info(ctx, "skipping stat because nothing changed")
 			return
 		}
+		a.latestStat.Store(stats)
 
 		select {
 		case a.connStatsChan <- stats:
-			// Only store the latest stat when it's successfully sent!
-			// Otherwise, it should be sent again on the next iteration.
-			a.latestStat.Store(stats)
-		default:
-			a.logger.Warn(ctx, "network stat dropped")
+		case <-a.closed:
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1272,14 +1272,11 @@ func (a *agent) startReportingConnectionStats(ctx context.Context) {`
`1272`	`1272`	`a.logger.Info(ctx, "skipping stat because nothing changed")`
`1273`	`1273`	`return`
`1274`	`1274`	`}`
	`1275`	`+ a.latestStat.Store(stats)`
`1275`	`1276`
`1276`	`1277`	`select {`
`1277`	`1278`	`case a.connStatsChan <- stats:`
`1278`		`- // Only store the latest stat when it's successfully sent!`
`1279`		`- // Otherwise, it should be sent again on the next iteration.`
`1280`		`- a.latestStat.Store(stats)`
`1281`		`- default:`
`1282`		`- a.logger.Warn(ctx, "network stat dropped")`
	`1279`	`+ case <-a.closed:`
`1283`	`1280`	`}`
`1284`	`1281`	`}`
`1285`	`1282`